Re: [PATCH i-g-t v2 5/5] tests/prime_udl: Rename into i915_prime_udl

Karthik B S
2026-04-27T03:43:48Z

Hi Kamil,

On 4/24/2026 6:17 PM, Kamil Konieczny wrote:
> Hi Karthik,
> On 2026-04-23 at 15:59:02 +0530, Karthik B S wrote:
>> Hi Kamil,
>>
>> On 4/22/2026 9:14 PM, Kamil Konieczny wrote:
>>> This is an i915 test so rename it and move it to tests/intel/.
>>> Add documentation so build will not become broken.
>>>
>>> Cc: Karthik B S <karthik.b.s@intel.com>
>>> Suggested-by: Karthik B S <karthik.b.s@intel.com>
>>> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>>> ---
>>> tests/{prime_udl.c => intel/i915_prime_udl.c} | 17 +++++++++++++++++
>>> tests/meson.build | 2 +-
>>> 2 files changed, 18 insertions(+), 1 deletion(-)
>>> rename tests/{prime_udl.c => intel/i915_prime_udl.c} (88%)
>>>
>>> diff --git a/tests/prime_udl.c b/tests/intel/i915_prime_udl.c
>>> similarity index 88%
>>> rename from tests/prime_udl.c
>>> rename to tests/intel/i915_prime_udl.c
>>> index db83152fc..0f2dd50c0 100644
>>> --- a/tests/prime_udl.c
>>> +++ b/tests/intel/i915_prime_udl.c
>>> @@ -13,6 +13,23 @@
>>> #include "i915/gem_create.h"
>>> +/**
>>> + * TEST: i915 prime udl
>>> + * Category: Display
>> Since this is display test, could it be name kms_*?
> Or should I just keep name intact? There is already
> a line in xe.blocklist for igt@prime_.*
> so no rename, only moveing it into tests/intel/
> should be enough. Also, there are no kms tests in meson i915
> progs, and this kms_* change will also require additional
> change in xe.blocklist. What you think?

This should be fine, as anyway we are calling it it out as display test
in 'Mega feature' as well. Works for me.

Regards,
Karthik.B.S
>
>>> + * Description: Basic set of prime tests between Intel and DisplayLink.
>>> + * Driver requirement: i915
>>> + * Mega feature: General Display Features
>>> + * Sub-category: Memory management tests
>>> + * Functionality: prime import/export
>>> + * Test category: GEM_Legacy
>>> + * Feature: prime
>> And then we could only keep upto Mega feature as other fields aren't used
>> for display.
> Thank you, I will change it.
>
> Regards,
> Kamil
>
>> https://patchwork.freedesktop.org/patch/636176/?series=144584&rev=1
>>
>> Regards,
>> Karthik.B.S
>>> + *
>>> + * SUBTEST: share-import
>>> + *
>>> + * SUBTEST: share-import-addfb
>>> + *
>>> + */
>>> +
>>> IGT_TEST_DESCRIPTION("Basic set of prime tests between Intel and DisplayLink");
>>> int intel_fd = -1, udl_fd = -1;
>>> diff --git a/tests/meson.build b/tests/meson.build
>>> index 4c1a39e9e..196fff8ca 100644
>>> --- a/tests/meson.build
>>> +++ b/tests/meson.build
>>> @@ -72,7 +72,6 @@ test_progs = [
>>> 'kms_vrr',
>>> 'kms_writeback',
>>> 'meta_test',
>>> - 'prime_udl',
>>> 'prime_vgem',
>>> 'sriov_basic',
>>> 'syncobj_basic',
>>> @@ -231,6 +230,7 @@ intel_i915_progs = [
>>> 'i915_pm_rps',
>>> 'i915_pm_sseu',
>>> 'i915_power',
>>> + 'i915_prime_udl',
>>> 'i915_query',
>>> 'i915_selftest',
>>> 'i915_suspend',