From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43275FDEE32 for ; Thu, 23 Apr 2026 17:36:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F0A5510E36B; Thu, 23 Apr 2026 17:36:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="gM7Enb9s"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E87A10E36B for ; Thu, 23 Apr 2026 17:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776965763; x=1808501763; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ajZ9PVPFN4ROhwOaNFQQhEF9UrpYAM5zUIzdkLPUL/k=; b=gM7Enb9sbfO2CGHYe8aFgYrHlTk/lID/2KEWOXqYbPnssHE/HJRNMPL8 IwMNv7xsUXF5Y35NrAMU86EJ5CCpea7n30ImsFEksbhX4+wqc/w6Qxxa9 hxdwi9VS+uHSe4i6JijtSqtJ1yE1+5rQuxVmsVR8SKFVFWm9uQX6lSH/U OZprCrms1Eqyp03I6UVYLBIxICS9q7bjd6fMTLB3WN/t/g56pkF1V2z6t GA5VEEQd7ZrEOJ4ydxolZuLNaLJCMapltzS2rJtRRFSJSLy2b76S06afz JJj9/CAWil9UVfS2YUtE7IMmp63ojUrh3YXdnhZoDMQu++tw/dQzg73S5 w==; X-CSE-ConnectionGUID: HOyqgUPpScW53L9UccsHIQ== X-CSE-MsgGUID: 6bkOU9qVRWeyZouA9etPVQ== X-IronPort-AV: E=McAfee;i="6800,10657,11765"; a="78134691" X-IronPort-AV: E=Sophos;i="6.23,195,1770624000"; d="scan'208";a="78134691" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2026 10:36:03 -0700 X-CSE-ConnectionGUID: 1WrrtvX+QLG4H0jN/HJFNQ== X-CSE-MsgGUID: UxXeswYRRjeX9fJrRyj7bg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,195,1770624000"; d="scan'208";a="229527315" Received: from jeevan-x299-aorus-gaming-3-pro.iind.intel.com ([10.227.90.91]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2026 10:36:01 -0700 From: Jeevan B To: igt-dev@lists.freedesktop.org Cc: animesh.manna@intel.com, dibin.moolakadan.subrahmanian@intel.com, mohammed.thasleem@intel.com, ramanaidu.naladala@intel.com, jani.nikula@intel.com, Jeevan B Subject: [PATCH i-g-t v3 2/6] tests/intel/kms_pm_dc: Replace require with proper assertion Date: Thu, 23 Apr 2026 23:03:59 +0530 Message-ID: <20260423173403.123706-3-jeevan.b@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260423173403.123706-1-jeevan.b@intel.com> References: <20260423173403.123706-1-jeevan.b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" The DC3CO video playback simulation test was incorrectly using require at the end to check if DC3CO state was entered. This causes the test to be marked as SKIP instead of FAIL when DC3CO doesn't work properly, hiding real issues. So changing the call from require to assert. Fixes: b89efa8048e58 ("tests/i915/i915_pm_dc: Check dc3co count to skip the test") Signed-off-by: Jeevan B Reviewed-by: Mohammed Thasleem --- tests/intel/kms_pm_dc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c index c8cfa300c..27fa5dc39 100644 --- a/tests/intel/kms_pm_dc.c +++ b/tests/intel/kms_pm_dc.c @@ -316,8 +316,7 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data) usleep(delay); } - igt_require_f(igt_dc_state_wait_entry(data->debugfs_fd, IGT_INTEL_CHECK_DC3CO, - dc3co_prev_cnt), "dc3co-vpb-simulation not enabled\n"); + assert_dc_counter(data, IGT_INTEL_CHECK_DC3CO, dc3co_prev_cnt); } static void setup_dc3co(data_t *data) -- 2.43.0