From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: animesh.manna@intel.com, dibin.moolakadan.subrahmanian@intel.com,
mohammed.thasleem@intel.com, ramanaidu.naladala@intel.com,
jani.nikula@intel.com, Jeevan B <jeevan.b@intel.com>
Subject: [PATCH i-g-t v3 3/6] tests/intel/kms_pm_dc: Enable DC3CO test for PSR2/PR modes
Date: Thu, 23 Apr 2026 23:04:00 +0530 [thread overview]
Message-ID: <20260423173403.123706-4-jeevan.b@intel.com> (raw)
In-Reply-To: <20260423173403.123706-1-jeevan.b@intel.com>
Enable DC3CO with PSR2/PR mode on TGL and for platforms with
display version greater than 35.
v2: Fix debug, remove trailing dash and merge mode and char to
single strcut array.
v3: Minor cosmetic changes.
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/intel/kms_pm_dc.c | 50 ++++++++++++++++++++++++++++++++---------
1 file changed, 39 insertions(+), 11 deletions(-)
diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
index 27fa5dc39..83652e9f8 100644
--- a/tests/intel/kms_pm_dc.c
+++ b/tests/intel/kms_pm_dc.c
@@ -110,6 +110,11 @@ typedef struct {
bool runtime_suspend_disabled;
} data_t;
+struct dc3co_test_mode {
+ enum psr_mode mode;
+ const char *name;
+};
+
static void assert_dc_counter(data_t *data, int dc_flag, uint32_t prev_dc_count);
static void set_output_on_pipe_b(data_t *data)
@@ -319,18 +324,20 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data)
assert_dc_counter(data, IGT_INTEL_CHECK_DC3CO, dc3co_prev_cnt);
}
-static void setup_dc3co(data_t *data)
+static void setup_dc3co(data_t *data, enum psr_mode mode)
{
+ data->op_psr_mode = mode;
psr_enable(data->drm_fd, data->debugfs_fd, data->op_psr_mode, data->output);
- igt_require_f(psr_wait_entry(data->debugfs_fd, data->op_psr_mode, data->output),
- "PSR2 is not enabled\n");
+ igt_require_f(psr_wait_entry(data->debugfs_fd, data->op_psr_mode, NULL),
+ "%s is not enabled\n",
+ mode == PSR_MODE_2 ? "PSR2" : "Panel Replay");
}
-static void test_dc3co_vpb_simulation(data_t *data)
+static void test_dc3co_vpb_simulation(data_t *data, enum psr_mode mode)
{
igt_require_dc_counter(data->debugfs_fd, IGT_INTEL_CHECK_DC3CO);
setup_output(data);
- setup_dc3co(data);
+ setup_dc3co(data, mode);
setup_videoplayback(data);
check_dc3co_with_videoplayback_like_load(data);
cleanup_dc3co_fbs(data);
@@ -658,12 +665,33 @@ int igt_main()
}
igt_describe("In this test we make sure that system enters DC3CO "
- "when PSR2 is active and system is in SLEEP state");
- igt_subtest("dc3co-vpb-simulation") {
- data.op_psr_mode = PSR_MODE_2;
- igt_require(psr_sink_support(data.drm_fd, data.debugfs_fd,
- data.op_psr_mode, NULL));
- test_dc3co_vpb_simulation(&data);
+ "when PSR2 or PR is active and system is in SLEEP state");
+ igt_subtest_with_dynamic("dc3co-vpb-simulation") {
+ static const struct dc3co_test_mode dc3co_modes[] = {
+ { PSR_MODE_2, "psr2" },
+ { PR_MODE, "pr" },
+ };
+
+ for (int i = 0; i < ARRAY_SIZE(dc3co_modes); i++) {
+ enum psr_mode mode = dc3co_modes[i].mode;
+ const char *name = dc3co_modes[i].name;
+
+ igt_dynamic_f("%s", name) {
+ igt_require(psr_sink_support(data.drm_fd,
+ data.debugfs_fd,
+ mode, NULL));
+
+ if (mode == PSR_MODE_2)
+ igt_require_f(IS_TIGERLAKE(data.devid) ||
+ intel_display_ver(data.devid) >= 35,
+ "Platform does not support DC3CO with PSR2\n");
+ else
+ igt_require_f(intel_display_ver(data.devid) >= 35,
+ "Platform does not support DC3CO with Panel Replay\n");
+
+ test_dc3co_vpb_simulation(&data, mode);
+ }
+ }
}
igt_describe("This test validates display engine entry to DC5 state "
--
2.43.0
next prev parent reply other threads:[~2026-04-23 17:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 17:33 [PATCH i-g-t v3 0/6] Enable and Add new tests for DC3CO Jeevan B
2026-04-23 17:33 ` [PATCH i-g-t v3 1/6] tests: s/check_dc_counter/assert_dc_counter Jeevan B
2026-04-23 17:33 ` [PATCH i-g-t v3 2/6] tests/intel/kms_pm_dc: Replace require with proper assertion Jeevan B
2026-04-23 17:34 ` Jeevan B [this message]
2026-04-23 17:34 ` [PATCH i-g-t v3 4/6] tests/kms_vrr: Add new test for DC3CO validation with LOBF Jeevan B
2026-04-23 17:34 ` [PATCH i-g-t v3 5/6] tests/intel/kms_pm_dc: Add new test for dc3co framedrop validation Jeevan B
2026-04-23 17:34 ` [PATCH i-g-t v3 6/6] RFC: tests/intel/kms_pm_dc: Add new test for DC3CO recovery after DC6 Jeevan B
2026-04-23 18:34 ` ✓ Xe.CI.BAT: success for Enable and Add new tests for DC3CO (rev4) Patchwork
2026-04-23 18:36 ` ✗ i915.CI.BAT: failure " Patchwork
2026-04-24 2:10 ` ✗ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260423173403.123706-4-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=animesh.manna@intel.com \
--cc=dibin.moolakadan.subrahmanian@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=mohammed.thasleem@intel.com \
--cc=ramanaidu.naladala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox