Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Swati Sharma <swati2.sharma@intel.com>
Subject: [PATCH i-g-t] tests/intel/kms_cdclk: Skip non-4K outputs instead of skipping the test
Date: Fri,  1 May 2026 16:06:34 +0530	[thread overview]
Message-ID: <20260501103634.2360004-1-swati2.sharma@intel.com> (raw)

The mode-transition-all-outputs subtest currently skips the entire
test as soon as any single connected output lacks a >= 4K mode. On
typical setups (e.g. an eDP panel limited to 2880x1800 alongside
multiple 4K external displays), this prevents the test from running
even though enough 4K-capable outputs are available to exercise the
CDCLK transition.

Replace the igt_require_f() check with a per-output skip: outputs
without a >= 4K mode are simply omitted from the valid_outputs list
and the test continues with the remaining ones. The existing
igt_skip_on_f(count < 2) guard still ensures we only run when at
least two valid outputs are present.

Co-developed-by: Claude Opus 4.6
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/intel/kms_cdclk.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/intel/kms_cdclk.c b/tests/intel/kms_cdclk.c
index 48bd7276f..070fba400 100644
--- a/tests/intel/kms_cdclk.c
+++ b/tests/intel/kms_cdclk.c
@@ -271,8 +271,11 @@ static void test_mode_transition_on_all_outputs(data_t *data)
 
 	for_each_connected_output(display, output) {
 		mode_highres[count] = *igt_output_get_highres_mode(output);
-		igt_require_f(is_4k(mode_highres[count]), "Mode >= 4K not found on output %s.\n",
-			      igt_output_name(output));
+		if (!is_4k(mode_highres[count])) {
+			igt_info("Mode >= 4K not found on output %s; skipping\n",
+				 igt_output_name(output));
+			continue;
+		}
 
 		mode_lowres[count] = *get_lowres_mode(output);
 
-- 
2.25.1


             reply	other threads:[~2026-05-01 10:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-01 10:36 Swati Sharma [this message]
2026-05-01 11:13 ` ✓ Xe.CI.BAT: success for tests/intel/kms_cdclk: Skip non-4K outputs instead of skipping the test Patchwork
2026-05-01 11:18 ` ✗ i915.CI.BAT: failure " Patchwork
2026-05-06  6:57   ` Sharma, Swati2
2026-05-01 12:39 ` ✗ Xe.CI.FULL: " Patchwork
2026-05-05  6:33 ` [PATCH i-g-t] " Karthik B S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260501103634.2360004-1-swati2.sharma@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox