From: "Michał Grzelak" <michal.grzelak@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jani.nikula@intel.com, suraj.kandpal@intel.com,
"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH i-g-t v1 4/7] tools/vbt_decode: nuke get_device_id()
Date: Thu, 7 May 2026 03:28:18 +0200 [thread overview]
Message-ID: <20260507012821.527453-5-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260507012821.527453-1-michal.grzelak@intel.com>
VBT dump file does not contain device id. Stop calling the function and
remove it.
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
tools/intel_vbt_decode.c | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
index 6879bd7a7e..f7ba4bc3d5 100644
--- a/tools/intel_vbt_decode.c
+++ b/tools/intel_vbt_decode.c
@@ -3699,26 +3699,6 @@ static int get_sdvo_panel_type(struct context *context)
return panel_type;
}
-static int
-get_device_id(unsigned char *bios, int size)
-{
- int device;
- int offset = (bios[0x19] << 8) + bios[0x18];
-
- if (offset + 7 >= size)
- return -1;
-
- if (bios[offset] != 'P' ||
- bios[offset+1] != 'C' ||
- bios[offset+2] != 'I' ||
- bios[offset+3] != 'R')
- return -1;
-
- device = (bios[offset+7] << 8) + bios[offset+6];
-
- return device;
-}
-
struct dumper {
uint8_t id;
uint16_t min_bdb_version;
@@ -4324,8 +4304,6 @@ int main(int argc, char **argv)
if (devid_string)
context.devid = strtoul(devid_string, NULL, 16);
}
- if (!context.devid)
- context.devid = get_device_id(VBIOS, size);
if (!context.devid)
fprintf(stderr, "Warning: could not find PCI device ID!\n");
--
2.45.2
next prev parent reply other threads:[~2026-05-07 1:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 1:28 [PATCH i-g-t v1 0/7] Vswing/Preemphasis Override decoding Michał Grzelak
2026-05-07 1:28 ` [PATCH i-g-t v1 1/7] tools/vbt_decode: fix tables' offset reading Michał Grzelak
2026-05-07 1:28 ` [PATCH i-g-t v1 2/7] tools/vbt_decode: vary number of rows wrt VBT #57 Michał Grzelak
2026-05-07 1:28 ` [PATCH i-g-t v1 3/7] tools/vbt_decode: rename VBT#57 related vars Michał Grzelak
2026-05-07 1:28 ` Michał Grzelak [this message]
2026-05-07 1:28 ` [PATCH i-g-t v1 5/7] tools/vbt_decode: parse & dump VS/PE-O tables for LT Michał Grzelak
2026-05-07 1:28 ` [PATCH i-g-t v1 6/7] tools/vbt_decode: parse & dump VS/PE-O tables for Snps Michał Grzelak
2026-05-07 1:28 ` [PATCH i-g-t v1 7/7] tools/vbt_decode: parse & dump VS/PE-O tables for JSL Michał Grzelak
2026-05-07 5:55 ` ✓ Xe.CI.BAT: success for Vswing/Preemphasis Override decoding Patchwork
2026-05-07 5:57 ` ✓ i915.CI.BAT: " Patchwork
2026-05-07 14:41 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-05-07 15:19 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260507012821.527453-5-michal.grzelak@intel.com \
--to=michal.grzelak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=suraj.kandpal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox