From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE985CD37BE for ; Mon, 11 May 2026 13:58:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8B14410E778; Mon, 11 May 2026 13:58:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="K6KTsdIU"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D9B010E776 for ; Mon, 11 May 2026 13:58:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778507894; x=1810043894; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=wnx6OvBPEM3Vsmfo04L/yEF4R5bY3O0Fkp1zK7WvV8U=; b=K6KTsdIUw2VQC0an5PiVhQYEbpIvXXLNgUG44DHKYdHSzfhNgv+ETLbS hS176IPbxOYxWbBY20SybwZPss9miWPfbkpbpq89wYVFzrQ2f7nimgWMX ya1bDMxepAPmcbcVumYyftyMn9MAmtRsra0ApOHckEIKJ5CcZBW4QGMLP J+3qdJGbyrE3HtbDR+bSqumk4uwa4A2NttMxMwrzEm9Vq5YoKUUK9OzBn XOs/Juyz8BMKQhv0DnqdvtOh+6CaHbFZ7+8sAhBQtVnFjH6joZuWVtxpD tO6lYPWAXTlXP2QK/KxKPSXKLmGrdgwlY4yky0sGU+VDM3dZvuCoWZkVi A==; X-CSE-ConnectionGUID: 9ZtUP7OGS1aJEzShphtd7w== X-CSE-MsgGUID: 7cP1MkwgT3CP52LVcelzRw== X-IronPort-AV: E=McAfee;i="6800,10657,11783"; a="81957740" X-IronPort-AV: E=Sophos;i="6.23,229,1770624000"; d="scan'208";a="81957740" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2026 06:58:13 -0700 X-CSE-ConnectionGUID: yoZEzsDrRf+aghYHIj4nbg== X-CSE-MsgGUID: JuribAzjRaebGuYMKUB/Rw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,229,1770624000"; d="scan'208";a="241817552" Received: from varungup-desk.iind.intel.com ([10.190.238.71]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2026 06:58:12 -0700 From: Varun Gupta To: igt-dev@lists.freedesktop.org Cc: arvind.yadav@intel.com, himal.prasad.ghimiray@intel.com, nishit.sharma@intel.com Subject: [PATCH i-g-t v3 2/4] tests/intel/xe_madvise: Add atomic-device subtest Date: Mon, 11 May 2026 19:27:35 +0530 Message-ID: <20260511135752.119868-3-varun.gupta@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260511135752.119868-1-varun.gupta@intel.com> References: <20260511135752.119868-1-varun.gupta@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" Validate that madvise ATOMIC_DEVICE allows GPU MI_ATOMIC_INC on SVM memory. The test creates a fault-mode VM with CPU_ADDR_MIRROR binding over heap memory allocated via aligned_alloc(). After setting ATOMIC_DEVICE via DRM_XE_MEM_RANGE_ATTR_ATOMIC madvise, the GPU executes MI_ATOMIC_INC through the page-fault handler which migrates pages to VRAM for device atomics. Also adds the shared atomic test infrastructure: struct atomic_data, atomic_build_batch() helper, timeout constants, and the atomic subtest group gated on VRAM and fault-mode support. v2: Add UNMAP of CPU_ADDR_MIRROR binding before xe_vm_destroy. Add pagefault count print before/after exec (Nishit). v3: Print pagefault count only when count changed (Nishit). Reviewed-by: Nishit Sharma Signed-off-by: Varun Gupta --- tests/intel/xe_madvise.c | 123 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 122 insertions(+), 1 deletion(-) diff --git a/tests/intel/xe_madvise.c b/tests/intel/xe_madvise.c index e79cafbff..8aecd0e5b 100644 --- a/tests/intel/xe_madvise.c +++ b/tests/intel/xe_madvise.c @@ -14,9 +14,12 @@ #include "igt.h" #include "xe_drm.h" +#include "intel_gpu_commands.h" +#include "lib/igt_syncobj.h" +#include "lib/intel_reg.h" +#include "xe/xe_gt.h" #include "xe/xe_ioctl.h" #include "xe/xe_query.h" -#include "lib/igt_syncobj.h" /* Purgeable test constants */ #define PURGEABLE_ADDR 0x1a0000 @@ -27,6 +30,11 @@ #define PURGEABLE_TEST_PATTERN 0xc0ffee #define PURGEABLE_DEAD_PATTERN 0xdead +/* Atomic test constants */ +#define USER_FENCE_VALUE 0xdeadbeefdeadbeefull +#define FIVE_SEC (5LL * NSEC_PER_SEC) +#define QUARTER_SEC (NSEC_PER_SEC / 4) + static bool xe_has_purgeable_support(int fd) { struct drm_xe_query_config *config = xe_config(fd); @@ -768,6 +776,108 @@ out: igt_skip("Unable to induce purge on this platform/config"); } +/* + * Atomic madvise subtests — validate DRM_XE_MEM_RANGE_ATTR_ATOMIC + * modes (DEVICE, GLOBAL, CPU) on fault-mode SVM VMAs. + */ + +struct atomic_data { + uint32_t batch[32]; + uint64_t vm_sync; + uint64_t exec_sync; + uint32_t data; +}; + +static void atomic_build_batch(struct atomic_data *d, uint64_t gpu_addr) +{ + uint64_t data_offset = (char *)&d->data - (char *)d; + uint64_t sdi_addr = gpu_addr + data_offset; + int b = 0; + + d->batch[b++] = MI_ATOMIC | MI_ATOMIC_INC; + d->batch[b++] = sdi_addr; + d->batch[b++] = sdi_addr >> 32; + d->batch[b++] = MI_BATCH_BUFFER_END; + igt_assert(b <= ARRAY_SIZE(d->batch)); +} + +/** + * SUBTEST: atomic-device + * Description: madvise atomic device supports only GPU atomic operations, + * test executes GPU MI_ATOMIC_INC on SVM memory via fault handler + * Test category: functionality test + */ +static void test_atomic_device(int fd, struct drm_xe_engine_class_instance *eci) +{ + struct drm_xe_sync sync[1] = { + { .type = DRM_XE_SYNC_TYPE_USER_FENCE, + .flags = DRM_XE_SYNC_FLAG_SIGNAL, + .timeline_value = USER_FENCE_VALUE }, + }; + struct drm_xe_exec exec = { + .num_batch_buffer = 1, + .num_syncs = 1, + .syncs = to_user_pointer(sync), + }; + struct atomic_data *data; + uint32_t vm, exec_queue; + uint64_t addr; + size_t bo_size; + int va_bits; + int pf_count_before, pf_count_after; + + va_bits = xe_va_bits(fd); + vm = xe_vm_create(fd, DRM_XE_VM_CREATE_FLAG_LR_MODE | + DRM_XE_VM_CREATE_FLAG_FAULT_MODE, 0); + + bo_size = xe_bb_size(fd, sizeof(*data)); + data = aligned_alloc(bo_size, bo_size); + igt_assert(data); + memset(data, 0, bo_size); + + addr = to_user_pointer(data); + + /* Bind entire VA space as CPU_ADDR_MIRROR */ + sync[0].addr = to_user_pointer(&data->vm_sync); + __xe_vm_bind_assert(fd, vm, 0, 0, 0, 0, 0x1ull << va_bits, + DRM_XE_VM_BIND_OP_MAP, + DRM_XE_VM_BIND_FLAG_CPU_ADDR_MIRROR, + sync, 1, 0, 0); + xe_wait_ufence(fd, &data->vm_sync, USER_FENCE_VALUE, 0, FIVE_SEC); + data->vm_sync = 0; + + xe_vm_madvise(fd, vm, addr, bo_size, 0, + DRM_XE_MEM_RANGE_ATTR_ATOMIC, DRM_XE_ATOMIC_DEVICE, 0, 0); + + atomic_build_batch(data, addr); + + exec_queue = xe_exec_queue_create(fd, vm, eci, 0); + exec.exec_queue_id = exec_queue; + exec.address = addr + ((char *)&data->batch - (char *)data); + + pf_count_before = xe_gt_stats_get_count(fd, eci->gt_id, + "svm_pagefault_count"); + + sync[0].addr = to_user_pointer(&data->exec_sync); + xe_exec(fd, &exec); + xe_wait_ufence(fd, &data->exec_sync, USER_FENCE_VALUE, + exec_queue, FIVE_SEC); + + pf_count_after = xe_gt_stats_get_count(fd, eci->gt_id, + "svm_pagefault_count"); + if (pf_count_before != pf_count_after) + igt_info("Pagefault count: before=%d, after=%d\n", + pf_count_before, pf_count_after); + + igt_assert_eq(data->data, 1); + + xe_exec_queue_destroy(fd, exec_queue); + __xe_vm_bind_assert(fd, vm, 0, 0, 0, 0, 0x1ull << va_bits, + DRM_XE_VM_BIND_OP_UNMAP, 0, NULL, 0, 0, 0); + free(data); + xe_vm_destroy(fd, vm); +} + int igt_main() { struct drm_xe_engine_class_instance *hwe; @@ -826,6 +936,17 @@ int igt_main() } } + igt_subtest_group() { + igt_fixture() { + igt_require(xe_has_vram(fd)); + igt_require(!xe_supports_faults(fd)); + } + + igt_subtest("atomic-device") + xe_for_each_engine(fd, hwe) + test_atomic_device(fd, hwe); + } + igt_fixture() { xe_device_put(fd); drm_close_driver(fd); -- 2.43.0