From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39AB8CD37BE for ; Mon, 11 May 2026 17:21:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E473210E1DF; Mon, 11 May 2026 17:21:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="FKAKt+VT"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id C9BB310E85D for ; Mon, 11 May 2026 17:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778520009; x=1810056009; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ajZ9PVPFN4ROhwOaNFQQhEF9UrpYAM5zUIzdkLPUL/k=; b=FKAKt+VTWld5ztWq18Fy5BteN8T4mglAy6KrBwGfemxln00ZZPfbNr3R NPLf9ABXU9V0kLoUQ4ljaeJD/g4WppJbCvsSgAILVV83JJrSRShjDObf2 mwQTHhwmJeE0EczTj950FaZWNhUr7YV8Qd66JMLVh5f7npu5ZDgEUhTnH Io8OA9iGE/53XDSIupb3zjOIOp+qxx3DV2fqNV/T1X2PU6dJB/3lFPX7s rk3KmykebSuAJw7WTiFZKg5w0/MBMRcN4Mt2celNGI069mBHd07aMvZ1/ 3aK5+L/iOFLOrqA/7aVuaeQwXCydn3Y9oD7O1sPvkh4ce8YaIh30u0Ckf A==; X-CSE-ConnectionGUID: CdSeIG8QRtOXUP/8Wp3hgw== X-CSE-MsgGUID: NfgmnmSpR1KY++nZ9d/hbQ== X-IronPort-AV: E=McAfee;i="6800,10657,11783"; a="81979829" X-IronPort-AV: E=Sophos;i="6.23,229,1770624000"; d="scan'208";a="81979829" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2026 10:20:09 -0700 X-CSE-ConnectionGUID: 3qHS6JT6TUuTzQ3jgUK4nA== X-CSE-MsgGUID: ySB+ySUaTo+6zw+jGjaMOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,229,1770624000"; d="scan'208";a="233192547" Received: from jeevan-x299-aorus-gaming-3-pro.iind.intel.com ([10.227.90.91]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2026 10:20:07 -0700 From: Jeevan B To: igt-dev@lists.freedesktop.org Cc: animesh.manna@intel.com, dibin.moolakadan.subrahmanian@intel.com, mohammed.thasleem@intel.com, ramanaidu.naladala@intel.com, Jeevan B Subject: [PATCH i-g-t v4 2/7] tests/intel/kms_pm_dc: Replace require with proper assertion Date: Mon, 11 May 2026 22:48:15 +0530 Message-ID: <20260511171820.461666-3-jeevan.b@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260511171820.461666-1-jeevan.b@intel.com> References: <20260511171820.461666-1-jeevan.b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" The DC3CO video playback simulation test was incorrectly using require at the end to check if DC3CO state was entered. This causes the test to be marked as SKIP instead of FAIL when DC3CO doesn't work properly, hiding real issues. So changing the call from require to assert. Fixes: b89efa8048e58 ("tests/i915/i915_pm_dc: Check dc3co count to skip the test") Signed-off-by: Jeevan B Reviewed-by: Mohammed Thasleem --- tests/intel/kms_pm_dc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c index c8cfa300c..27fa5dc39 100644 --- a/tests/intel/kms_pm_dc.c +++ b/tests/intel/kms_pm_dc.c @@ -316,8 +316,7 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data) usleep(delay); } - igt_require_f(igt_dc_state_wait_entry(data->debugfs_fd, IGT_INTEL_CHECK_DC3CO, - dc3co_prev_cnt), "dc3co-vpb-simulation not enabled\n"); + assert_dc_counter(data, IGT_INTEL_CHECK_DC3CO, dc3co_prev_cnt); } static void setup_dc3co(data_t *data) -- 2.43.0