From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97DDECD37B6 for ; Wed, 13 May 2026 06:19:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4784610E2E8; Wed, 13 May 2026 06:19:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="fRWpxzT4"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5CE2E10EC91 for ; Wed, 13 May 2026 06:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778653071; x=1810189071; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ajZ9PVPFN4ROhwOaNFQQhEF9UrpYAM5zUIzdkLPUL/k=; b=fRWpxzT4d7ZoHBfXpfj+zgLn6eZE2ygR/qm5pnwok1oZKp45vRacH6gC T+7UdSb4OKY4yVdVVaZJJSlSsnnaIYhmvuN9SfsvySw7/ZaxOwB5lSZX3 2Sy1mBJRmmvi4Runq1FoX62Fq3Ob7dAHLA/hi5+1EYpRA5lmEUyWmrWXS xjB642CVQqeGgVj157pij4xMdg+h70RjXiVhmszQg+5WQAi+JMGHiR1W2 g1G59vAbz84GySTPMAT4WWHtkgoIp9gD+DpblH8aYJOTT3ErLMEYkrEA/ DrM83s2LSJN3ue2HyIZmjxFgHzcBwLpvr9WBffWz/qFw3+GEX7x9sp6Tx A==; X-CSE-ConnectionGUID: UkgZtOx0QZWta64r3U9J0A== X-CSE-MsgGUID: BLOH5g7fTIKgfn7QHd09KA== X-IronPort-AV: E=McAfee;i="6800,10657,11784"; a="79685130" X-IronPort-AV: E=Sophos;i="6.23,232,1770624000"; d="scan'208";a="79685130" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2026 23:17:51 -0700 X-CSE-ConnectionGUID: H9M7vdKTQWuJvHos486YhQ== X-CSE-MsgGUID: bEVAr2eRRzuREru3+eB/Iw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,232,1770624000"; d="scan'208";a="235320956" Received: from jeevan-x299-aorus-gaming-3-pro.iind.intel.com ([10.227.90.91]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2026 23:17:49 -0700 From: Jeevan B To: igt-dev@lists.freedesktop.org Cc: animesh.manna@intel.com, dibin.moolakadan.subrahmanian@intel.com, mohammed.thasleem@intel.com, ramanaidu.naladala@intel.com, Jeevan B Subject: [PATCH i-g-t v5 2/7] tests/intel/kms_pm_dc: Replace require with proper assertion Date: Wed, 13 May 2026 11:46:00 +0530 Message-ID: <20260513061605.645695-3-jeevan.b@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260513061605.645695-1-jeevan.b@intel.com> References: <20260513061605.645695-1-jeevan.b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" The DC3CO video playback simulation test was incorrectly using require at the end to check if DC3CO state was entered. This causes the test to be marked as SKIP instead of FAIL when DC3CO doesn't work properly, hiding real issues. So changing the call from require to assert. Fixes: b89efa8048e58 ("tests/i915/i915_pm_dc: Check dc3co count to skip the test") Signed-off-by: Jeevan B Reviewed-by: Mohammed Thasleem --- tests/intel/kms_pm_dc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c index c8cfa300c..27fa5dc39 100644 --- a/tests/intel/kms_pm_dc.c +++ b/tests/intel/kms_pm_dc.c @@ -316,8 +316,7 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data) usleep(delay); } - igt_require_f(igt_dc_state_wait_entry(data->debugfs_fd, IGT_INTEL_CHECK_DC3CO, - dc3co_prev_cnt), "dc3co-vpb-simulation not enabled\n"); + assert_dc_counter(data, IGT_INTEL_CHECK_DC3CO, dc3co_prev_cnt); } static void setup_dc3co(data_t *data) -- 2.43.0