From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D99ACD37B6 for ; Wed, 13 May 2026 06:25:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6C75E8953E; Wed, 13 May 2026 06:25:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="UdHRQiwq"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0BA428953E for ; Wed, 13 May 2026 06:25:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778653531; x=1810189531; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=AJ9/Tk8J1w0d++f7LNNRtoImPB4ZEwRiRoVs5BgVKuk=; b=UdHRQiwqQfjsZHSXwBA6PjKNVbWZg4lWFNDHnAVi+aNFi9Dg1NDgxK2W 4eI/8MTMXdvF1vc6ezKvJ5fupQm2o3XFxaeGxc0IZ71YtpOFYytNERgUg 2uzv3L9VAFNAQtLMuDqUydMgrze3Xpl01saaBnH5N8440I8UKKTd61DIC d7T3aL+sxh97ODuDjKcuk7asgRQI5DM5FFvAP3Ge+wznmDCONBF9/Iu6r mCMui4d7OSyYwn1//Z8ukPYJWzOmA3qtJ6rh6YA0MJm7ppPfCnP6Lgm+F u9I8FWSl2I3UuYSExYSQP5H7DIMyeh8TbvscRjDADETFYFYnUAedAQXKw Q==; X-CSE-ConnectionGUID: J43NQqnMRNago/ApifZHFQ== X-CSE-MsgGUID: hx6KHEuxQQW332JS6YPMGA== X-IronPort-AV: E=McAfee;i="6800,10657,11784"; a="97139390" X-IronPort-AV: E=Sophos;i="6.23,232,1770624000"; d="scan'208";a="97139390" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2026 23:25:31 -0700 X-CSE-ConnectionGUID: BXzpWW6ZR3mQIZbdyl3rfA== X-CSE-MsgGUID: ykGzC0sISAGamZJdwVE8AQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,232,1770624000"; d="scan'208";a="238087020" Received: from shawnle1-i9-build-machine.itwn.intel.com ([10.225.64.200]) by orviesa009.jf.intel.com with ESMTP; 12 May 2026 23:25:30 -0700 From: Lee Shawn C To: igt-dev@lists.freedesktop.org Cc: Lee Shawn C , Naladala Ramanaidu Subject: [v5] tests/kms_vrr: add support for full range refresh rate testing Date: Wed, 13 May 2026 06:16:57 +0000 Message-Id: <20260513061657.980046-1-shawn.c.lee@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260427120955.3537070-1-shawn.c.lee@intel.com> References: <20260427120955.3537070-1-shawn.c.lee@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" Currently, kms_vrr tests fixed step increments within the VRR range. To better validate hardware stability and potential issues across the entire spectrum, this patch adds a 'full-range' testing mode. When the full-range flag is enabled, the test will: 1. Iterate from the maximum to the minimum refresh rate (stepping by 1). 2. For standard testing, maintain the existing behavior of incrementing from minimum to maximum using the defined step size. v2: Fix build failure by adding documentation for the new subtest. v3: Remove unnecessary '!!' operator when assigning to bool. v4: Add full-range (top-down/bottom-up) subtests to verify all supported RR within VRR range. v5: Fix build failure for the new subtest. Cc: Naladala Ramanaidu Signed-off-by: Lee Shawn C --- tests/kms_vrr.c | 118 ++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 100 insertions(+), 18 deletions(-) diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c index 6043d40f1d74..bf2fab9ce23f 100644 --- a/tests/kms_vrr.c +++ b/tests/kms_vrr.c @@ -65,6 +65,11 @@ * SUBTEST: seamless-rr-switch-virtual * Description: Test to create a Virtual Mode in VRR range and switch to it * without a full modeset. + * SUBTEST: seamless-rr-switch-virtual-top-down + * Description: Vrr seamless refresh rate switch for virtual modes using full range + * + * SUBTEST: seamless-rr-switch-virtual-bottom-up + * Description: Vrr seamless refresh rate switch for virtual modes using full range * * SUBTEST: lobf * Description: Test to validate link-off between active frames in non-psr @@ -94,11 +99,13 @@ enum { TEST_SEAMLESS_VRR = 1 << 4, TEST_SEAMLESS_DRRS = 1 << 5, TEST_SEAMLESS_VIRTUAL_RR = 1 << 6, - TEST_FASTSET = 1 << 7, - TEST_MAXMIN = 1 << 8, - TEST_LINK_OFF = 1 << 10, - TEST_NEGATIVE = 1 << 11, - TEST_FORCE_RR = 1 << 12, + TEST_SEAMLESS_VIRTUAL_RR_TOP_DOWN = 1 << 7, + TEST_SEAMLESS_VIRTUAL_RR_BOTTOM_UP = 1 << 8, + TEST_FASTSET = 1 << 9, + TEST_MAXMIN = 1 << 10, + TEST_LINK_OFF = 1 << 11, + TEST_NEGATIVE = 1 << 12, + TEST_FORCE_RR = 1 << 13, }; enum { @@ -235,13 +242,58 @@ low_rr_mode_with_same_res(igt_output_t *output, unsigned int vrr_min) return mode; } -static void -virtual_rr_vrr_range_mode(drmModeModeInfo *mode, float virtual_refresh_rate) +static bool +virtual_rr_vrr_range_mode(data_t *data, drmModeModeInfo *mode, float virtual_refresh_rate) { uint64_t clock_hz = mode->clock * 1000; + uint16_t virtual_vtotal; + + virtual_vtotal = clock_hz / (mode->htotal * virtual_refresh_rate); + if (is_intel_device(data->drm_fd) && virtual_vtotal > 8192) { + igt_info("VTotal (%d) already exceed 8192 at %fHz\n", virtual_vtotal, virtual_refresh_rate); + return false; + } - mode->vtotal = clock_hz / (mode->htotal * virtual_refresh_rate); + mode->vsync_start = virtual_vtotal - (mode->vtotal - mode->vsync_start); + mode->vsync_end = virtual_vtotal - (mode->vtotal - mode->vsync_end); + mode->vtotal = virtual_vtotal; mode->vrefresh = virtual_refresh_rate; + + return true; +} + +static drmModeModeInfo* +get_selected_fixed_mode(igt_output_t *output, bool lowest) +{ + drmModeConnectorPtr connector = output->config.connector; + drmModeModeInfo *selected_mode = NULL; + + for (int i = 0; i < connector->count_modes; i++) { + drmModeModeInfo *m = &connector->modes[i]; + + if (m->type & (DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER)) { + if (!selected_mode) { + selected_mode = m; + continue; + } + + if (lowest) { + if (m->vrefresh < selected_mode->vrefresh) + selected_mode = m; + } else { + if (m->vrefresh > selected_mode->vrefresh) + selected_mode = m; + } + } + } + + if (selected_mode) { + igt_info("Found Target Fixed Mode: \"%s\" %dHz (vtotal: %d)\n", + selected_mode->name, selected_mode->vrefresh, selected_mode->vtotal); + return selected_mode; + } + + return NULL; } /* Read min and max vrr range from the connector debugfs. */ @@ -757,19 +809,25 @@ test_seamless_virtual_rr_basic(data_t *data, igt_crtc_t *crtc, unsigned int vrefresh; uint64_t rate[] = {0}; uint32_t step_size; - drmModeModeInfo virtual_mode; + drmModeModeInfo *virtual_mode = NULL; + int start, end, step; + bool need_low_rr = flags & TEST_SEAMLESS_VIRTUAL_RR_BOTTOM_UP; - igt_info("Use HIGH_RR Mode as default\n"); - kmstest_dump_mode(&data->switch_modes[HIGH_RR_MODE]); + virtual_mode = get_selected_fixed_mode(output, need_low_rr); + if (!virtual_mode) + return; + + igt_info("Use %s_RR Mode as default\n", need_low_rr ? "LOW" : "HIGH"); + kmstest_dump_mode(virtual_mode); prepare_test(data, output, crtc); - rate[0] = igt_kms_frame_time_from_vrefresh(data->switch_modes[HIGH_RR_MODE].vrefresh); + rate[0] = igt_kms_frame_time_from_vrefresh(virtual_mode->vrefresh); /* * Sink with DRR and VRR can be in downclock mode so * switch to highest refresh rate mode. */ - igt_output_override_mode(output, &data->switch_modes[HIGH_RR_MODE]); + igt_output_override_mode(output, virtual_mode); igt_assert(igt_display_try_commit_atomic(&data->display, DRM_MODE_PAGE_FLIP_EVENT, NULL) == 0); result = flip_and_measure(data, output, rate, 1, TEST_DURATION_NS); @@ -784,7 +842,7 @@ test_seamless_virtual_rr_basic(data_t *data, igt_crtc_t *crtc, step_size = (data->range.max - data->range.min) / 5; /* Switch to Virtual RR */ - virtual_mode = *igt_output_get_mode(output); + virtual_mode = igt_output_get_mode(output); /* * Start virtual RR testing from above the midpoint of the VRR range when multiple @@ -795,13 +853,29 @@ test_seamless_virtual_rr_basic(data_t *data, igt_crtc_t *crtc, (((data->range.max + data->range.min) / 2) + step_size) : data->range.min + step_size; - for ( ; vrefresh < data->range.max; vrefresh += step_size) { - virtual_rr_vrr_range_mode(&virtual_mode, vrefresh); + if (flags & TEST_SEAMLESS_VIRTUAL_RR_TOP_DOWN) { + start = data->range.max; + end = data->range.min; + step = -1; + } else if (flags & TEST_SEAMLESS_VIRTUAL_RR_BOTTOM_UP) { + start = data->range.min; + end = data->range.max; + step = 1; + } else { + start = data->range.min; + end = data->range.max; + step = step_size; + } + + for (vrefresh = start; (step > 0) ? (vrefresh <= end) : (vrefresh >= end); vrefresh += step) { + if (!virtual_rr_vrr_range_mode(data, virtual_mode, vrefresh)) + continue; igt_info("Requesting Virtual Mode with Refresh Rate (%u Hz): \n", vrefresh); - kmstest_dump_mode(&virtual_mode); + kmstest_dump_mode(virtual_mode); - igt_output_override_mode(output, &virtual_mode); + igt_output_override_mode(output, virtual_mode); + igt_assert(igt_display_try_commit_atomic(&data->display, DRM_MODE_ATOMIC_TEST_ONLY, NULL) == 0); igt_assert(igt_display_try_commit_atomic(&data->display, 0, NULL) == 0); rate[0] = igt_kms_frame_time_from_vrefresh(vrefresh); @@ -1105,6 +1179,14 @@ int igt_main_args("drs:", long_opts, help_str, opt_handler, &data) igt_subtest_with_dynamic("seamless-rr-switch-virtual") run_vrr_test(&data, test_seamless_virtual_rr_basic, TEST_SEAMLESS_VIRTUAL_RR); + igt_describe("Test to switch to all virtual modes in VRR range without modeset."); + igt_subtest_with_dynamic("seamless-rr-switch-virtual-top-down") + run_vrr_test(&data, test_seamless_virtual_rr_basic, TEST_SEAMLESS_VIRTUAL_RR_TOP_DOWN); + + igt_describe("Test to switch to all virtual modes in VRR range without modeset."); + igt_subtest_with_dynamic("seamless-rr-switch-virtual-bottom-up") + run_vrr_test(&data, test_seamless_virtual_rr_basic, TEST_SEAMLESS_VIRTUAL_RR_BOTTOM_UP); + igt_describe("Test to validate the link-off between active frames in " "non-PSR operation."); igt_subtest_with_dynamic("lobf") { -- 2.34.1