From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E49DCD4F25 for ; Fri, 15 May 2026 15:34:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2110010F56A; Fri, 15 May 2026 15:34:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="fD8SNzVt"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9772310F56A for ; Fri, 15 May 2026 15:33:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778859225; x=1810395225; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ajZ9PVPFN4ROhwOaNFQQhEF9UrpYAM5zUIzdkLPUL/k=; b=fD8SNzVtssGtteuXgtkUYoc9ouacfCxeBvHHk+2IyrjbmnHKlXJsIxDl N6qJ6Ime2//Ofl/BOZvElNxxInAscxK4jE1DGNTLcLsJohuMpBzOenpib 7mwkIsfFg+d2rVZBHs/iwLq0Tojvq84FtzyNjXw77ekJ9nZV2rxUfGo8r SKaJRIx9D0zpXtkbNsAnso+i16aQy/wtfttitjC6Yu6gqAYkcaoximhMr fxda1K5z6xwTE33lfEqrsxT3vbUUamu5ec89jdWGw7s3ypQE4bIp1ON6g YT9C8XSjGjn83j6S8gbImgottbIn65EUydT5Sq7+I5zMoNJ5TfRMLDySU Q==; X-CSE-ConnectionGUID: qFmPl3lGTY2XmM/FuAnBOw== X-CSE-MsgGUID: 67x4UM3pQhCYInvYqV5XQA== X-IronPort-AV: E=McAfee;i="6800,10657,11787"; a="79671725" X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="79671725" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 08:33:45 -0700 X-CSE-ConnectionGUID: 0+FzaDI1R3qjk9HWQXO5Bg== X-CSE-MsgGUID: M/J+bmQCTAKqaNJAn3+tLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="235678012" Received: from jeevan-x299-aorus-gaming-3-pro.iind.intel.com ([10.227.90.91]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 08:33:43 -0700 From: Jeevan B To: igt-dev@lists.freedesktop.org Cc: animesh.manna@intel.com, dibin.moolakadan.subrahmanian@intel.com, mohammed.thasleem@intel.com, ramanaidu.naladala@intel.com, Jeevan B Subject: [PATCH i-g-t v6 2/7] tests/intel/kms_pm_dc: Replace require with proper assertion Date: Fri, 15 May 2026 21:01:54 +0530 Message-ID: <20260515153159.838667-3-jeevan.b@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515153159.838667-1-jeevan.b@intel.com> References: <20260515153159.838667-1-jeevan.b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" The DC3CO video playback simulation test was incorrectly using require at the end to check if DC3CO state was entered. This causes the test to be marked as SKIP instead of FAIL when DC3CO doesn't work properly, hiding real issues. So changing the call from require to assert. Fixes: b89efa8048e58 ("tests/i915/i915_pm_dc: Check dc3co count to skip the test") Signed-off-by: Jeevan B Reviewed-by: Mohammed Thasleem --- tests/intel/kms_pm_dc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c index c8cfa300c..27fa5dc39 100644 --- a/tests/intel/kms_pm_dc.c +++ b/tests/intel/kms_pm_dc.c @@ -316,8 +316,7 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data) usleep(delay); } - igt_require_f(igt_dc_state_wait_entry(data->debugfs_fd, IGT_INTEL_CHECK_DC3CO, - dc3co_prev_cnt), "dc3co-vpb-simulation not enabled\n"); + assert_dc_counter(data, IGT_INTEL_CHECK_DC3CO, dc3co_prev_cnt); } static void setup_dc3co(data_t *data) -- 2.43.0