From: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: adam.miszczak@linux.intel.com, jakub1.kolakowski@intel.com,
lukasz.laguna@intel.com,
Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Subject: [PATCH i-g-t 7/8] tests/intel/xe_sriov_scheduling: Remove unused log_sample_values helper
Date: Wed, 27 May 2026 22:56:40 +0200 [thread overview]
Message-ID: <20260527205644.2801165-8-marcin.bernatowicz@linux.intel.com> (raw)
In-Reply-To: <20260527205644.2801165-1-marcin.bernatowicz@linux.intel.com>
Drop the unused sample logging helper after the throughput verification
path stopped relying on the detailed mismatch dump.
Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Cc: Adam Miszczak <adam.miszczak@linux.intel.com>
Cc: Jakub Kolakowski <jakub1.kolakowski@intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
---
tests/intel/xe_sriov_scheduling.c | 47 -------------------------------
1 file changed, 47 deletions(-)
diff --git a/tests/intel/xe_sriov_scheduling.c b/tests/intel/xe_sriov_scheduling.c
index 692f92e76..915442380 100644
--- a/tests/intel/xe_sriov_scheduling.c
+++ b/tests/intel/xe_sriov_scheduling.c
@@ -472,53 +472,6 @@ static void compute_common_time_frame_stats(struct subm_set *set)
}
}
-static void log_sample_values(char *id, struct subm_stats *stats,
- double comparison_mean, double outlier_treshold)
-{
- const uint64_t *values = stats->samples.values_u64;
- unsigned int n = stats->samples.n_values;
- char buffer[2048];
- char *p = buffer, *pend = buffer + sizeof(buffer);
- unsigned int i;
- const unsigned int edge_items = 3;
- bool is_outlier;
- double tolerance = outlier_treshold * comparison_mean;
-
- p += snprintf(p, pend - p,
- "[%s] start=%f end=%f nsamples=%u comparison_mean=%.2fms\n",
- id, stats->start_timestamp * 1e-9, stats->end_timestamp * 1e-9, n,
- comparison_mean * 1e-6);
-
- for (i = 0; i < n && p < pend; ++i) {
- is_outlier = fabs(values[i] - comparison_mean) > tolerance;
-
- if (n <= 2 * edge_items || i < edge_items ||
- i >= n - edge_items || is_outlier) {
- if (is_outlier) {
- double pct_diff =
- 100 *
- (comparison_mean ?
- (values[i] - comparison_mean) /
- comparison_mean :
- 1.0);
-
- p += snprintf(p, pend - p,
- "%0.2f @%d Pct Diff %0.2f%%\n",
- values[i] * 1e-6, i,
- pct_diff);
- } else {
- p += snprintf(p, pend - p, "%0.2f\n",
- values[i] * 1e-6);
- }
- }
-
- if (i == edge_items && n > 2 * edge_items)
- p += snprintf(p, pend - p, "...\n");
- }
-
- igt_debug("%s\n", buffer);
-}
-
#define MIN_NUM_REPEATS 25
#define MIN_EXEC_QUANTUM_MS 2
#define MAX_EXEC_QUANTUM_MS 32
--
2.43.0
next prev parent reply other threads:[~2026-05-27 20:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 20:56 [PATCH i-g-t 0/8] tests/intel/xe_sriov_scheduling: improve scheduling coverage Marcin Bernatowicz
2026-05-27 20:56 ` [PATCH i-g-t 1/8] tests/intel/xe_sriov_scheduling: Use timestamp helper Marcin Bernatowicz
2026-05-28 10:43 ` Kamil Konieczny
2026-05-27 20:56 ` [PATCH i-g-t 2/8] tests/intel/xe_sriov_scheduling: Add scheduling priority support Marcin Bernatowicz
2026-05-27 20:56 ` [PATCH i-g-t 3/8] tests/intel/xe_sriov_scheduling: Make sysfs_get_job_timeout_ms take const eci Marcin Bernatowicz
2026-05-27 20:56 ` [PATCH i-g-t 4/8] tests/intel/xe_sriov_scheduling: Add PMU-based verification helpers Marcin Bernatowicz
2026-05-27 20:56 ` [PATCH i-g-t 5/8] tests/intel/xe_sriov_scheduling: Raise min exec quantum to 2ms Marcin Bernatowicz
2026-05-27 20:56 ` [PATCH i-g-t 6/8] tests/intel/xe_sriov_scheduling: Refactor throughput_ratio and nonpreempt-engine-resets test Marcin Bernatowicz
2026-05-27 20:56 ` Marcin Bernatowicz [this message]
2026-05-27 20:56 ` [PATCH i-g-t 8/8] tests/intel/xe_sriov_scheduling: Add default fair scheduling test Marcin Bernatowicz
2026-05-28 0:01 ` ✓ Xe.CI.BAT: success for tests/intel/xe_sriov_scheduling: improve scheduling coverage Patchwork
2026-05-28 0:04 ` ✗ i915.CI.BAT: failure " Patchwork
2026-05-28 12:15 ` ✓ Xe.CI.FULL: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527205644.2801165-8-marcin.bernatowicz@linux.intel.com \
--to=marcin.bernatowicz@linux.intel.com \
--cc=adam.miszczak@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jakub1.kolakowski@intel.com \
--cc=lukasz.laguna@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox