From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1D96CD5BD1 for ; Tue, 2 Jun 2026 21:17:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ADBF610E6A0; Tue, 2 Jun 2026 21:17:09 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="J2XxYyx3"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id 51F0B10E683 for ; Tue, 2 Jun 2026 21:15:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=W2ZHEFKSkJ/pwUtVsbBMeU1kwX+XKq0AZjc2F8hM2JQ=; b=J2XxYyx3rQa15INh/dEKKhksSy 8Y4+KP/m161Ss19Ca5xjlQhwLVaR9IDqbqVmk1bmLJI6APOU2FtmA1Rc1R8BFxWdMeHvboDTkHCzR 2oyaPvLwk0Ww3RcUGC3QPXsuUbbcOxVE9wmYgQTtedBqe+KuirsiicnB1qy0n2VN1Bitf0r7237Nv lr5d6Jd+1BjBz7dmtDPfqaipmUrkviclase2isyglH1DujTyGSlVI60YO+p6WtNGrJw+jmp+mgxKC WFX1j0x7OauMP0r0PZTtvRCZvjnHRsV0CToNi4PbvtytTT+aSikgrVgso6xEGIq9/4WZ1Ze1hTtGj Ud6ZDpHg==; Received: from [79.117.146.159] (helo=killbill.home) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wUWS3-00BtIm-Tv; Tue, 02 Jun 2026 23:15:08 +0200 From: Melissa Wen To: Petri Latvala , Arkadiusz Hiler , Kamil Konieczny , Juha-Pekka Heikkila , Bhanuprakash Modem , Ashutosh Dixit , Karthik B S Cc: igt-dev@lists.freedesktop.org, kernel-dev@igalia.com, Chaitanya Kumar Borah , Alex Hung , Swati Sharma , John Harrison , Rodrigo Siqueira , Simon Ser , Xaver Hugl , Harry Wentland , Uma Shankar Subject: [PATCH i-g-t v2 0/4] test/kms_colorop_helper: don't request colorop updates indefinitely Date: Tue, 2 Jun 2026 23:06:41 +0200 Message-ID: <20260602211259.898147-1-mwen@igalia.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" After committing colorop settings, colorops are still flagged as changed, even if there is no new request for updates. The first patch clear colorop flag after commit so that the next patch doesn't try to re-submit changes on inactive color pipeline. The second patch prevents colorop to be marked as changed just because it was checking if a property enum value is supported. These changes are consistent with the current expecation of allowing property changes in colorop that are part of a current active color pipeline or a color pipeline that will be activated or deactived in the same atomic commit; but rejecting attempts to change inactive colorops. There are two new patches: patch 3 fixes kms_properties to match colorop update requirements of an active plane color pipeline. Patch 4 just ensure that kms_color_pipeline expects an intel device and will not run otherwise. As color validation works better with writeback then CRC, other devices should prefer kms_colorop if they have writeback support. If not, they should work on adapting kms_color_pipeline according to their specs. Lemme know your thought! Melissa Melissa Wen (4): lib/igt_kms: clear colorop-changed flag after commit test/kms_colorop_helper: only check if a given enum value exist tests/kms_properties: check colorop properties on active color pipelines tests/kms_color_pipeline: skip if not an intel device lib/igt_kms.c | 41 ++++++++++++++++++++++++++++++++++++++ lib/igt_kms.h | 4 ++++ tests/kms_color_pipeline.c | 1 + tests/kms_colorop_helper.c | 4 +++- tests/kms_properties.c | 26 ++++++++++++++++++++++-- 5 files changed, 73 insertions(+), 3 deletions(-) -- 2.53.0