[PATCH i-g-t v5 1/2] tests/kms_color: Prepare FB creation for explicit YUV color range handling

[Pranay Samala <pranay.samala@intel.com>]

Switch framebuffer creation from igt_create_fb() to a common path that can
use igt_create_fb_with_bo_size() when explicit YCbCr encoding/range is needed.

YUV formats may otherwise be interpreted with implicit limited-range defaults
(16-235) instead of full range (0-255), which can make color expectations
non-deterministic in YUV coverage.

This is a preparatory cleanup and does not fix a user-visible bug.
It refactors FB creation so YUV paths can carry explicit YCbCr parameters,
while RGB paths continue using the default framebuffer creation behavior.

v3:
- Update commit message (Swati)

v4:
- Split the patches (Swati)

v5:
- Add a common FB helper to centralize framebuffer creation (Swati)
- Keep RGB formats on the existing igt_create_fb() path (Swati)
- Use explicit range/encoding only for YUV formats (Swati)
- Update commit message (Swati)

Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
 tests/kms_color.c | 94 +++++++++++++++++------------------------------
 1 file changed, 34 insertions(+), 60 deletions(-)

diff --git a/tests/kms_color.c b/tests/kms_color.c
index 565edb2dc..f4b792fdd 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -78,6 +78,20 @@
 
 IGT_TEST_DESCRIPTION("Test Color Features at Pipe level");
 
+static unsigned int create_color_test_fb(data_t *data, int w, int h,
+					 uint32_t format, struct igt_fb *fb)
+{
+	if (igt_format_is_yuv(format))
+		return igt_create_fb_with_bo_size(data->drm_fd, w, h, format,
+						  DRM_FORMAT_MOD_LINEAR,
+						  IGT_COLOR_YCBCR_BT709,
+						  IGT_COLOR_YCBCR_FULL_RANGE,
+						  fb, 0, 0);
+
+	return igt_create_fb(data->drm_fd, w, h, format,
+			     DRM_FORMAT_MOD_LINEAR, fb);
+}
+
 static bool test_pipe_degamma(data_t *data,
 			      igt_plane_t *primary)
 {
@@ -104,20 +118,12 @@ static bool test_pipe_degamma(data_t *data,
 	igt_output_override_mode(output, mode);
 
 	/* Create a framebuffer at the size of the output. */
-	fb_id = igt_create_fb(data->drm_fd,
-			      mode->hdisplay,
-			      mode->vdisplay,
-			      data->drm_format,
-			      DRM_FORMAT_MOD_LINEAR,
-			      &fb);
+	fb_id = create_color_test_fb(data, mode->hdisplay, mode->vdisplay,
+				     data->drm_format, &fb);
 	igt_assert(fb_id);
 
-	fb_modeset_id = igt_create_fb(data->drm_fd,
-				      mode->hdisplay,
-				      mode->vdisplay,
-				      data->drm_format,
-				      DRM_FORMAT_MOD_LINEAR,
-				      &fb_modeset);
+	fb_modeset_id = create_color_test_fb(data, mode->hdisplay, mode->vdisplay,
+					     data->drm_format, &fb_modeset);
 	igt_assert(fb_modeset_id);
 
 	igt_plane_set_fb(primary, &fb_modeset);
@@ -191,20 +197,12 @@ static bool test_pipe_gamma(data_t *data,
 	igt_output_override_mode(output, mode);
 
 	/* Create a framebuffer at the size of the output. */
-	fb_id = igt_create_fb(data->drm_fd,
-			      mode->hdisplay,
-			      mode->vdisplay,
-			      data->drm_format,
-			      DRM_FORMAT_MOD_LINEAR,
-			      &fb);
+	fb_id = create_color_test_fb(data, mode->hdisplay, mode->vdisplay,
+				     data->drm_format, &fb);
 	igt_assert(fb_id);
 
-	fb_modeset_id = igt_create_fb(data->drm_fd,
-				      mode->hdisplay,
-				      mode->vdisplay,
-				      data->drm_format,
-				      DRM_FORMAT_MOD_LINEAR,
-				      &fb_modeset);
+	fb_modeset_id = create_color_test_fb(data, mode->hdisplay, mode->vdisplay,
+					     data->drm_format, &fb_modeset);
 	igt_assert(fb_modeset_id);
 
 	igt_plane_set_fb(primary, &fb_modeset);
@@ -285,20 +283,12 @@ static bool test_pipe_legacy_gamma(data_t *data,
 	igt_output_override_mode(output, mode);
 
 	/* Create a framebuffer at the size of the output. */
-	fb_id = igt_create_fb(data->drm_fd,
-			      mode->hdisplay,
-			      mode->vdisplay,
-			      DRM_FORMAT_XRGB8888,
-			      DRM_FORMAT_MOD_LINEAR,
-			      &fb);
+	fb_id = create_color_test_fb(data, mode->hdisplay, mode->vdisplay,
+				     DRM_FORMAT_XRGB8888, &fb);
 	igt_assert(fb_id);
 
-	fb_modeset_id = igt_create_fb(data->drm_fd,
-				      mode->hdisplay,
-				      mode->vdisplay,
-				      DRM_FORMAT_XRGB8888,
-				      DRM_FORMAT_MOD_LINEAR,
-				      &fb_modeset);
+	fb_modeset_id = create_color_test_fb(data, mode->hdisplay, mode->vdisplay,
+					     DRM_FORMAT_XRGB8888, &fb_modeset);
 	igt_assert(fb_modeset_id);
 
 	igt_plane_set_fb(primary, &fb_modeset);
@@ -520,20 +510,12 @@ static bool test_pipe_ctm(data_t *data,
 	igt_output_override_mode(output, mode);
 
 	/* Create a framebuffer at the size of the output. */
-	fb_id = igt_create_fb(data->drm_fd,
-			      mode->hdisplay,
-			      mode->vdisplay,
-			      data->drm_format,
-			      DRM_FORMAT_MOD_LINEAR,
-			      &fb);
+	fb_id = create_color_test_fb(data, mode->hdisplay, mode->vdisplay,
+				     data->drm_format, &fb);
 	igt_assert(fb_id);
 
-	fb_modeset_id = igt_create_fb(data->drm_fd,
-				      mode->hdisplay,
-				      mode->vdisplay,
-				      data->drm_format,
-				      DRM_FORMAT_MOD_LINEAR,
-				      &fb_modeset);
+	fb_modeset_id = create_color_test_fb(data, mode->hdisplay, mode->vdisplay,
+					     data->drm_format, &fb_modeset);
 	igt_assert(fb_modeset_id);
 	igt_plane_set_fb(primary, &fb_modeset);
 
@@ -654,20 +636,12 @@ static void test_pipe_limited_range_ctm(data_t *data,
 		mode = igt_output_get_mode(output);
 
 		/* Create a framebuffer at the size of the output. */
-		fb_id = igt_create_fb(data->drm_fd,
-				      mode->hdisplay,
-				      mode->vdisplay,
-				      DRM_FORMAT_XRGB8888,
-				      DRM_FORMAT_MOD_LINEAR,
-				      &fb);
+		fb_id = create_color_test_fb(data, mode->hdisplay, mode->vdisplay,
+					     DRM_FORMAT_XRGB8888, &fb);
 		igt_assert(fb_id);
 
-		fb_modeset_id = igt_create_fb(data->drm_fd,
-					      mode->hdisplay,
-					      mode->vdisplay,
-					      DRM_FORMAT_XRGB8888,
-					      DRM_FORMAT_MOD_LINEAR,
-					      &fb_modeset);
+		fb_modeset_id = create_color_test_fb(data, mode->hdisplay, mode->vdisplay,
+						     DRM_FORMAT_XRGB8888, &fb_modeset);
 		igt_assert(fb_modeset_id);
 		igt_plane_set_fb(primary, &fb_modeset);
 
-- 
2.34.1