From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 302B6CD6E79 for ; Tue, 9 Jun 2026 03:49:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C2A2010E079; Tue, 9 Jun 2026 03:49:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="fthsdUcr"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 09F8A10E075 for ; Tue, 9 Jun 2026 03:47:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780976824; x=1812512824; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ajZ9PVPFN4ROhwOaNFQQhEF9UrpYAM5zUIzdkLPUL/k=; b=fthsdUcrxddpZ1fu5DwpDeTJvVLQnIF3M3kEgUQNyF5KflCoSZoMVtY4 W7hnthQfSTWPlJfd8xALNS65l5lhyyqUTckq/EInxj2I/jTb4RjDEYu3v MLFLtPkihqJ1XOcbaJ1BNwkVb2rU6hIRmGRRzhWATuAami5MiH4FdWGH2 PFA0YnsYz0nBilQEQJH9HJ65ROJfs9Mza99iZIjEvApLOodT/e0HkZW0P 6pJZjfIjjTVbRBNO+cZ2tkM6m5ucyhlI9+Wd5YUIvNn5nhhmPlzsGA1lW 5ss2XgeJTcpBaNWffRgzwCC2xKZhrH8azNseZsm7NqUThaJa7ZfQyW2ef g==; X-CSE-ConnectionGUID: cFgxeMtTRbynIgmDuxepwA== X-CSE-MsgGUID: zqlW/NcFSFWraTnl7UcAxg== X-IronPort-AV: E=McAfee;i="6800,10657,11811"; a="92050893" X-IronPort-AV: E=Sophos;i="6.24,195,1774335600"; d="scan'208";a="92050893" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 20:47:04 -0700 X-CSE-ConnectionGUID: KdOD7Uy8QTWEQclnjtZ5wA== X-CSE-MsgGUID: 6Nd30XMnTTmZqGCTVHJDLg== X-ExtLoop1: 1 Received: from jeevan-x299-aorus-gaming-3-pro.iind.intel.com ([10.227.90.91]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 20:47:02 -0700 From: Jeevan B To: igt-dev@lists.freedesktop.org Cc: animesh.manna@intel.com, dibin.moolakadan.subrahmanian@intel.com, mohammed.thasleem@intel.com, Jeevan B Subject: [PATCH i-g-t v9 2/7] tests/intel/kms_pm_dc: Replace require with proper assertion Date: Tue, 9 Jun 2026 09:16:45 +0530 Message-ID: <20260609034650.2281712-3-jeevan.b@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260609034650.2281712-1-jeevan.b@intel.com> References: <20260609034650.2281712-1-jeevan.b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" The DC3CO video playback simulation test was incorrectly using require at the end to check if DC3CO state was entered. This causes the test to be marked as SKIP instead of FAIL when DC3CO doesn't work properly, hiding real issues. So changing the call from require to assert. Fixes: b89efa8048e58 ("tests/i915/i915_pm_dc: Check dc3co count to skip the test") Signed-off-by: Jeevan B Reviewed-by: Mohammed Thasleem --- tests/intel/kms_pm_dc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c index c8cfa300c..27fa5dc39 100644 --- a/tests/intel/kms_pm_dc.c +++ b/tests/intel/kms_pm_dc.c @@ -316,8 +316,7 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data) usleep(delay); } - igt_require_f(igt_dc_state_wait_entry(data->debugfs_fd, IGT_INTEL_CHECK_DC3CO, - dc3co_prev_cnt), "dc3co-vpb-simulation not enabled\n"); + assert_dc_counter(data, IGT_INTEL_CHECK_DC3CO, dc3co_prev_cnt); } static void setup_dc3co(data_t *data) -- 2.43.0