From: Jani Nikula <jani.nikula@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH i-g-t 2/3] lib/kms: fix last pipe check in igt_check_bigjoiner_support()
Date: Tue, 16 Jun 2026 12:06:09 +0300 [thread overview]
Message-ID: <20260616090610.2106378-2-jani.nikula@intel.com> (raw)
In-Reply-To: <20260616090610.2106378-1-jani.nikula@intel.com>
Fix last pipe check for non-consecutive pipes. In theory the check could
be too restrictive for fused off pipes, but it's unlikely we've hit the
issue in practise. It's better to be pedantically correct here though.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
lib/igt_kms.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index c289d76d16e2..e82d32130666 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -7344,9 +7344,10 @@ bool igt_check_force_joiner_status(int drmfd, char *connector_name)
*/
bool igt_check_bigjoiner_support(igt_display_t *display)
{
- uint8_t i, total_pipes = 0, pipes_in_use = 0;
+ uint8_t i, pipes_in_use = 0;
igt_crtc_t *crtc;
igt_output_t *output;
+ enum pipe last_pipe = PIPE_NONE;
struct {
enum pipe idx;
drmModeModeInfo *mode;
@@ -7355,9 +7356,11 @@ bool igt_check_bigjoiner_support(igt_display_t *display)
} pipes[IGT_MAX_PIPES];
int max_dotclock;
- /* Get total enabled pipes. */
- for_each_crtc(display, crtc)
- total_pipes++;
+ /* Get last pipe */
+ for_each_crtc(display, crtc) {
+ if (crtc->pipe > last_pipe)
+ last_pipe = crtc->pipe;
+ }
/*
* Get list of CRTCs in use those were set by igt_output_set_crtc()
@@ -7401,7 +7404,7 @@ bool igt_check_bigjoiner_support(igt_display_t *display)
max_dotclock, pipes[i].force_joiner ? "Yes" : "No");
kmstest_dump_mode(pipes[i].mode);
- if (pipes[i].idx >= (total_pipes - 1)) {
+ if (pipes[i].idx >= last_pipe) {
igt_info("pipe-%s: Last pipe couldn't be used as a Bigjoiner Primary.\n",
kmstest_pipe_name(pipes[i].idx));
return false;
--
2.47.3
next prev parent reply other threads:[~2026-06-16 9:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 9:06 [PATCH i-g-t 1/3] tests/kms_bw: use igt_display_n_crtcs() Jani Nikula
2026-06-16 9:06 ` Jani Nikula [this message]
2026-06-17 9:22 ` [PATCH i-g-t 2/3] lib/kms: fix last pipe check in igt_check_bigjoiner_support() Karthik B S
2026-06-17 10:53 ` Jani Nikula
2026-06-16 9:06 ` [PATCH i-g-t 3/3] tests/kms_content_protection: remove unused max_pipe Jani Nikula
2026-06-17 9:25 ` Karthik B S
2026-06-16 14:53 ` ✓ i915.CI.BAT: success for series starting with [i-g-t,1/3] tests/kms_bw: use igt_display_n_crtcs() Patchwork
2026-06-16 14:59 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-16 17:38 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-06-17 4:46 ` ✓ i915.CI.Full: success " Patchwork
2026-06-17 9:20 ` [PATCH i-g-t 1/3] " Karthik B S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260616090610.2106378-2-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox