From: Pranay Samala <pranay.samala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, swati2.sharma@intel.com,
sameer.lattannavar@intel.com, pranay.samala@intel.com
Subject: [PATCH i-g-t v6 2/3] tests/kms_hdr: Simplify flag check and continue with next format on failure
Date: Thu, 18 Jun 2026 12:03:46 +0530 [thread overview]
Message-ID: <20260618063347.2940031-3-pranay.samala@intel.com> (raw)
In-Reply-To: <20260618063347.2940031-1-pranay.samala@intel.com>
Simplify the HDR flag check to improve code readability. Also change
the cleanup failure path from break to continue to allow remaining format
combinations to be tested, ensuring formats that might succeed are still
validated.
Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
tests/kms_hdr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
index 7127a56b3..c334c907a 100644
--- a/tests/kms_hdr.c
+++ b/tests/kms_hdr.c
@@ -553,7 +553,7 @@ static void test_hdr(data_t *data, uint32_t flags)
continue;
}
- if ((flags & ~TEST_INVALID_HDR) && !igt_is_panel_hdr(data->fd, output)) {
+ if (!(flags & TEST_INVALID_HDR) && !igt_is_panel_hdr(data->fd, output)) {
igt_info("%s: Can't run HDR tests on non-HDR panel.\n",
igt_output_name(output));
continue;
@@ -610,7 +610,7 @@ static void test_hdr(data_t *data, uint32_t flags)
igt_plane_set_fb(data->primary, NULL);
igt_remove_fb(data->fd, &data->afb);
test_fini(data);
- break;
+ continue;
}
/* Reset IGT display state; hardware was not changed. */
--
2.34.1
next prev parent reply other threads:[~2026-06-18 6:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 6:33 [PATCH i-g-t v6 0/3] Improve max-bpc query error handling Pranay Samala
2026-06-18 6:33 ` [PATCH i-g-t v6 1/3] Revert "tests/kms_hdr: Move capability checks inside dynamic subtests" Pranay Samala
2026-06-18 8:04 ` Karthik B S
2026-06-18 6:33 ` Pranay Samala [this message]
2026-06-18 8:31 ` [PATCH i-g-t v6 2/3] tests/kms_hdr: Simplify flag check and continue with next format on failure Karthik B S
2026-06-18 6:33 ` [PATCH i-g-t v6 3/3] lib/tests: make igt_get_output_max_bpc() return status and handle failures in callers Pranay Samala
2026-06-18 7:56 ` ✓ Xe.CI.BAT: success for Improve max-bpc query error handling Patchwork
2026-06-18 8:02 ` ✗ i915.CI.BAT: failure " Patchwork
2026-06-18 15:37 ` ✗ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260618063347.2940031-3-pranay.samala@intel.com \
--to=pranay.samala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=sameer.lattannavar@intel.com \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox