Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sk Anirban <sk.anirban@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: anshuman.gupta@intel.com, badal.nilawar@intel.com,
	riana.tauro@intel.com, karthik.poosa@intel.com,
	raag.jadav@intel.com, soham.purkait@intel.com,
	mallesh.koujalagi@intel.com, vinay.belgaumkar@intel.com,
	Sk Anirban <sk.anirban@intel.com>
Subject: [PATCH v2] tests/xe_pmu: Fix gt-frequency failure with raised min freq
Date: Fri, 19 Jun 2026 17:08:09 +0530	[thread overview]
Message-ID: <20260619113808.2442376-2-sk.anirban@intel.com> (raw)

The gt-frequency subtest can fail when the min frequency has
already been raised above RPn before the test begins. Using that
value as the original minimum prevents the later min_freq write
from enabling the GuC ignore_efficient_freq parameter, so min_freq
can keep moving toward RPe.

Since RPe varies dynamically with thermal conditions, use RPn as the
fixed minimum baseline instead. This ensures that writing to min_freq
enables the ignore_efficient_freq GuC parameter.

v2: Fix commit message (Vinay)

Closes:https://gitlab.freedesktop.org/drm/xe/kernel/issues/8344
Signed-off-by: Sk Anirban <sk.anirban@intel.com>
Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
 tests/intel/xe_pmu.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/tests/intel/xe_pmu.c b/tests/intel/xe_pmu.c
index fb4b871e7..4bbc801a1 100644
--- a/tests/intel/xe_pmu.c
+++ b/tests/intel/xe_pmu.c
@@ -903,10 +903,8 @@ static void test_gt_frequency(int fd, struct drm_xe_engine_class_instance *eci)
 	unsigned long config_rq_freq, config_act_freq;
 	double min[2], max[2];
 	uint32_t gt = eci->gt_id;
-	uint32_t orig_min = xe_gt_get_freq(fd, eci->gt_id, "min");
+	uint32_t orig_min = xe_gt_get_freq(fd, eci->gt_id, "rpn");
 	uint32_t orig_max = xe_gt_get_freq(fd, eci->gt_id, "max");
-	uint32_t current_min;
-	uint32_t orig_rpe;
 	uint32_t vm;
 	int pmu_fd[2];
 
@@ -956,9 +954,7 @@ static void test_gt_frequency(int fd, struct drm_xe_engine_class_instance *eci)
 	 * Restore min/max.
 	 */
 	igt_assert(xe_gt_set_freq(fd, gt, "min", orig_min) > 0);
-	orig_rpe = xe_gt_get_freq(fd, gt, "rpe");
-	current_min = xe_gt_get_freq(fd, gt, "min");
-	igt_assert(current_min == orig_min || current_min == orig_rpe);
+	igt_assert(xe_gt_get_freq(fd, gt, "min") == orig_min);
 
 	igt_info("Minimum frequency: requested %.1f, actual %.1f\n",
 		 min[0], min[1]);
-- 
2.43.0


             reply	other threads:[~2026-06-19 11:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19 11:38 Sk Anirban [this message]
2026-06-19 13:45 ` ✓ i915.CI.BAT: success for tests/xe_pmu: Fix gt-frequency failure with raised min freq (rev2) Patchwork
2026-06-19 13:52 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-19 15:41 ` ✓ Xe.CI.FULL: " Patchwork
2026-06-20 12:27 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260619113808.2442376-2-sk.anirban@intel.com \
    --to=sk.anirban@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.poosa@intel.com \
    --cc=mallesh.koujalagi@intel.com \
    --cc=raag.jadav@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=soham.purkait@intel.com \
    --cc=vinay.belgaumkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox