From: "Michał Grzelak" <michal.grzelak@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: juhapekka.heikkila@gmail.com,
"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH i-g-t v1 2/2] tests/kms_frontbuffer_tracking: iterate over suspend with `for`
Date: Mon, 29 Jun 2026 11:15:59 +0200 [thread overview]
Message-ID: <20260629091559.2706720-3-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260629091559.2706720-1-michal.grzelak@intel.com>
igt@kms_frontbuffer_tracking introduces TEST_MODE_ITER_BEGIN(t) which
consists of nested for loops. However, most of loops is skipped during
continue statement, thus can be omitted. Thus obfuscates following the
execution of any given codepath. Replace TEST_MODE_ITER_BEGIN(t) for
suspend tests with macro definition and remove skipped for loops.
Cc: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
tests/intel/kms_frontbuffer_tracking.c | 22 +++++++++++++++-------
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index d38c3969d0..e1f0412ecb 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -4647,12 +4647,20 @@ int igt_main_args("", long_options, help_str, opt_handler, NULL)
}
TEST_MODE_ITER_END
- TEST_MODE_ITER_BEGIN(t)
- if (t.pipes != PIPE_SINGLE ||
- t.screen != SCREEN_PRIM ||
- t.plane != PLANE_PRI ||
- t.fbs != FBS_INDIVIDUAL ||
- t.method != IGT_DRAW_BLT)
+ t.format = FORMAT_DEFAULT;
+ t.flip = FLIP_PAGEFLIP;
+ t.tiling = opt.tiling;
+ t.pipes = PIPE_SINGLE;
+ t.screen = SCREEN_PRIM;
+ t.plane = PLANE_PRI;
+ t.fbs = FBS_INDIVIDUAL;
+ t.method = IGT_DRAW_BLT;
+
+ for (t.feature = 0; t.feature < FEATURE_COUNT; t.feature++) {
+
+ if (!opt.show_hidden && t.feature == FEATURE_NONE)
+ continue;
+ if ((t.feature & FEATURE_PSR) && (t.feature & FEATURE_DRRS))
continue;
igt_subtest_f("%s-modesetfrombusy", feature_str(t.feature))
@@ -4713,7 +4721,7 @@ int igt_main_args("", long_options, help_str, opt_handler, NULL)
igt_require(igt_draw_supports_method(drm.fd, t.method));
suspend_subtest(&t);
}
- TEST_MODE_ITER_END
+ }
t.pipes = PIPE_SINGLE;
t.screen = SCREEN_PRIM;
--
2.45.2
next prev parent reply other threads:[~2026-06-29 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 9:15 [PATCH i-g-t v1 0/2] frontbuffer_tracking: prep for limiting suspend Michał Grzelak
2026-06-29 9:15 ` [PATCH i-g-t v1 1/2] tests/kms_frontbuffer_tracking: remove typos Michał Grzelak
2026-06-29 9:15 ` Michał Grzelak [this message]
2026-06-29 22:50 ` ✓ Xe.CI.BAT: success for frontbuffer_tracking: prep for limiting suspend Patchwork
2026-06-29 22:58 ` ✓ i915.CI.BAT: " Patchwork
2026-06-30 8:33 ` ✓ Xe.CI.FULL: " Patchwork
2026-06-30 9:46 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260629091559.2706720-3-michal.grzelak@intel.com \
--to=michal.grzelak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox