From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7287CC43327 for ; Thu, 2 Jul 2026 18:27:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DA6D10F562; Thu, 2 Jul 2026 18:27:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="eha+Eo8Z"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 149B810F55E for ; Thu, 2 Jul 2026 18:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783016804; x=1814552804; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6tLPbAak4cflCKSHQJorExHzJ63TPTWaHWJdUxr3sPM=; b=eha+Eo8ZIcBAvRBrFniYwu3vF7Phi20nYI/m8sfGGSi3uTT9vCB7zYOq jDTqe6B5sIc9AWz/4tKqPAMyL/rxROCm5930rGvgfPOYS7WP9CLSrgMcg c1WaVWqf8XbQGjp0gUZryjytaCPGOKTzx3Qqu6xQjkyzNHu+bB2/HsS1+ RC4wAvj6zj8E6AWBv+cFu5EDARjtHmHkfZ5lSZ4Ooo6JFsSuB//JpESKk hJQ136JzLn/rytO6rzakp9J2WEX1CA7CN247FH/bJ5PjcF/9eCMXyr5V8 sJ+XNQSPrtgJcoKPdrhiZZG4uBjVemHJVk3g+TV41rAEbfRI+w7XCIne+ A==; X-CSE-ConnectionGUID: QnvYw1CERHWdfniB+1JzCg== X-CSE-MsgGUID: XDiaKQ5YQe2cr6orD2QEew== X-IronPort-AV: E=McAfee;i="6800,10657,11835"; a="95154704" X-IronPort-AV: E=Sophos;i="6.25,144,1779174000"; d="scan'208";a="95154704" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2026 11:26:44 -0700 X-CSE-ConnectionGUID: 1TDWvaV5RsacwUyEi2ljWA== X-CSE-MsgGUID: u/fTBTgdRr2SgHxe0E37+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,144,1779174000"; d="scan'208";a="253577106" Received: from dev-417.igk.intel.com ([10.91.214.181]) by orviesa009.jf.intel.com with ESMTP; 02 Jul 2026 11:26:43 -0700 From: =?UTF-8?q?Micha=C5=82=20Grzelak?= To: igt-dev@lists.freedesktop.org Cc: jani.nikula@intel.com, suraj.kandpal@intel.com, =?UTF-8?q?Micha=C5=82=20Grzelak?= Subject: [PATCH i-g-t v5 4/7] tools/vbt_decode: parse & dump VS/PE-O tables for LT Date: Thu, 2 Jul 2026 20:26:16 +0200 Message-ID: <20260702182619.3973788-5-michal.grzelak@intel.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260702182619.3973788-1-michal.grzelak@intel.com> References: <20260702182619.3973788-1-michal.grzelak@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" Dump VBT #57 tables for LT. Add a table of strings to store each table purpose. Show the affected modes on dumping. Currently Vswing / Pre-emphasis Override is not supported by kernel on LT, but it doesn't harm to add decoding into IGT. v2->v3 - return 16 rows on MTL instead of 10 v1->v2 - check platform basing on devid not VBT signature (Jani) Signed-off-by: Michał Grzelak --- tools/intel_vbt_decode.c | 64 +++++++++++++++++++++++++++++++++------- 1 file changed, 54 insertions(+), 10 deletions(-) diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c index 33f8598e5f..2f3f720573 100644 --- a/tools/intel_vbt_decode.c +++ b/tools/intel_vbt_decode.c @@ -3465,24 +3465,68 @@ static const char * const vspeo_dp14_levels[10] = { "V3-P0", }; -static void dump_vswing_preemphasis(struct context *context, - const struct bdb_block *block) +static const char * const vspeo_lt_tables[6] = { + "UNUSED", + "UNUSED", + "UNUSED", + "UNUSED", + "DP 1.4", + "DP 2.1", +}; + +static void dump_lt_vspeo(const struct bdb_vswing_preemph *vspeo, + int num_rows) { - const struct bdb_vswing_preemph *vspeo = block_data(block); + const unsigned int *tables = vspeo->tables; + size_t offset = 0; printf("\tNumber of vswing tables: %d\n", vspeo->num_tables); printf("\tNumber of columns: %d\n", vspeo->num_columns); + printf("\tNumber of rows: %d\n", num_rows); + + printf("\tPHY type: LT\n"); for (int idx = 0; idx < vspeo->num_tables; idx++) { - printf("\tVswing Table #%d:\n", idx+1); + printf("\tVswing Table #%d (%s):\n", idx+1, vspeo_lt_tables[idx]); + for (int row = 0; row < num_rows; row++) { + int main_cursor = tables[offset]; + int pre_cursor = tables[offset + 1]; + int post_cursor = tables[offset + 2]; + + printf("\t\tPreset #%02d: ", row+1); + printf("main-cursor: 0x%08x, ", main_cursor); + printf("pre-cursor: 0x%08x, ", pre_cursor); + printf("post-cursor: 0x%08x\n", post_cursor); + + offset += vspeo->num_columns; + } + } +} - for (int row = 0; row < 10; row++) { - printf("\t\t%s: ", vspeo_levels[row]); +static int +vswing_preemph_num_rows(int devid) +{ + return intel_display_ver(devid) >= 14 ? 16 : 10; +} - for (int col = 0; col < vspeo->num_columns; col++) - printf(" 0x%08x", vspeo->tables[idx * 10 * vspeo->num_columns + row * col]); - printf("\n"); - } +static void dump_vswing_preemphasis(struct context *context, + const struct bdb_block *block) +{ + const struct bdb_vswing_preemph *vspeo = block_data(block); + int devid = context->devid; + int num_rows; + + if (!devid) { + fprintf(stderr, "Error: cannot parse VS/PE-O without devid\n"); + return; + } + + num_rows = vswing_preemph_num_rows(devid); + + if (IS_NOVALAKE_P(devid) || IS_NOVALAKE_S(devid)) { + dump_lt_vspeo(vspeo, num_rows); + } else { + printf("Warning: deparsing VS/PE-O from devid %x not supported\n", devid); } } -- 2.45.2