Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: kamil.konieczny@linux.intel.com, Swati Sharma <swati2.sharma@intel.com>
Subject: [PATCH i-g-t 2/2] tests/kms_feature_discovery: Log output count on skip
Date: Thu,  9 Jul 2026 12:28:52 +0530	[thread overview]
Message-ID: <20260709065852.3000382-3-swati2.sharma@intel.com> (raw)
In-Reply-To: <20260709065852.3000382-1-swati2.sharma@intel.com>

Add a num_outputs counter to feature discovery subtests
that iterate connected outputs (dp-mst, hdr, vrr, dsc).
Print the count in the igt_require_f message so it's clear
how many outputs were checked when a feature is not found.

Suggested-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Assisted-by: GitHub Copilot:Claude Opus 4.6
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_feature_discovery.c | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/tests/kms_feature_discovery.c b/tests/kms_feature_discovery.c
index 4ad2e6a74..97bb25360 100644
--- a/tests/kms_feature_discovery.c
+++ b/tests/kms_feature_discovery.c
@@ -175,9 +175,11 @@ int igt_main() {
 			struct kmstest_connector_config config;
 			igt_output_t *output;
 			const char *encoder;
+			int num_outputs = 0;
 			int ret = -1;
 
 			for_each_connected_output(&display, output) {
+				num_outputs++;
 				kmstest_get_connector_config(fd, output->config.connector->connector_id, -1, &config);
 				encoder = kmstest_encoder_type_str(config.encoder->encoder_type);
 
@@ -185,16 +187,20 @@ int igt_main() {
 				if (ret == 0)
 					break;
 			}
-			igt_require_f(ret == 0, "No DP-MST configuration found.\n");
+			igt_require_f(ret == 0,
+				      "No DP-MST config found (checked %d outputs).\n",
+				      num_outputs);
 		}
 
 		igt_describe("Make sure that we have at least one HDR-capable panel.");
 		igt_subtest("hdr") {
 			igt_output_t *output;
 			unsigned int max_bpc;
+			int num_outputs = 0;
 			bool found = false;
 
 			for_each_connected_output(&display, output) {
+				num_outputs++;
 				if (!igt_output_has_prop(output, IGT_CONNECTOR_MAX_BPC))
 					continue;
 
@@ -214,15 +220,18 @@ int igt_main() {
 			}
 
 			igt_require_f(found,
-				      "No HDR-capable panel found with max bpc, HDR metadata, and EDID HDR support.\n");
+				      "No HDR-capable panel found (checked %d outputs).\n",
+				      num_outputs);
 		}
 
 		igt_describe("Make sure that we have at least one VRR-capable panel.");
 		igt_subtest("vrr") {
 			igt_output_t *output;
+			int num_outputs = 0;
 			bool found = false;
 
 			for_each_connected_output(&display, output) {
+				num_outputs++;
 				if (!igt_output_has_prop(output, IGT_CONNECTOR_VRR_CAPABLE))
 					continue;
 
@@ -233,15 +242,19 @@ int igt_main() {
 				break;
 			}
 
-			igt_require_f(found, "No VRR-capable panel found.\n");
+			igt_require_f(found,
+				      "No VRR-capable panel found (checked %d outputs).\n",
+				      num_outputs);
 		}
 
 		igt_describe("Make sure that we have at least one DSC-capable sink.");
 		igt_subtest("dsc") {
 			igt_output_t *output;
+			int num_outputs = 0;
 			bool found = false;
 
 			for_each_connected_output(&display, output) {
+				num_outputs++;
 				if (!igt_is_dsc_supported_by_sink(fd, output->name))
 					continue;
 
@@ -249,7 +262,9 @@ int igt_main() {
 				break;
 			}
 
-			igt_require_f(found, "No DSC-capable sink found.\n");
+			igt_require_f(found,
+				      "No DSC-capable sink found (checked %d outputs).\n",
+				      num_outputs);
 		}
 	}
 }
-- 
2.25.1


  parent reply	other threads:[~2026-07-09  6:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  6:58 [PATCH i-g-t 0/2] tests/kms_feature_discovery: add HDR, VRR and DSC discovery Swati Sharma
2026-07-09  6:58 ` [PATCH i-g-t 1/2] " Swati Sharma
2026-07-09 13:59   ` Kamil Konieczny
2026-07-09  6:58 ` Swati Sharma [this message]
2026-07-09 14:00   ` [PATCH i-g-t 2/2] tests/kms_feature_discovery: Log output count on skip Kamil Konieczny
2026-07-09 19:39 ` ✓ Xe.CI.BAT: success for tests/kms_feature_discovery: add HDR, VRR and DSC discovery (rev2) Patchwork
2026-07-09 20:17 ` ✓ i915.CI.BAT: " Patchwork
2026-07-10  1:32 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-07-10 22:23 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260709065852.3000382-3-swati2.sharma@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox