Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bernd Kuhls <bernd@kuhls.net>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 2/2] tests/intel/xe_madvise: Fix the type for sighandler_t
Date: Fri, 10 Jul 2026 20:46:19 +0200	[thread overview]
Message-ID: <20260710184619.2347456-2-bernd@kuhls.net> (raw)
In-Reply-To: <20260710184619.2347456-1-bernd@kuhls.net>

__sighandler_t is private interface in glibc so its
better to not use it, as an aside fixes build with musl

Patch was inspired by
https://lists.gnu.org/r/bug-time/2025-03/msg00000.html

Fixes build error seen with musl-based toolchains:

../tests/intel/xe_madvise.c: In function ‘test_dontneed_after_mmap’:
../tests/intel/xe_madvise.c:400:48: error: ‘__sighandler_t’ undeclared
 (first use in this function); did you mean ‘sighandler_t’?
  400 |          old_sigsegv = signal(SIGSEGV, (__sighandler_t)sigtrap);

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 tests/intel/xe_madvise.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/intel/xe_madvise.c b/tests/intel/xe_madvise.c
index 3d36be941..a33a08630 100644
--- a/tests/intel/xe_madvise.c
+++ b/tests/intel/xe_madvise.c
@@ -397,8 +397,8 @@ static void test_dontneed_after_mmap(int fd)
 		char *ptr = (char *)map;
 		int sig;
 
-		old_sigsegv = signal(SIGSEGV, (__sighandler_t)sigtrap);
-		old_sigbus = signal(SIGBUS, (__sighandler_t)sigtrap);
+		old_sigsegv = signal(SIGSEGV, (sighandler_t)sigtrap);
+		old_sigbus = signal(SIGBUS, (sighandler_t)sigtrap);
 
 		sig = sigsetjmp(jmp, 1); /* savemask=1: save/restore signal mask */
 		switch (sig) {
-- 
2.47.3


  reply	other threads:[~2026-07-10 18:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 18:46 [PATCH i-g-t 1/2] tools/intel_gpu_frequency: include limits.h to fix musl build Bernd Kuhls
2026-07-10 18:46 ` Bernd Kuhls [this message]
2026-07-13 11:27   ` [PATCH i-g-t 2/2] tests/intel/xe_madvise: Fix the type for sighandler_t Kamil Konieczny
2026-07-10 20:25 ` ✓ Xe.CI.BAT: success for series starting with [i-g-t,1/2] tools/intel_gpu_frequency: include limits.h to fix musl build Patchwork
2026-07-10 20:25 ` ✓ i915.CI.BAT: " Patchwork
2026-07-11  5:59 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-11 21:30 ` ✗ i915.CI.Full: failure " Patchwork
2026-07-13 11:30   ` Kamil Konieczny
2026-07-13 11:03 ` [PATCH i-g-t 1/2] " Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260710184619.2347456-2-bernd@kuhls.net \
    --to=bernd@kuhls.net \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox