[PATCH i-g-t v2] tests/kms_force_connector_basic: re-baseline connection state before comparing

[Suraj Kandpal <suraj.kandpal@intel.com>]

force_connector_state compares the end-of-subtest connection state
against a snapshot taken once in igt_fixture(). That snapshot can be
stale (e.g. adaptor still initializing, HPD disturbed by earlier
power transitions) or reflect a leftover force flag from a previous
subtest or from igt_handle_spurious_hpd(), causing spurious failures.

Take a fresh baseline inside the subtest, after clearing any
leftover force with FORCE_CONNECTOR_UNSPECIFIED, and compare against
that.

Assisted-by: GitHub Copilot:Claude Opus 4.7
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 tests/kms_force_connector_basic.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/tests/kms_force_connector_basic.c b/tests/kms_force_connector_basic.c
index 4ea6b0e8c..c4252ea02 100644
--- a/tests/kms_force_connector_basic.c
+++ b/tests/kms_force_connector_basic.c
@@ -177,7 +177,7 @@ static void force_load_detect(int drm_fd, drmModeConnectorPtr connector, drmMode
 static void force_connector_state(int drm_fd, drmModeConnectorPtr connector)
 {
 	igt_display_t display;
-	drmModeConnector *temp;
+	drmModeConnector *baseline, *temp;
 
 	igt_display_require(&display, drm_fd);
 
@@ -185,6 +185,10 @@ static void force_connector_state(int drm_fd, drmModeConnectorPtr connector)
 	igt_display_reset(&display);
 	igt_display_commit(&display);
 
+	kmstest_force_connector(drm_fd, connector, FORCE_CONNECTOR_UNSPECIFIED);
+	baseline = drmModeGetConnector(drm_fd, connector->connector_id);
+	igt_assert(baseline);
+
 	/* Force the connector on and check the reported values. */
 	kmstest_force_connector(drm_fd, connector, FORCE_CONNECTOR_ON);
 	temp = drmModeGetConnectorCurrent(drm_fd,
@@ -207,9 +211,10 @@ static void force_connector_state(int drm_fd, drmModeConnectorPtr connector)
 				FORCE_CONNECTOR_UNSPECIFIED);
 	temp = drmModeGetConnectorCurrent(drm_fd,
 					  connector->connector_id);
-	igt_assert_eq(temp->connection, connector->connection);
+	igt_assert_eq(temp->connection, baseline->connection);
 	drmModeFreeConnector(temp);
 
+	drmModeFreeConnector(baseline);
 	igt_display_fini(&display);
 }
 
-- 
2.34.1