From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC3E2C43458 for ; Mon, 13 Jul 2026 13:42:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5CBB210E9AF; Mon, 13 Jul 2026 13:42:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="HnHHxBV+"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id E4C6510E9AF for ; Mon, 13 Jul 2026 13:38:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783949906; x=1815485906; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ib7rb/JPp59rqaK/LRW2fjbu0THTJSy+MYFh5I07vjg=; b=HnHHxBV+caZzpc6ZJc/EVdDttRoGBCXIBFQOzfA8eL1NTSdjOPPk2ftM 9ozAFv9iE2PvuacioWypzoHteAm40JDpHRP7lcLoS0n3qttxVx1YSf0bb fvuNvntT/B9tLBvFU+UQoiRTflGQ5jMdYlikvkx239oU4oeUf92uHB1Zj EhKQ+/RghGuMykiib5BdtIoG++QqLb4Kiqid4vjp23jqKWgF71ShVxliD a8WOs+J1Wi2tc49bCBRaXmx15pp4KGaOaw40Kei4fa6sSFYcrBa7LTkOM 42GeVA531gE3MBQM8DbF53pejRMdDIsX3kLwCBNMJ9qd70u/YmE1LTV5F A==; X-CSE-ConnectionGUID: JW0NZRSwTEisP05yi5v1dQ== X-CSE-MsgGUID: itfJL4zTR4qIG2AWhw+3vQ== X-IronPort-AV: E=McAfee;i="6800,10657,11841"; a="87101722" X-IronPort-AV: E=Sophos;i="6.25,154,1779174000"; d="scan'208";a="87101722" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2026 06:38:26 -0700 X-CSE-ConnectionGUID: sLvJuok4R5qpKarTSLsxpw== X-CSE-MsgGUID: A6TltAZYSS6RdOMe9cl5dA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,154,1779174000"; d="scan'208";a="285639161" Received: from art-dev-395.igk.intel.com ([10.211.135.233]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2026 06:38:25 -0700 From: Jan Maslak To: igt-dev@lists.freedesktop.org Cc: zbigniew.kempczynski@intel.com, Jan Maslak Subject: [PATCH v6 11/11] lib: Add genxml annotated batch buffer decode Date: Mon, 13 Jul 2026 15:37:46 +0200 Message-ID: <20260713133746.453051-12-jan.maslak@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260713133746.453051-1-jan.maslak@intel.com> References: <20260713133746.453051-1-jan.maslak@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" When IGT_BB_ANNOTATE=1 is set, intel_bb_dump() writes a companion .annotated file alongside the raw hex dump. The annotated file identifies each command and prints its field names and values, decoded via the genxml *_decode.h headers. The opt-in environment variable avoids file I/O overhead in normal test runs. A disclaimer in the file header notes that the decode is best-effort and may lag hardware on newer platforms. Signed-off-by: Jan Maslak Reviewed-by: Zbigniew Kempczyński --- lib/intel_batchbuffer.c | 32 +++++++++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c index 912b936e0c..1dacfdc6c7 100644 --- a/lib/intel_batchbuffer.c +++ b/lib/intel_batchbuffer.c @@ -42,6 +42,7 @@ #include "intel_batchbuffer.h" #include "intel_bufops.h" #include "intel_chipset.h" +#include "intel/genxml/igt_genxml_decode.h" #include "intel_pat.h" #include "media_fill.h" #include "media_spin.h" @@ -1611,7 +1612,9 @@ void intel_bb_print(struct intel_bb *ibb) * @filename: name to which write bb * @in_hex: dump bb in hex form * - * Dump batch bo to file. + * Dump batch bo to file. When IGT_BB_ANNOTATE=1 is set, also writes + * a companion annotated file (filename + ".annotated") with + * genxml-decoded field names and values. */ void intel_bb_dump(struct intel_bb *ibb, const char *filename, bool in_hex) { @@ -1641,6 +1644,33 @@ void intel_bb_dump(struct intel_bb *ibb, const char *filename, bool in_hex) } fclose(out); + /* Write a companion annotated decode alongside the raw dump, + * but only when explicitly requested via IGT_BB_ANNOTATE=1. + */ + if (getenv("IGT_BB_ANNOTATE")) { + char *ann_filename; + unsigned batch_dwords; + + igt_assert(asprintf(&ann_filename, "%s.annotated", filename) > 0); + batch_dwords = intel_bb_offset(ibb) / sizeof(uint32_t); + + out = fopen(ann_filename, "w"); + if (out) { + fprintf(out, + "# Batch buffer annotated decode\n" + "# Decoded using IGT's genxml definitions.\n" + "# This is a best-effort annotation and may be inaccurate,\n" + "# especially on newer platforms where the XML definitions\n" + "# may not yet reflect the latest hardware changes.\n" + "\n"); + igt_genxml_decode_batch(out, ibb->devid, + (const uint32_t *)ptr, + batch_dwords); + fclose(out); + } + free(ann_filename); + } + if (ptr != ibb->batch) munmap(ptr, ibb->size); } -- 2.43.0