From: Robert Mazur <robert.mazur@imgtec.com>
To: <igt-dev@lists.freedesktop.org>
Cc: Alessio Belle <alessio.belle@imgtec.com>,
Luigi Santivetti <luigi.santivetti@imgtec.com>,
Brajesh Gupta <brajesh.gupta@imgtec.com>,
Robert Mazur <robert.mazur@imgtec.com>,
Sarah Walker <sarah.walker@imgtec.com>
Subject: [PATCH i-g-t v2 05/10] tests/imagination: Add DEV_QUERY heap info tests
Date: Fri, 17 Jul 2026 11:18:18 +0200 [thread overview]
Message-ID: <20260717-test-imagination-add-support-v2-5-e1bf415adcee@imgtec.com> (raw)
In-Reply-To: <20260717-test-imagination-add-support-v2-0-e1bf415adcee@imgtec.com>
From: Sarah Walker <sarah.walker@imgtec.com>
Add subtests for DRM_IOCTL_PVR_DEV_QUERY heap info queries.
Signed-off-by: Sarah Walker <sarah.walker@imgtec.com>
Signed-off-by: Robert Mazur <robert.mazur@imgtec.com>
---
lib/igt_pvr.c | 21 ++++++
lib/igt_pvr.h | 2 +
tests/imagination/meson.build | 1 +
tests/imagination/pvr_heap_info.c | 130 ++++++++++++++++++++++++++++++++++++++
4 files changed, 154 insertions(+)
diff --git a/lib/igt_pvr.c b/lib/igt_pvr.c
index a729618d0..a190cd67b 100644
--- a/lib/igt_pvr.c
+++ b/lib/igt_pvr.c
@@ -73,3 +73,24 @@ igt_pvr_ioctl_dev_query(int fd, enum drm_pvr_dev_query type, uint64_t size,
return args;
}
+struct drm_pvr_heap *
+igt_pvr_get_heap_info(int fd, uint32_t *array_len_out)
+{
+ struct drm_pvr_heap *heaps =
+ calloc(DRM_PVR_HEAP_COUNT, sizeof(*heaps));
+ struct drm_pvr_dev_query_heap_info heap_info_get = {
+ .heaps = DRM_PVR_OBJ_ARRAY(DRM_PVR_HEAP_COUNT, heaps),
+ };
+
+ if (!heaps)
+ return NULL;
+
+ igt_pvr_ioctl_dev_query(fd, DRM_PVR_DEV_QUERY_HEAP_INFO_GET,
+ sizeof(heap_info_get), &heap_info_get, 0);
+
+ if (array_len_out)
+ *array_len_out = heap_info_get.heaps.count;
+
+ return heaps;
+}
+
diff --git a/lib/igt_pvr.h b/lib/igt_pvr.h
index e949772e4..181a0e843 100644
--- a/lib/igt_pvr.h
+++ b/lib/igt_pvr.h
@@ -17,5 +17,7 @@ off_t igt_pvr_ioctl_get_bo_mmap_offset(int fd, uint32_t handle);
struct drm_pvr_ioctl_dev_query_args
igt_pvr_ioctl_dev_query(int fd, enum drm_pvr_dev_query type, uint64_t size,
void *pointer, int expect_err);
+struct drm_pvr_heap *
+igt_pvr_get_heap_info(int fd, uint32_t *array_len_out);
#endif /* IGT_PVR_H */
diff --git a/tests/imagination/meson.build b/tests/imagination/meson.build
index c5899972b..fc24d0220 100644
--- a/tests/imagination/meson.build
+++ b/tests/imagination/meson.build
@@ -1,6 +1,7 @@
pvr_progs = [ 'pvr_dev_query',
'pvr_gem',
'pvr_gpu_info',
+ 'pvr_heap_info',
]
pvr_deps = test_deps
diff --git a/tests/imagination/pvr_heap_info.c b/tests/imagination/pvr_heap_info.c
new file mode 100644
index 000000000..b498214d9
--- /dev/null
+++ b/tests/imagination/pvr_heap_info.c
@@ -0,0 +1,130 @@
+// SPDX-License-Identifier: GPL-2.0 or MIT
+/* Copyright (c) 2026 Imagination Technologies Ltd. All Rights Reserved */
+
+#include "igt.h"
+#include "igt_pvr.h"
+
+#include "pvr_drm.h"
+
+#include <errno.h>
+#include <stdbool.h>
+#include <stdint.h>
+
+enum pvr_page_size {
+ PVR_PAGE_SIZE_4K = 12,
+ PVR_PAGE_SIZE_16K = 14,
+ PVR_PAGE_SIZE_64K = 16,
+ PVR_PAGE_SIZE_256K = 18,
+ PVR_PAGE_SIZE_1M = 20,
+ PVR_PAGE_SIZE_2M = 21
+};
+
+int igt_main()
+{
+ int fd;
+
+ igt_fixture()
+ {
+ fd = drm_open_driver(DRIVER_POWERVR);
+ }
+
+ igt_describe("Test getting the size of an array from the kernel");
+ igt_subtest("heap-info-get-size")
+ {
+ /* Check we can get the size of the array kernel side. */
+ struct drm_pvr_dev_query_heap_info heap_info_get = {0};
+
+ igt_pvr_ioctl_dev_query(fd, DRM_PVR_DEV_QUERY_HEAP_INFO_GET,
+ sizeof(heap_info_get), &heap_info_get, 0);
+ igt_assert_neq(heap_info_get.heaps.count, 0);
+ igt_assert_neq(heap_info_get.heaps.stride, 0);
+ }
+
+ igt_describe("Test copying a single heap info from the kernel");
+ igt_subtest("heap-info-copy-single")
+ {
+ struct drm_pvr_heap *heaps =
+ calloc(DRM_PVR_HEAP_COUNT, sizeof(*heaps));
+
+ /* Try copying a single heap. */
+ struct drm_pvr_dev_query_heap_info heap_info_get = {
+ .heaps = DRM_PVR_OBJ_ARRAY(1, heaps),
+ };
+
+ igt_pvr_ioctl_dev_query(fd, DRM_PVR_DEV_QUERY_HEAP_INFO_GET,
+ sizeof(heap_info_get), &heap_info_get, 0);
+
+ /* Kernel should stop copying after a single heap. */
+ igt_assert_eq(heap_info_get.heaps.count, 1);
+ igt_assert_eq(heaps[1].size, 0);
+
+ /* Kernel should respect the user side array stride. */
+ igt_assert_eq(heap_info_get.heaps.stride, sizeof(*heaps));
+ }
+
+ igt_describe("Test copying all heaps info from the kernel");
+ igt_subtest("heap-info-copy-all")
+ {
+ struct drm_pvr_dev_query_heap_info heap_info_get = {0};
+ struct drm_pvr_heap *heaps =
+ calloc(DRM_PVR_HEAP_COUNT, sizeof(*heaps));
+ uint32_t kernel_array_size = 0;
+
+ igt_pvr_ioctl_dev_query(fd, DRM_PVR_DEV_QUERY_HEAP_INFO_GET,
+ sizeof(heap_info_get), &heap_info_get, 0);
+
+ kernel_array_size = heap_info_get.heaps.count;
+
+ heap_info_get.heaps =
+ (struct drm_pvr_obj_array)DRM_PVR_OBJ_ARRAY(DRM_PVR_HEAP_COUNT,
+ heaps);
+
+ igt_pvr_ioctl_dev_query(fd, DRM_PVR_DEV_QUERY_HEAP_INFO_GET,
+ sizeof(heap_info_get), &heap_info_get, 0);
+
+ igt_assert(heap_info_get.heaps.count == DRM_PVR_HEAP_COUNT ||
+ heap_info_get.heaps.count == kernel_array_size);
+
+ /* Kernel should respect the user side array stride. */
+ igt_assert_eq(heap_info_get.heaps.stride, sizeof(*heaps));
+ }
+
+ igt_describe("Test validity of all heaps");
+ igt_subtest("heap-info-heaps-valid")
+ {
+ uint32_t heaps_count = 0;
+ struct drm_pvr_heap *heaps =
+ igt_pvr_get_heap_info(fd, &heaps_count);
+
+ igt_assert(heaps);
+
+ for (int heap_id = 0; heap_id < heaps_count; heap_id++) {
+ const uint64_t page_mask =
+ (1ull << heaps[heap_id].page_size_log2) - 1;
+
+ /* This heap isn't present for all devices. */
+ if (heap_id == (int)DRM_PVR_HEAP_RGNHDR)
+ continue;
+
+ igt_assert(heaps[heap_id].page_size_log2 == PVR_PAGE_SIZE_4K ||
+ heaps[heap_id].page_size_log2 == PVR_PAGE_SIZE_16K ||
+ heaps[heap_id].page_size_log2 == PVR_PAGE_SIZE_64K ||
+ heaps[heap_id].page_size_log2 == PVR_PAGE_SIZE_256K ||
+ heaps[heap_id].page_size_log2 == PVR_PAGE_SIZE_1M ||
+ heaps[heap_id].page_size_log2 == PVR_PAGE_SIZE_2M);
+
+ igt_assert_neq_u64(heaps[heap_id].size, 0);
+ igt_assert(!(heaps[heap_id].size & page_mask));
+ igt_assert(!(heaps[heap_id].base & page_mask));
+
+ igt_assert(heaps[heap_id].flags == 0);
+ }
+
+ free(heaps);
+ }
+
+ igt_fixture()
+ {
+ close(fd);
+ }
+}
--
2.43.0
next prev parent reply other threads:[~2026-07-17 9:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 9:18 [PATCH i-g-t v2 00/10] tests/imagination: Add initial test coverage for Imagination DRM driver Robert Mazur
2026-07-17 9:18 ` [PATCH i-g-t v2 01/10] tests/imagination: Add framework for Imagination tests Robert Mazur
2026-07-17 9:18 ` [PATCH i-g-t v2 02/10] tests/imagination: Add GEM mmap tests Robert Mazur
2026-07-17 9:18 ` [PATCH i-g-t v2 03/10] tests/imagination: Add DEV_QUERY tests Robert Mazur
2026-07-17 9:18 ` [PATCH i-g-t v2 04/10] tests/imagination: Add GPU ID test Robert Mazur
2026-07-17 9:18 ` Robert Mazur [this message]
2026-07-17 9:18 ` [PATCH i-g-t v2 06/10] tests/imagination: Add DEV_QUERY static data area tests Robert Mazur
2026-07-17 9:18 ` [PATCH i-g-t v2 07/10] tests/imagination: Add VM_CONTEXT tests Robert Mazur
2026-07-17 9:18 ` [PATCH i-g-t v2 08/10] tests/imagination: Add tests for free list and hwrt creation ioctls Robert Mazur
2026-07-17 9:18 ` [PATCH i-g-t v2 09/10] tests/imagination: Add DEV_QUERY quirks and enhancements tests Robert Mazur
2026-07-17 9:18 ` [PATCH i-g-t v2 10/10] tests/imagination: Add DEV_QUERY runtime_info tests Robert Mazur
2026-07-17 11:10 ` ✓ Xe.CI.BAT: success for tests/imagination: Add initial test coverage for Imagination DRM driver (rev2) Patchwork
2026-07-17 12:06 ` ✓ i915.CI.BAT: " Patchwork
2026-07-17 16:51 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-17 22:08 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717-test-imagination-add-support-v2-5-e1bf415adcee@imgtec.com \
--to=robert.mazur@imgtec.com \
--cc=alessio.belle@imgtec.com \
--cc=brajesh.gupta@imgtec.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=luigi.santivetti@imgtec.com \
--cc=sarah.walker@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox