From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29936C44507 for ; Fri, 17 Jul 2026 09:21:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CD8FD10F4C6; Fri, 17 Jul 2026 09:21:15 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=imgtec.com header.i=@imgtec.com header.b="PbDE4DbV"; dkim-atps=neutral Received: from mx07-00376f01.pphosted.com (mx07-00376f01.pphosted.com [185.132.180.163]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40B5F10F4C6 for ; Fri, 17 Jul 2026 09:18:58 +0000 (UTC) Received: from pps.filterd (m0168889.ppops.net [127.0.0.1]) by mx07-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66H7I4pV2913452 for ; Fri, 17 Jul 2026 10:18:56 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=dk201812; bh=v q0xtROCN6qiPD6Pq5S+pCmP8Nj3WQUcjU3PGtR2kZI=; b=PbDE4DbVO0M+eJcwN QPKnvZV2DVCxOD5GrBCIIX8EatZfOi3MZzbqCwIadOr+gvAGozBr+bCPP01OY760 /Fx+jpdLr51aOFEE4u3S9vjuF8aXQGlRzgaFjDLejrrMl3lhHQ6nb7V1R7v4PXLz GB3P66pV818XTCGEEIT7i0ssyzOE+sDLWhX0m8Dn1kW5DP52PXxDOCWogKSDSYTp eA25ti9Nlf/MOVjmmtx+dUf+TD7PAd8A1B8ovU5BGgGgL5xUCS8Ogy3vdK3i2nd+ Lcx06unGavHBIUuCsoivb5cOJt8/0x/oOM3Vzw72qzG5se6A3bEi/mc0KnTsXMWm Y+uAw== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx07-00376f01.pphosted.com (PPS) with ESMTPS id 4fbdwsnk14-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 17 Jul 2026 10:18:56 +0100 (BST) Received: from [127.0.1.1] (172.25.9.35) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Fri, 17 Jul 2026 10:18:55 +0100 From: Robert Mazur Date: Fri, 17 Jul 2026 11:18:21 +0200 Subject: [PATCH i-g-t v2 08/10] tests/imagination: Add tests for free list and hwrt creation ioctls MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <20260717-test-imagination-add-support-v2-8-e1bf415adcee@imgtec.com> References: <20260717-test-imagination-add-support-v2-0-e1bf415adcee@imgtec.com> In-Reply-To: <20260717-test-imagination-add-support-v2-0-e1bf415adcee@imgtec.com> To: CC: Alessio Belle , Luigi Santivetti , Brajesh Gupta , Robert Mazur , Sarah Walker X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784279928; l=18984; i=robert.mazur@imgtec.com; s=20260324; h=from:subject:message-id; bh=dVHof2eRms2fp5zJBv983ZqtXfaOb2+jJxRf3OiM3oE=; b=39+FMTZRiHPSiirT3rSGQgHCJsr35RlEV2N436FDUnWbP2NzGAFHogHsLHhLHLSdhOZNglZSD 7jqgYL3XaeoBKySTcGYOhWvidDzUHig4c9bhCrRxwILSXXOZ+gedbWH X-Developer-Key: i=robert.mazur@imgtec.com; a=ed25519; pk=X5uhazsNnVDpw/srawR3m7WOmgzFZXdecapAeML2ZgM= X-Originating-IP: [172.25.9.35] X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDA5MiBTYWx0ZWRfX5Oj4YhlC4bTH R0RkAJ43kzZCfQcfSsMTUz9BOOEH81H97uS1IryiEO/GnYVGr6ctt2hgLEJEzlK+06+OCTdbPCo jBzO1Y+jE2RGc9m3/az0gFfCixQVf4HtPcgPCXGSnNzLfpPTpyMOyqSOGxhGyMrgmSE5LKkVM7P 1oj4WIQ0u0RSt65VubqI1aRLmBmfz+E3K3C8g2bgSfXrc2HSxnhooEJQUPtdzY6t4CmTbSa2bEz Mj/M75ZNHrZ+e/XdWAXWZN47cHiZ8cWDPgzK/iyGSdkWoNb72w4PONkOFqeOMFV2ekZXYRgRsIS QTQcxnHRV+xwEWjFpGhVD1YSIXERm6vDUIz7BGosxRo10lmVS/D9xXyMN02jp4n+O8B8Xla3mDL 8+WHibBCYM2ZxeiE7O4Sbz45zMz7Waqag4rQIwe6sqiSHxtQvcBcYZ45Wxf6cloWVYNavWT2ON1 gkYzKIvJcleIf4Ic9TA== X-Proofpoint-ORIG-GUID: 2RMRNDjYAGS_DQX462fU_FsMBaWkfrhm X-Proofpoint-GUID: 2RMRNDjYAGS_DQX462fU_FsMBaWkfrhm X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDA5MiBTYWx0ZWRfXzj9Hs+FZ/seo tm4r3tidOcTHY9FMpJiUD16QnANWt8qbKtydxYShGsgqkPTbDXZ6bx55YN9LPLrYgDYvnhEekkE 5f2vnucuhPpL1TVCnLEMvrBF5Ejrj84= X-Authority-Analysis: v=2.4 cv=QbVWeMbv c=1 sm=1 tr=0 ts=6a59f380 cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=CNmLAE0vrksA:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=kQ-hrUj2-E3RCbRHssb7:22 a=7RYWX5rxfSByPNLylY2M:22 a=r_1tXGB3AAAA:8 a=FZU5aUeBoxhVD_5TVTsA:9 a=QEXdDO2ut3YA:10 a=t8nPyN_e6usw4ciXM-Pk:22 X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" From: Sarah Walker Add subtests for free list and HWRT creation/destruction ioctls, covering valid usage and error paths for invalid parameters. Signed-off-by: Sarah Walker Signed-off-by: Robert Mazur --- lib/igt_pvr.c | 75 ++++++++++++- lib/igt_pvr.h | 13 +++ tests/imagination/meson.build | 2 + tests/imagination/pvr_free_list.c | 218 ++++++++++++++++++++++++++++++++++++++ tests/imagination/pvr_hwrt.c | 168 +++++++++++++++++++++++++++++ 5 files changed, 475 insertions(+), 1 deletion(-) diff --git a/lib/igt_pvr.c b/lib/igt_pvr.c index a631c4ff2..704a5e2df 100644 --- a/lib/igt_pvr.c +++ b/lib/igt_pvr.c @@ -24,10 +24,11 @@ * tests. */ -uint32_t igt_pvr_ioctl_create_bo(int fd, size_t *size) +uint32_t igt_pvr_ioctl_create_bo_ex(int fd, size_t *size, uint64_t flags) { struct drm_pvr_ioctl_create_bo_args arg = { .size = *size, + .flags = flags, }; do_ioctl(fd, DRM_IOCTL_PVR_CREATE_BO, &arg); @@ -38,6 +39,12 @@ uint32_t igt_pvr_ioctl_create_bo(int fd, size_t *size) return arg.handle; } +uint32_t igt_pvr_ioctl_create_bo(int fd, size_t *size) +{ + return igt_pvr_ioctl_create_bo_ex(fd, size, + DRM_PVR_BO_ALLOW_CPU_USERSPACE_ACCESS); +} + off_t igt_pvr_ioctl_get_bo_mmap_offset(int fd, uint32_t handle) { struct drm_pvr_ioctl_get_bo_mmap_offset_args arg = { @@ -94,6 +101,19 @@ igt_pvr_get_heap_info(int fd, uint32_t *array_len_out) return heaps; } +struct drm_pvr_heap igt_pvr_find_general_heap(int fd) +{ + struct drm_pvr_heap *heaps = igt_pvr_get_heap_info(fd, NULL); + struct drm_pvr_heap general_heap; + + igt_assert(heaps); + + general_heap = heaps[DRM_PVR_HEAP_GENERAL]; + free(heaps); + + return general_heap; +} + struct drm_pvr_static_data_area * igt_pvr_get_static_data_areas(int fd, uint32_t *array_len_out) { @@ -139,3 +159,56 @@ void igt_pvr_ioctl_destroy_vm_context(int fd, uint32_t handle, int expect_err) else do_ioctl(fd, DRM_IOCTL_PVR_DESTROY_VM_CONTEXT, &args); } + +void igt_pvr_ioctl_vm_map(int fd, uint32_t vm_ctx_handle, uint32_t handle, + uint64_t device_addr, uint64_t offset, uint64_t size) +{ + struct drm_pvr_ioctl_vm_map_args arg = { + .vm_context_handle = vm_ctx_handle, + .flags = 0, + .device_addr = device_addr, + .handle = handle, + .offset = offset, + .size = size, + }; + + do_ioctl(fd, DRM_IOCTL_PVR_VM_MAP, &arg); +} + +void igt_pvr_ioctl_vm_unmap(int fd, uint32_t vm_ctx_handle, + uint64_t device_addr, uint64_t size) +{ + struct drm_pvr_ioctl_vm_unmap_args arg = { + .vm_context_handle = vm_ctx_handle, + .device_addr = device_addr, + .size = size, + }; + + do_ioctl(fd, DRM_IOCTL_PVR_VM_UNMAP, &arg); +} + +uint32_t igt_pvr_ioctl_create_free_list(int fd, uint32_t vm_ctx_handle, + uint64_t gpu_addr) +{ + struct drm_pvr_ioctl_create_free_list_args create_free_list_args = { + .free_list_gpu_addr = gpu_addr, + .initial_num_pages = 64, + .max_num_pages = 256, + .grow_num_pages = 16, + .grow_threshold = 50, + .vm_context_handle = vm_ctx_handle, + }; + + do_ioctl(fd, DRM_IOCTL_PVR_CREATE_FREE_LIST, &create_free_list_args); + + return create_free_list_args.handle; +} + +void igt_pvr_ioctl_destroy_free_list(int fd, uint32_t free_list_handle) +{ + struct drm_pvr_ioctl_destroy_free_list_args destroy_free_list_args = { + .handle = free_list_handle, + }; + + do_ioctl(fd, DRM_IOCTL_PVR_DESTROY_FREE_LIST, &destroy_free_list_args); +} diff --git a/lib/igt_pvr.h b/lib/igt_pvr.h index 3486a52d4..8d706c376 100644 --- a/lib/igt_pvr.h +++ b/lib/igt_pvr.h @@ -12,17 +12,30 @@ #include uint32_t igt_pvr_ioctl_create_bo(int fd, size_t *size); +uint32_t igt_pvr_ioctl_create_bo_ex(int fd, size_t *size, uint64_t flags); off_t igt_pvr_ioctl_get_bo_mmap_offset(int fd, uint32_t handle); struct drm_pvr_ioctl_dev_query_args igt_pvr_ioctl_dev_query(int fd, enum drm_pvr_dev_query type, uint64_t size, void *pointer, int expect_err); + struct drm_pvr_heap * igt_pvr_get_heap_info(int fd, uint32_t *array_len_out); +struct drm_pvr_heap igt_pvr_find_general_heap(int fd); + struct drm_pvr_static_data_area * igt_pvr_get_static_data_areas(int fd, uint32_t *array_len_out); uint32_t igt_pvr_ioctl_create_vm_context(int fd, int expect_err); void igt_pvr_ioctl_destroy_vm_context(int fd, uint32_t handle, int expect_err); +void igt_pvr_ioctl_vm_map(int fd, uint32_t vm_ctx_handle, uint32_t handle, + uint64_t device_addr, uint64_t offset, uint64_t size); +void igt_pvr_ioctl_vm_unmap(int fd, uint32_t vm_ctx_handle, + uint64_t device_addr, uint64_t size); + +uint32_t igt_pvr_ioctl_create_free_list(int fd, uint32_t vm_ctx_handle, + uint64_t gpu_addr); +void igt_pvr_ioctl_destroy_free_list(int fd, uint32_t free_list_handle); + #endif /* IGT_PVR_H */ diff --git a/tests/imagination/meson.build b/tests/imagination/meson.build index ffacce1fb..69ef0a8c6 100644 --- a/tests/imagination/meson.build +++ b/tests/imagination/meson.build @@ -1,7 +1,9 @@ pvr_progs = [ 'pvr_dev_query', + 'pvr_free_list', 'pvr_gem', 'pvr_gpu_info', 'pvr_heap_info', + 'pvr_hwrt', 'pvr_vm_context', ] diff --git a/tests/imagination/pvr_free_list.c b/tests/imagination/pvr_free_list.c new file mode 100644 index 000000000..eabf8d6a2 --- /dev/null +++ b/tests/imagination/pvr_free_list.c @@ -0,0 +1,218 @@ +// SPDX-License-Identifier: GPL-2.0 or MIT +/* Copyright (c) 2026 Imagination Technologies Ltd. All Rights Reserved */ + +#include "igt.h" +#include "igt_pvr.h" + +#include "pvr_drm.h" + +#include +#include +#include + +#define INVALID_ADDRESS 0xdeadbee0 +#define INVALID_HANDLE 0 + +static void build_create_free_list_args( + struct drm_pvr_ioctl_create_free_list_args *create_free_list_args, + uint32_t vm_ctx_handle, + uint64_t gpu_addr) +{ + memset(create_free_list_args, 0, sizeof(*create_free_list_args)); + create_free_list_args->free_list_gpu_addr = gpu_addr; + create_free_list_args->initial_num_pages = 32; + create_free_list_args->max_num_pages = 256; + create_free_list_args->grow_num_pages = 16; + create_free_list_args->grow_threshold = 50; + create_free_list_args->vm_context_handle = vm_ctx_handle; +} + +static void build_destroy_free_list_args( + struct drm_pvr_ioctl_destroy_free_list_args *destroy_free_list_args, + uint32_t handle) +{ + memset(destroy_free_list_args, 0, sizeof(*destroy_free_list_args)); + destroy_free_list_args->handle = handle; +} + +int igt_main() +{ + struct drm_pvr_ioctl_create_free_list_args create_free_list_args; + struct drm_pvr_ioctl_destroy_free_list_args destroy_free_list_args; + uint64_t gem_obj_gpu_addr; + uint32_t gem_obj_handle; + uint32_t vm_ctx_handle; + size_t size = 4096; + int fd; + + igt_fixture() + { + struct drm_pvr_heap general_heap_info; + + fd = drm_open_driver(DRIVER_POWERVR); + vm_ctx_handle = igt_pvr_ioctl_create_vm_context(fd, 0); + gem_obj_handle = + igt_pvr_ioctl_create_bo_ex(fd, &size, + DRM_PVR_BO_PM_FW_PROTECT); + general_heap_info = igt_pvr_find_general_heap(fd); + gem_obj_gpu_addr = general_heap_info.base; + + igt_pvr_ioctl_vm_map(fd, vm_ctx_handle, gem_obj_handle, + gem_obj_gpu_addr, 0, size); + } + + igt_describe("Test valid free list creation and destruction"); + igt_subtest("create-free-list") + { + build_create_free_list_args(&create_free_list_args, + vm_ctx_handle, gem_obj_gpu_addr); + do_ioctl(fd, DRM_IOCTL_PVR_CREATE_FREE_LIST, + &create_free_list_args); + + igt_assert_neq(create_free_list_args.handle, 0); + + build_destroy_free_list_args(&destroy_free_list_args, + create_free_list_args.handle); + do_ioctl(fd, DRM_IOCTL_PVR_DESTROY_FREE_LIST, + &destroy_free_list_args); + } + + igt_describe("Test free list destruction with bad padding"); + igt_subtest("destroy-free-list-bad-padding") + { + build_create_free_list_args(&create_free_list_args, + vm_ctx_handle, gem_obj_gpu_addr); + do_ioctl(fd, DRM_IOCTL_PVR_CREATE_FREE_LIST, + &create_free_list_args); + + igt_assert_neq(create_free_list_args.handle, 0); + + build_destroy_free_list_args(&destroy_free_list_args, + create_free_list_args.handle); + destroy_free_list_args._padding_4 = 1; + do_ioctl_err(fd, DRM_IOCTL_PVR_DESTROY_FREE_LIST, + &destroy_free_list_args, EINVAL); + + destroy_free_list_args._padding_4 = 0; + do_ioctl(fd, DRM_IOCTL_PVR_DESTROY_FREE_LIST, + &destroy_free_list_args); + } + + igt_describe("Test creation and destruction of multiple free lists"); + igt_subtest("create-multiple-free-lists") + { + uint32_t free_list_handles[2]; + + build_create_free_list_args(&create_free_list_args, + vm_ctx_handle, gem_obj_gpu_addr); + + do_ioctl(fd, DRM_IOCTL_PVR_CREATE_FREE_LIST, + &create_free_list_args); + free_list_handles[0] = create_free_list_args.handle; + do_ioctl(fd, DRM_IOCTL_PVR_CREATE_FREE_LIST, + &create_free_list_args); + free_list_handles[1] = create_free_list_args.handle; + + igt_assert_neq(free_list_handles[0], 0); + igt_assert_neq(free_list_handles[1], 0); + igt_assert_neq(free_list_handles[0], free_list_handles[1]); + + build_destroy_free_list_args(&destroy_free_list_args, + free_list_handles[1]); + do_ioctl(fd, DRM_IOCTL_PVR_DESTROY_FREE_LIST, + &destroy_free_list_args); + build_destroy_free_list_args(&destroy_free_list_args, + free_list_handles[0]); + do_ioctl(fd, DRM_IOCTL_PVR_DESTROY_FREE_LIST, + &destroy_free_list_args); + } + + igt_describe("Test free list creation with invalid object address"); + igt_subtest("invalid-free-list-object-addr") + { + build_create_free_list_args(&create_free_list_args, + vm_ctx_handle, 0); + do_ioctl_err(fd, DRM_IOCTL_PVR_CREATE_FREE_LIST, + &create_free_list_args, EINVAL); + } + + igt_describe("Test free list creation with initial pages greater than max pages"); + igt_subtest("initial-pages-greater-than-max") + { + build_create_free_list_args(&create_free_list_args, + vm_ctx_handle, gem_obj_gpu_addr); + create_free_list_args.initial_num_pages = + create_free_list_args.max_num_pages + 1; + do_ioctl_err(fd, DRM_IOCTL_PVR_CREATE_FREE_LIST, + &create_free_list_args, EINVAL); + } + + igt_describe("Test free list creation with grow pages greater than max pages"); + igt_subtest("grow-pages-greater-than-max") + { + build_create_free_list_args(&create_free_list_args, + vm_ctx_handle, gem_obj_gpu_addr); + create_free_list_args.grow_num_pages = + create_free_list_args.max_num_pages + 1; + do_ioctl_err(fd, DRM_IOCTL_PVR_CREATE_FREE_LIST, + &create_free_list_args, EINVAL); + } + + igt_describe("Test free list creation with invalid grow threshold"); + igt_subtest("invalid-grow-threshold") + { + build_create_free_list_args(&create_free_list_args, + vm_ctx_handle, gem_obj_gpu_addr); + create_free_list_args.grow_threshold = 101; + do_ioctl_err(fd, DRM_IOCTL_PVR_CREATE_FREE_LIST, + &create_free_list_args, EINVAL); + } + + igt_describe("Test free list creation with zero max pages"); + igt_subtest("zero-max-pages") + { + build_create_free_list_args(&create_free_list_args, + vm_ctx_handle, gem_obj_gpu_addr); + create_free_list_args.initial_num_pages = 0; + create_free_list_args.max_num_pages = 0; + create_free_list_args.grow_num_pages = 0; + do_ioctl_err(fd, DRM_IOCTL_PVR_CREATE_FREE_LIST, + &create_free_list_args, EINVAL); + } + + igt_describe("Test free list creation with zero grow pages and initial pages less than max pages"); + igt_subtest("zero-grow-pages-initial-less-than-max") + { + build_create_free_list_args(&create_free_list_args, + vm_ctx_handle, gem_obj_gpu_addr); + create_free_list_args.grow_num_pages = 0; + do_ioctl_err(fd, DRM_IOCTL_PVR_CREATE_FREE_LIST, + &create_free_list_args, EINVAL); + } + + igt_describe("Test free list creation with zero grow pages and initial pages equal to max pages"); + igt_subtest("zero-grow-pages-initial-equals-max") + { + build_create_free_list_args(&create_free_list_args, + vm_ctx_handle, gem_obj_gpu_addr); + create_free_list_args.initial_num_pages = + create_free_list_args.max_num_pages; + create_free_list_args.grow_num_pages = 0; + do_ioctl(fd, DRM_IOCTL_PVR_CREATE_FREE_LIST, + &create_free_list_args); + + igt_assert_neq(create_free_list_args.handle, 0); + + destroy_free_list_args.handle = create_free_list_args.handle; + do_ioctl(fd, DRM_IOCTL_PVR_DESTROY_FREE_LIST, + &destroy_free_list_args); + } + + igt_fixture() + { + igt_pvr_ioctl_vm_unmap(fd, vm_ctx_handle, gem_obj_gpu_addr, size); + gem_close(fd, gem_obj_handle); + igt_pvr_ioctl_destroy_vm_context(fd, vm_ctx_handle, 0); + close(fd); + } +} diff --git a/tests/imagination/pvr_hwrt.c b/tests/imagination/pvr_hwrt.c new file mode 100644 index 000000000..1b68df3e9 --- /dev/null +++ b/tests/imagination/pvr_hwrt.c @@ -0,0 +1,168 @@ +// SPDX-License-Identifier: GPL-2.0 or MIT +/* Copyright (c) 2026 Imagination Technologies Ltd. All Rights Reserved */ + +#include "igt.h" +#include "igt_pvr.h" + +#include "pvr_drm.h" + +#include +#include +#include + +#define INVALID_ADDRESS 0xdeadbee0 + +static void build_create_hwrt_args( + struct drm_pvr_ioctl_create_hwrt_dataset_args *create_hwrt_args, + const struct drm_pvr_create_hwrt_geom_data_args *geom_data_args, + const struct drm_pvr_create_hwrt_rt_data_args *rt_data_args, + uint32_t *free_list_handles, + uint32_t num_rt_data, + uint32_t num_free_lists) +{ + memset(create_hwrt_args, 0, sizeof(*create_hwrt_args)); + memcpy(&create_hwrt_args->geom_data_args, geom_data_args, + sizeof(*geom_data_args)); + + for (uint32_t i = 0; i < num_rt_data; i++) { + memcpy(&create_hwrt_args->rt_data_args[i], rt_data_args, + sizeof(*rt_data_args) * num_rt_data); + } + + for (uint32_t i = 0; i < num_free_lists; i++) + create_hwrt_args->free_list_handles[i] = free_list_handles[i]; + + create_hwrt_args->width = 256; + create_hwrt_args->height = 256; + create_hwrt_args->samples = 1; + create_hwrt_args->layers = 1; + create_hwrt_args->region_header_size = 64; +} + +static void build_destroy_hwrt_args( + struct drm_pvr_ioctl_destroy_hwrt_dataset_args *destroy_hwrt_args, + uint32_t handle) +{ + memset(destroy_hwrt_args, 0, sizeof(*destroy_hwrt_args)); + destroy_hwrt_args->handle = handle; +} + +int igt_main() +{ + struct drm_pvr_ioctl_create_hwrt_dataset_args create_hwrt_args; + struct drm_pvr_create_hwrt_geom_data_args geom_data_args = {0}; + struct drm_pvr_create_hwrt_rt_data_args rt_data_args[2] = {0}; + struct drm_pvr_ioctl_destroy_hwrt_dataset_args destroy_hwrt_args; + + const uint32_t num_free_lists = + ARRAY_SIZE(create_hwrt_args.free_list_handles); + uint32_t free_list_handles[num_free_lists]; + uint32_t gem_obj_handle; + uint32_t gem_obj_handle_ml; + uint32_t vm_ctx_handle; + const uint32_t num_rt_data = ARRAY_SIZE(create_hwrt_args.rt_data_args); + uint64_t gem_obj_gpu_addr; + uint64_t gem_obj_gpu_addr_ml; + size_t size = 2 << 20; + int fd; + + igt_fixture() + { + struct drm_pvr_heap general_heap_info; + + fd = drm_open_driver(DRIVER_POWERVR); + general_heap_info = igt_pvr_find_general_heap(fd); + vm_ctx_handle = igt_pvr_ioctl_create_vm_context(fd, 0); + + gem_obj_gpu_addr = general_heap_info.base; + gem_obj_handle = + igt_pvr_ioctl_create_bo_ex(fd, &size, + DRM_PVR_BO_PM_FW_PROTECT); + igt_pvr_ioctl_vm_map(fd, vm_ctx_handle, gem_obj_handle, + gem_obj_gpu_addr, 0, size); + + for (int i = 0; i < num_free_lists; i++) + free_list_handles[i] = + igt_pvr_ioctl_create_free_list(fd, + vm_ctx_handle, + gem_obj_gpu_addr); + + gem_obj_gpu_addr_ml = general_heap_info.base + size; + gem_obj_handle_ml = + igt_pvr_ioctl_create_bo_ex(fd, &size, + DRM_PVR_BO_PM_FW_PROTECT); + igt_pvr_ioctl_vm_map(fd, vm_ctx_handle, gem_obj_handle_ml, + gem_obj_gpu_addr_ml, 0, size); + + for (int i = 0; i < num_rt_data; i++) + rt_data_args[i].pm_mlist_dev_addr = gem_obj_gpu_addr_ml; + } + + igt_describe("Test valid HWRT creation and destruction"); + igt_subtest("create-hwrt") + { + build_create_hwrt_args(&create_hwrt_args, &geom_data_args, + rt_data_args, free_list_handles, + num_rt_data, num_free_lists); + do_ioctl(fd, DRM_IOCTL_PVR_CREATE_HWRT_DATASET, &create_hwrt_args); + + igt_assert_neq(create_hwrt_args.handle, 0); + + build_destroy_hwrt_args(&destroy_hwrt_args, create_hwrt_args.handle); + do_ioctl(fd, DRM_IOCTL_PVR_DESTROY_HWRT_DATASET, &destroy_hwrt_args); + } + + igt_describe("Test HWRT creation with bad padding"); + igt_subtest("destroy-hwrt-bad-padding") + { + build_create_hwrt_args(&create_hwrt_args, &geom_data_args, + rt_data_args, free_list_handles, + num_rt_data, num_free_lists); + do_ioctl(fd, DRM_IOCTL_PVR_CREATE_HWRT_DATASET, &create_hwrt_args); + + igt_assert_neq(create_hwrt_args.handle, 0); + + build_destroy_hwrt_args(&destroy_hwrt_args, create_hwrt_args.handle); + destroy_hwrt_args._padding_4 = 1; + do_ioctl_err(fd, DRM_IOCTL_PVR_DESTROY_HWRT_DATASET, &destroy_hwrt_args, + EINVAL); + + destroy_hwrt_args._padding_4 = 0; + do_ioctl(fd, DRM_IOCTL_PVR_DESTROY_HWRT_DATASET, &destroy_hwrt_args); + } + + igt_describe("Test HWRT creation with invalid free list handle"); + igt_subtest("invalid-free-list-handle") + { + build_create_hwrt_args(&create_hwrt_args, &geom_data_args, + rt_data_args, free_list_handles, + num_rt_data, num_free_lists); + create_hwrt_args.free_list_handles[0] = INVALID_ADDRESS; + do_ioctl_err(fd, DRM_IOCTL_PVR_CREATE_HWRT_DATASET, + &create_hwrt_args, EINVAL); + } + + igt_describe("Test HWRT creation with missing free list"); + igt_subtest("missing-free-list") + { + build_create_hwrt_args(&create_hwrt_args, &geom_data_args, + rt_data_args, free_list_handles, + num_rt_data, num_free_lists); + create_hwrt_args.free_list_handles[0] = 0; + do_ioctl_err(fd, DRM_IOCTL_PVR_CREATE_HWRT_DATASET, + &create_hwrt_args, EINVAL); + } + + igt_fixture() + { + for (int i = 0; i < num_free_lists; i++) + igt_pvr_ioctl_destroy_free_list(fd, free_list_handles[i]); + + igt_pvr_ioctl_vm_unmap(fd, vm_ctx_handle, gem_obj_gpu_addr, + size); + gem_close(fd, gem_obj_handle); + igt_pvr_ioctl_destroy_vm_context(fd, vm_ctx_handle, 0); + + close(fd); + } +} -- 2.43.0