Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Mazur <robert.mazur@imgtec.com>
To: <igt-dev@lists.freedesktop.org>
Cc: Alessio Belle <alessio.belle@imgtec.com>,
	Luigi Santivetti <luigi.santivetti@imgtec.com>,
	Brajesh Gupta <brajesh.gupta@imgtec.com>,
	Robert Mazur <robert.mazur@imgtec.com>,
	Donald Robson <donald.robson@imgtec.com>
Subject: [PATCH i-g-t v3 07/10] tests/imagination: Add VM_CONTEXT tests
Date: Fri, 17 Jul 2026 16:21:39 +0200	[thread overview]
Message-ID: <20260717-test-imagination-add-support-v3-7-ce69f9ad330c@imgtec.com> (raw)
In-Reply-To: <20260717-test-imagination-add-support-v3-0-ce69f9ad330c@imgtec.com>

From: Donald Robson <donald.robson@imgtec.com>

Add subtests for VM context create and destroy ioctls,
including invalid padding and bad handle error paths.

Signed-off-by: Donald Robson <donald.robson@imgtec.com>
Signed-off-by: Robert Mazur <robert.mazur@imgtec.com>
---
 lib/igt_pvr.c                      | 43 +++++++++++++++++++++
 lib/igt_pvr.h                      |  3 ++
 tests/imagination/meson.build      |  1 +
 tests/imagination/pvr_vm_context.c | 78 ++++++++++++++++++++++++++++++++++++++
 4 files changed, 125 insertions(+)

diff --git a/lib/igt_pvr.c b/lib/igt_pvr.c
index 70fc71388..b97349044 100644
--- a/lib/igt_pvr.c
+++ b/lib/igt_pvr.c
@@ -164,3 +164,46 @@ igt_pvr_get_static_data_areas(int fd, uint32_t *array_len_out)
 
 	return sdas;
 }
+
+/**
+ * igt_pvr_ioctl_create_vm_context:
+ * @fd: The file descriptor of the DRM device.
+ * @expect_err: Expected error code, or 0 if no error is expected.
+ *
+ * Function to create a VM context.
+ *
+ * Returns: The handle of the created VM context.
+ */
+uint32_t igt_pvr_ioctl_create_vm_context(int fd, int expect_err)
+{
+	struct drm_pvr_ioctl_create_vm_context_args args = {0};
+
+	if (expect_err)
+		do_ioctl_err(fd, DRM_IOCTL_PVR_CREATE_VM_CONTEXT, &args,
+			     expect_err);
+	else
+		do_ioctl(fd, DRM_IOCTL_PVR_CREATE_VM_CONTEXT, &args);
+
+	return args.handle;
+}
+
+/**
+ * igt_pvr_ioctl_destroy_vm_context:
+ * @fd: The file descriptor of the DRM device.
+ * @handle: The handle of the VM context to destroy.
+ * @expect_err: Expected error code, or 0 if no error is expected.
+ *
+ * Function to destroy a VM context.
+ */
+void igt_pvr_ioctl_destroy_vm_context(int fd, uint32_t handle, int expect_err)
+{
+	struct drm_pvr_ioctl_destroy_vm_context_args args = {
+		.handle = handle,
+	};
+
+	if (expect_err)
+		do_ioctl_err(fd, DRM_IOCTL_PVR_DESTROY_VM_CONTEXT, &args,
+			     expect_err);
+	else
+		do_ioctl(fd, DRM_IOCTL_PVR_DESTROY_VM_CONTEXT, &args);
+}
diff --git a/lib/igt_pvr.h b/lib/igt_pvr.h
index 19909480b..871c8a48e 100644
--- a/lib/igt_pvr.h
+++ b/lib/igt_pvr.h
@@ -21,4 +21,7 @@ igt_pvr_get_heap_info(int fd, uint32_t *array_len_out);
 struct drm_pvr_static_data_area *
 igt_pvr_get_static_data_areas(int fd, uint32_t *array_len_out);
 
+uint32_t igt_pvr_ioctl_create_vm_context(int fd, int expect_err);
+void igt_pvr_ioctl_destroy_vm_context(int fd, uint32_t handle, int expect_err);
+
 #endif /* IGT_PVR_H */
diff --git a/tests/imagination/meson.build b/tests/imagination/meson.build
index fc24d0220..ffacce1fb 100644
--- a/tests/imagination/meson.build
+++ b/tests/imagination/meson.build
@@ -2,6 +2,7 @@ pvr_progs = [ 'pvr_dev_query',
 	      'pvr_gem',
 	      'pvr_gpu_info',
 	      'pvr_heap_info',
+	      'pvr_vm_context',
 	    ]
 
 pvr_deps = test_deps
diff --git a/tests/imagination/pvr_vm_context.c b/tests/imagination/pvr_vm_context.c
new file mode 100644
index 000000000..84e9d39a3
--- /dev/null
+++ b/tests/imagination/pvr_vm_context.c
@@ -0,0 +1,78 @@
+// SPDX-License-Identifier: GPL-2.0 or MIT
+/* Copyright (c) 2026 Imagination Technologies Ltd. All Rights Reserved */
+
+#include <linux/errno.h>
+#include <stddef.h>
+#include <stdint.h>
+#include <unistd.h>
+
+#include "igt.h"
+#include "igt_pvr.h"
+
+#include "pvr_drm.h"
+
+int igt_main()
+{
+	int fd;
+
+	igt_fixture()
+	{
+		fd = drm_open_driver(DRIVER_POWERVR);
+	}
+
+	igt_describe("Test valid VM context creation and destruction");
+	igt_subtest("create-and-destroy-vm-ctx")
+	{
+		const uint32_t handle = igt_pvr_ioctl_create_vm_context(fd, 0);
+
+		igt_pvr_ioctl_destroy_vm_context(fd, handle, 0);
+	}
+
+	igt_describe("Test VM context creation with bad padding");
+	igt_subtest("create-vm-ctx-bad-padding")
+	{
+		struct drm_pvr_ioctl_create_vm_context_args args = {
+			._padding_4 = 1,
+		};
+
+		do_ioctl_err(fd, DRM_IOCTL_PVR_CREATE_VM_CONTEXT, &args, EINVAL);
+	}
+
+	igt_describe("Test VM context destruction with bad padding");
+	igt_subtest("destroy-vm-ctx-bad-padding")
+	{
+		struct drm_pvr_ioctl_destroy_vm_context_args args = {
+			._padding_4 = 1,
+		};
+
+		do_ioctl_err(fd, DRM_IOCTL_PVR_DESTROY_VM_CONTEXT, &args, EINVAL);
+	}
+
+	igt_describe("Test VM context destruction with bad handle");
+	igt_subtest("destroy-vm-ctx-bad-handle")
+	{
+		struct drm_pvr_ioctl_destroy_vm_context_args args = {
+			.handle = 0xbad6bad6,
+		};
+
+		do_ioctl_err(fd, DRM_IOCTL_PVR_DESTROY_VM_CONTEXT, &args, EINVAL);
+	}
+
+	igt_describe("Test VM context destruction with handle that is not a VM context");
+	igt_subtest("destroy-vm-ctx-handle-is-not-vm-ctx")
+	{
+		size_t size = 4096;
+		const uint32_t bo_handle = igt_pvr_ioctl_create_bo(fd, &size);
+		struct drm_pvr_ioctl_destroy_vm_context_args args = {
+			.handle = bo_handle,
+		};
+
+		do_ioctl_err(fd, DRM_IOCTL_PVR_DESTROY_VM_CONTEXT, &args, EINVAL);
+		gem_close(fd, bo_handle);
+	}
+
+	igt_fixture()
+	{
+		drm_close_driver(fd);
+	}
+}

-- 
2.43.0


  parent reply	other threads:[~2026-07-17 14:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 14:21 [PATCH i-g-t v3 00/10] tests/imagination: Add initial test coverage for Imagination DRM driver Robert Mazur
2026-07-17 14:21 ` [PATCH i-g-t v3 01/10] tests/imagination: Add framework for Imagination tests Robert Mazur
2026-07-22 13:44   ` Kamil Konieczny
     [not found]     ` <3a08b2b97b01954f2e6afef9244c05680d33e98d.camel@imgtec.com>
2026-07-27 18:18       ` [EXTERNAL] " Kamil Konieczny
2026-07-17 14:21 ` [PATCH i-g-t v3 02/10] tests/imagination: Add GEM mmap tests Robert Mazur
2026-07-22 13:46   ` Kamil Konieczny
2026-07-17 14:21 ` [PATCH i-g-t v3 03/10] tests/imagination: Add DEV_QUERY tests Robert Mazur
2026-07-22 14:12   ` Kamil Konieczny
2026-07-17 14:21 ` [PATCH i-g-t v3 04/10] tests/imagination: Add GPU ID test Robert Mazur
2026-07-22 14:13   ` Kamil Konieczny
2026-07-17 14:21 ` [PATCH i-g-t v3 05/10] tests/imagination: Add DEV_QUERY heap info tests Robert Mazur
2026-07-22 14:14   ` Kamil Konieczny
2026-07-17 14:21 ` [PATCH i-g-t v3 06/10] tests/imagination: Add DEV_QUERY static data area tests Robert Mazur
2026-07-22 14:21   ` Kamil Konieczny
2026-07-17 14:21 ` Robert Mazur [this message]
2026-07-22 14:22   ` [PATCH i-g-t v3 07/10] tests/imagination: Add VM_CONTEXT tests Kamil Konieczny
2026-07-17 14:21 ` [PATCH i-g-t v3 08/10] tests/imagination: Add tests for free list and hwrt creation ioctls Robert Mazur
2026-07-22 14:41   ` Kamil Konieczny
2026-07-17 14:21 ` [PATCH i-g-t v3 09/10] tests/imagination: Add DEV_QUERY quirks and enhancements tests Robert Mazur
2026-07-22 14:43   ` Kamil Konieczny
2026-07-17 14:21 ` [PATCH i-g-t v3 10/10] tests/imagination: Add DEV_QUERY runtime_info tests Robert Mazur
2026-07-22 14:45   ` Kamil Konieczny
2026-07-17 21:16 ` ✓ i915.CI.BAT: success for tests/imagination: Add initial test coverage for Imagination DRM driver (rev3) Patchwork
2026-07-17 21:20 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-18  4:13 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-18 10:57 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260717-test-imagination-add-support-v3-7-ce69f9ad330c@imgtec.com \
    --to=robert.mazur@imgtec.com \
    --cc=alessio.belle@imgtec.com \
    --cc=brajesh.gupta@imgtec.com \
    --cc=donald.robson@imgtec.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=luigi.santivetti@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox