From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: igt-dev@lists.freedesktop.org, Ashutosh Dixit <ashutosh.dixit@intel.com>
Subject: [PATCH 1/4] tests/intel/xe_oa: Allow disabling load helper from command line
Date: Fri, 17 Jul 2026 14:00:29 -0700 [thread overview]
Message-ID: <20260717210027.2008255-7-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20260717210027.2008255-6-umesh.nerlige.ramappa@intel.com>
In some test runs, it is useful to assess behavior with and without load
helper. Add a command line switch to disable the load helper if needed.
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
tests/intel/xe_oa.c | 29 +++++++++++++++++++++++++++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
index 68c7537d3888..e7e4f5601b61 100644
--- a/tests/intel/xe_oa.c
+++ b/tests/intel/xe_oa.c
@@ -1798,10 +1798,14 @@ static struct load_helper {
bool exit;
struct igt_helper_process igt_proc;
struct intel_buf src, dst;
+ bool disabled;
} lh = { 0, };
static void load_helper_signal_handler(int sig)
{
+ if (lh.disabled)
+ return;
+
if (sig == SIGUSR2)
lh.load = lh.load == LOW ? HIGH : LOW;
else
@@ -1812,6 +1816,9 @@ static void load_helper_set_load(enum load load)
{
igt_assert(lh.igt_proc.running);
+ if (lh.disabled)
+ return;
+
if (lh.load == load)
return;
@@ -1821,6 +1828,9 @@ static void load_helper_set_load(enum load load)
static void load_helper_run(enum load load)
{
+ if (lh.disabled)
+ return;
+
if (!render_copy)
return;
@@ -1856,6 +1866,9 @@ static void load_helper_run(enum load load)
static void load_helper_stop(void)
{
+ if (lh.disabled)
+ return;
+
if (!render_copy)
return;
@@ -1865,6 +1878,9 @@ static void load_helper_stop(void)
static void load_helper_init(void)
{
+ if (lh.disabled)
+ return;
+
if (!render_copy) {
igt_info("Running test without render_copy\n");
return;
@@ -1884,6 +1900,9 @@ static void load_helper_init(void)
static void load_helper_fini(void)
{
+ if (lh.disabled)
+ return;
+
if (!render_copy)
return;
@@ -4981,6 +5000,10 @@ static int opt_handler(int opt, int opt_index, void *data)
oa_trace = true;
igt_debug("Trace enabled\n");
break;
+ case 'd':
+ lh.disabled = true;
+ igt_info("Load helper disabled\n");
+ break;
default:
return IGT_OPT_HANDLER_ERROR;
}
@@ -4989,15 +5012,17 @@ static int opt_handler(int opt, int opt_index, void *data)
}
static const char *help_str = " --trace | -t\t\tEnable ftrace\n"
- " --trace_buf_size_mb | -b\t\tSet ftrace buffer size in MB (default = 1, min = 1, max = 20)\n";
+ " --trace_buf_size_mb | -b\t\tSet ftrace buffer size in MB (default = 1, min = 1, max = 20)\n"
+ " --disable-load-helper | -d\t\tDisable load helper\n";
static struct option long_options[] = {
{"trace", 0, 0, 't'},
{"trace_buf_size_mb", 0, 0, 'b'},
+ {"disable-load-helper", 0, 0, 'd'},
{ NULL, 0, 0, 0 }
};
-int igt_main_args("b:t", long_options, help_str, opt_handler, NULL)
+int igt_main_args("b:td", long_options, help_str, opt_handler, NULL)
{
const struct sync_section {
const char *name;
--
2.51.0
next prev parent reply other threads:[~2026-07-17 21:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 21:00 [PATCH 0/4] Update some OA tests Umesh Nerlige Ramappa
2026-07-17 21:00 ` Umesh Nerlige Ramappa [this message]
2026-07-20 19:37 ` [PATCH 1/4] tests/intel/xe_oa: Allow disabling load helper from command line Dixit, Ashutosh
2026-07-17 21:00 ` [PATCH 2/4] tests/intel/xe_oa: Do not assume OA buffer is prefilled with zeroes Umesh Nerlige Ramappa
2026-07-20 19:42 ` Dixit, Ashutosh
2026-07-21 17:19 ` Umesh Nerlige Ramappa
2026-07-17 21:00 ` [PATCH 3/4] tests/intel/xe_oa: Enable capture just prior to reading OA data Umesh Nerlige Ramappa
2026-07-20 20:22 ` Dixit, Ashutosh
2026-07-17 21:00 ` [PATCH 4/4] tests/intel/xe_oa: Cleanup blocking and polling tests Umesh Nerlige Ramappa
2026-07-20 21:08 ` Dixit, Ashutosh
2026-07-21 17:26 ` Umesh Nerlige Ramappa
2026-07-17 22:49 ` ✓ Xe.CI.BAT: success for Update some OA tests Patchwork
2026-07-17 23:08 ` ✓ i915.CI.BAT: " Patchwork
2026-07-18 5:41 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-18 14:11 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717210027.2008255-7-umesh.nerlige.ramappa@intel.com \
--to=umesh.nerlige.ramappa@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox