From: Sowmiya S <sowmiya.s@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: swati2.sharma@intel.com, santhosh.reddy.guddati@intel.com,
Sowmiya S <sowmiya.s@intel.com>
Subject: [PATCH i-g-t v2 1/2] lib/igt_kms: Add platform-specific joiner exception mode handling
Date: Tue, 28 Jul 2026 11:30:02 +0530 [thread overview]
Message-ID: <20260728060003.392870-2-sowmiya.s@intel.com> (raw)
In-Reply-To: <20260728060003.392870-1-sowmiya.s@intel.com>
On NVL (display_ver=35), a higher max_dotclock causes modes like
6144x3456@60 to pass the standard igt_bigjoiner_possible() checks,
yet the kernel still enables joiner for them. Introduce per-platform
exception mode lists (e.g. nvl_joiner_exception_modes[]) dispatched
via novalake check in a new mode_needs_joiner_exception() helper, and
wire it into igt_bigjoiner_possible().
v2: Replace with display version and add FIXME comments (Santhosh)
Signed-off-by: Sowmiya S <sowmiya.s@intel.com>
---
lib/igt_kms.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 60 insertions(+), 1 deletion(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 5dd4b0c14..d591e696d 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -7065,6 +7065,60 @@ int intel_get_max_pipe_hdisplay(int drm_fd)
HDISPLAY_5K_PER_PIPE;
}
+struct joiner_mode_exception {
+ uint16_t hdisplay, vdisplay;
+ uint32_t clock;
+};
+
+static bool match_joiner_exception(drmModeModeInfo *mode,
+ const struct joiner_mode_exception *list,
+ int count)
+{
+ for (int i = 0; i < count; i++) {
+ if (mode->hdisplay == list[i].hdisplay &&
+ mode->vdisplay == list[i].vdisplay &&
+ mode->clock == list[i].clock)
+ return true;
+ }
+
+ return false;
+}
+
+/*
+ * TODO: IGT cannot compute the DSC bubble overhead the driver adds to the
+ * effective pixel rate, since it cannot estimate the DSC parameters -
+ * whether DSC is used and how many slices. On NVL this lets modes like
+ * 6144x3456@60 pass igt_bigjoiner_possible()'s clock/hdisplay checks,
+ * yet the kernel still enables bigjoiner for them.
+ *
+ * Add mode_needs_joiner_exception() as a stopgap.
+ */
+static const struct joiner_mode_exception nvl_joiner_exception_modes[] = {
+ { 6144, 3456, 1413390 }, /* 6144x3456@60Hz */
+};
+
+/*
+ * mode_needs_joiner_exception - check if a mode requires joiner via explicit exception
+ * @drm_fd: drm file descriptor
+ * @mode: libdrm mode
+ *
+ * On some platforms, a higher max_dotclock means certain modes won't trigger
+ * the standard clock or hdisplay checks even though the kernel enables joiner
+ * for them. Each platform has its own exception list.
+ *
+ * Returns: True if the mode is a known joiner exception, else False.
+ */
+static bool mode_needs_joiner_exception(int drm_fd, drmModeModeInfo *mode)
+{
+ unsigned int disp_ver = intel_display_ver(intel_get_drm_devid(drm_fd));
+
+ if (disp_ver == 35) /* NVL */
+ return match_joiner_exception(mode, nvl_joiner_exception_modes,
+ ARRAY_SIZE(nvl_joiner_exception_modes));
+
+ return false;
+}
+
/**
* igt_bigjoiner_possible:
* @drm_fd: drm file descriptor
@@ -7079,7 +7133,12 @@ int intel_get_max_pipe_hdisplay(int drm_fd)
*/
bool igt_bigjoiner_possible(int drm_fd, drmModeModeInfo *mode, int max_dotclock)
{
- return (mode->hdisplay > intel_get_max_pipe_hdisplay(drm_fd) ||
+ /**
+ * FIXME: remove mode_needs_joiner_exception() once IGT can estimate
+ * DSC parameters accurately
+ */
+ return (mode_needs_joiner_exception(drm_fd, mode) ||
+ mode->hdisplay > intel_get_max_pipe_hdisplay(drm_fd) ||
mode->clock > max_dotclock);
}
--
2.51.0
next prev parent reply other threads:[~2026-07-28 6:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 6:00 [PATCH i-g-t v2 0/2] Add platform-specific joiner exception mode handling Sowmiya S
2026-07-28 6:00 ` Sowmiya S [this message]
2026-07-28 6:00 ` [PATCH i-g-t v2 2/2] lib/igt_kms: Skip joiner exception modes in boundary non-joiner search Sowmiya S
2026-07-28 6:44 ` ✓ Xe.CI.BAT: success for Add platform-specific joiner exception mode handling (rev2) Patchwork
2026-07-28 6:54 ` ✗ i915.CI.BAT: failure " Patchwork
2026-07-28 8:15 ` ✓ Xe.CI.FULL: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728060003.392870-2-sowmiya.s@intel.com \
--to=sowmiya.s@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=santhosh.reddy.guddati@intel.com \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox