Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sowmiya S <sowmiya.s@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, kunal1.joshi@intel.com,
	Sowmiya S <sowmiya.s@intel.com>
Subject: [PATCH i-g-t v3 2/3] tests/intel/kms_dp_linktrain_fallback: fix MST traversal state leak between subtests
Date: Wed,  5 Aug 2026 14:14:26 +0530	[thread overview]
Message-ID: <20260805084428.708501-3-sowmiya.s@intel.com> (raw)
In-Reply-To: <20260805084428.708501-1-sowmiya.s@intel.com>

traversed_mst_output_count is file-static and was never reset between
subtests. In a full-binary run the count from dp-fallback causes
setup_mst_outputs() to skip all MST outputs in subsequent subtests.

Reset it at the top of run_lt_fallback_test(). The DSC path never
reaches setup_mst_outputs() so run_dsc_sst_fallaback_test() does not
need the reset.

Signed-off-by: Sowmiya S <sowmiya.s@intel.com>
---
 tests/intel/kms_dp_linktrain_fallback.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/intel/kms_dp_linktrain_fallback.c b/tests/intel/kms_dp_linktrain_fallback.c
index 115183d2d..44b875ab9 100644
--- a/tests/intel/kms_dp_linktrain_fallback.c
+++ b/tests/intel/kms_dp_linktrain_fallback.c
@@ -431,6 +431,13 @@ static bool run_lt_fallback_test(data_t *data)
 	bool ran = false;
 	igt_output_t *output;
 
+	/*
+	 * Reset per invocation so MST traversal state from a previous subtest
+	 * (e.g. dp-fallback followed by dsc-fallback) doesn't leak and cause
+	 * MST siblings to be silently skipped as "already visited".
+	 */
+	traversed_mst_output_count = 0;
+
 	for_each_connected_output(&data->display, output) {
 		data->output = output;
 
-- 
2.51.0


  parent reply	other threads:[~2026-08-05  8:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-05  8:44 [PATCH i-g-t v3 0/3] kms_dp_linktrain_fallback: Add UHBR-to-HBR fallback subtest Sowmiya S
2026-08-05  8:44 ` [PATCH i-g-t v3 1/3] lib/i915/i915_dp: add UHBR helpers and const-correct set_link_params Sowmiya S
2026-08-10  4:39   ` Joshi, Kunal1
2026-08-05  8:44 ` Sowmiya S [this message]
2026-08-10  4:53   ` [PATCH i-g-t v3 2/3] tests/intel/kms_dp_linktrain_fallback: fix MST traversal state leak between subtests Joshi, Kunal1
2026-08-10  6:56     ` S, Sowmiya
2026-08-05  8:44 ` [PATCH i-g-t v3 3/3] tests/intel/kms_dp_linktrain_fallback: Add UHBR-to-HBR fallback subtest Sowmiya S
2026-08-05 23:05 ` ✓ Xe.CI.BAT: success for kms_dp_linktrain_fallback: " Patchwork
2026-08-05 23:19 ` ✓ i915.CI.BAT: " Patchwork
2026-08-06  8:24 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-08-06 10:29 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260805084428.708501-3-sowmiya.s@intel.com \
    --to=sowmiya.s@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.b.s@intel.com \
    --cc=kunal1.joshi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox