From: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
To: igt-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
louis.chauvet@bootlin.com, hamohammed.sa@gmail.comm,
simona@ffwll.ch, melissa.srw@gmail.com,
robin.clark@oss.qualcomm.com, abhinav.kumar@linux.dev,
jesszhan0024@gmail.com, sean@poorly.run,
marijn.suijten@somainline.org,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
"S, Sowmiya" <sowmiya.s@intel.com>,
kernel-dev@igalia.com
Cc: Mark Yacoub <markyacoub@google.com>,
Jani Nikula <jani.nikula@intel.com>,
Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Subject: [PATCH i-g-t] Revert "lib/igt_kms: Do not treat writeback and virtual connectors as connected"
Date: Fri, 28 Aug 2026 17:59:59 -0300 [thread overview]
Message-ID: <20260828-vkms_virtual_output_fix-v1-1-789718f4cb00@igalia.com> (raw)
This reverts commit 321448df7fc9af29b4c6697dc74e6c5e2100af6c.
It has broken vkms testing, which has only Virtual connectors.
Cc: Mark Yacoub <markyacoub@google.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
---
lib/igt_kms.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 695f666bacb9..27f8877a9f6a 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -669,10 +669,6 @@ static inline bool igt_output_is_connected(igt_output_t *output)
!output->config.connector->count_modes)
return false;
- if (output->config.connector->connector_type == DRM_MODE_CONNECTOR_WRITEBACK ||
- output->config.connector->connector_type == DRM_MODE_CONNECTOR_VIRTUAL)
- return false;
-
if (output->config.connector->connection == DRM_MODE_CONNECTED)
return true;
---
base-commit: c0c86b23b316bec7d22bbb95e433a8dc25884a1c
change-id: 20260828-vkms_virtual_output_fix-c82298792438
Best regards,
--
Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
next reply other threads:[~2026-08-28 21:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 20:59 Thadeu Lima de Souza Cascardo [this message]
2026-08-28 21:55 ` ✓ Xe.CI.BAT: success for Revert "lib/igt_kms: Do not treat writeback and virtual connectors as connected" Patchwork
2026-08-28 22:10 ` ✓ i915.CI.BAT: " Patchwork
2026-08-28 23:00 ` ✓ Xe.CI.FULL: " Patchwork
2026-08-29 0:07 ` ✗ i915.CI.Full: failure " Patchwork
2026-08-31 8:51 ` [PATCH i-g-t] " Jani Nikula
2026-08-31 14:01 ` Mark Yacoub
2026-09-03 7:38 ` Melissa Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260828-vkms_virtual_output_fix-v1-1-789718f4cb00@igalia.com \
--to=cascardo@igalia.com \
--cc=abhinav.kumar@linux.dev \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.comm \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jesszhan0024@gmail.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=kernel-dev@igalia.com \
--cc=louis.chauvet@bootlin.com \
--cc=marijn.suijten@somainline.org \
--cc=markyacoub@google.com \
--cc=melissa.srw@gmail.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=sowmiya.s@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox