Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Michał Grzelak" <michal.grzelak@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Pranay Samala" <pranay.samala@intel.com>,
	"Jani Nikula" <jani.nikula@intel.com>,
	"Suraj Kandpal" <suraj.kandpal@intel.com>,
	"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH i-g-t v6 6/6] tools/vbt_decode: change VBT#57 Combo's layout
Date: Wed,  9 Sep 2026 20:34:51 +0200	[thread overview]
Message-ID: <20260909183451.2630263-7-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260909183451.2630263-1-michal.grzelak@intel.com>

Each table from Combo's VBT#57 has 11 columns. Showing them in one line
can cause severe eyestrain. Show max 3 columns per line.

Align shown values using tab. Replace some of previous tab signs with
space signs to preserve indentation without taking too much space.

Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
 tools/intel_vbt_decode.c | 28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
index da80297e4f..f7d2eccc7a 100644
--- a/tools/intel_vbt_decode.c
+++ b/tools/intel_vbt_decode.c
@@ -3535,18 +3535,22 @@ static void dump_combo_vspeo(const struct bdb_vswing_preemph *vspeo,
 			int cursor_program = tables[offset + 9];
 			int coeff_polarity = tables[offset + 10];
 
-			printf("\t\t%s: ", vspeo_dp14_levels[row]);
-			printf("dw2_swing_sel: 0x%08x, ", dw2_swing_sel);
-			printf("dw7_n_scalar: 0x%08x, ", dw7_n_scalar);
-			printf("dw4_cursor_coeff: 0x%08x, ", dw4_cursor_coeff);
-			printf("dw4_post_cursor_2: 0x%08x, ", dw4_post_cursor_2);
-			printf("dw4_post_cursor_1: 0x%08x, ", dw4_post_cursor_1);
-			printf("rcomp_scalar: 0x%08x, ", rcomp_scalar);
-			printf("rterm_select: 0x%08x, ", rterm_select);
-			printf("tap3_disable: 0x%08x, ", tap3_disable);
-			printf("tap2_disable: 0x%08x, ", tap2_disable);
-			printf("cursor_program: 0x%08x, ", cursor_program);
-			printf("coeff_polarity: 0x%08x\n", coeff_polarity);
+			printf("\t  %s:\n", vspeo_dp14_levels[row]);
+			printf("\t    ");
+			printf("dw2_swing_sel:\t0x%08x, ", dw2_swing_sel);
+			printf("dw7_n_scalar:\t0x%08x, ", dw7_n_scalar);
+			printf("dw4_cursor_coeff:\t0x%08x, \n", dw4_cursor_coeff);
+			printf("\t    ");
+			printf("dw4_post_cursor_2:\t0x%08x, ", dw4_post_cursor_2);
+			printf("dw4_post_cursor_1:\t0x%08x, ", dw4_post_cursor_1);
+			printf("rcomp_scalar:\t0x%08x, \n", rcomp_scalar);
+			printf("\t    ");
+			printf("rterm_select:\t0x%08x, ", rterm_select);
+			printf("tap3_disable:\t0x%08x, ", tap3_disable);
+			printf("tap2_disable:\t0x%08x, \n", tap2_disable);
+			printf("\t    ");
+			printf("cursor_program:\t0x%08x, ", cursor_program);
+			printf("coeff_polarity:\t0x%08x\n", coeff_polarity);
 
 			offset += vspeo->num_columns;
 		}
-- 
2.45.2


  parent reply	other threads:[~2026-09-09 18:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 18:34 [PATCH i-g-t v6 0/6] Vswing / Pre-emphasis Override decoding Michał Grzelak
2026-09-09 18:34 ` [PATCH i-g-t v6 1/6] tools/vbt_decode: fix tables' offset reading Michał Grzelak
2026-09-09 18:34 ` [PATCH i-g-t v6 2/6] tools/vbt_decode: rename VBT#57 related vars Michał Grzelak
2026-09-09 18:34 ` [PATCH i-g-t v6 3/6] tools/vbt_decode: validate DEVICE env var Michał Grzelak
2026-09-09 18:34 ` [PATCH i-g-t v6 4/6] tools/vbt_decode: parse & dump VS/PE-O tables for Snps Michał Grzelak
2026-09-09 18:34 ` [PATCH i-g-t v6 5/6] tools/vbt_decode: parse & dump VS/PE-O tables for Combo Michał Grzelak
2026-09-09 18:34 ` Michał Grzelak [this message]
2026-09-09 23:50 ` ✓ Xe.CI.BAT: success for Vswing / Pre-emphasis Override decoding (rev5) Patchwork
2026-09-10  0:25 ` ✓ i915.CI.BAT: " Patchwork
2026-09-10 11:23 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-09-10 19:51 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260909183451.2630263-7-michal.grzelak@intel.com \
    --to=michal.grzelak@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=pranay.samala@intel.com \
    --cc=suraj.kandpal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox