From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22774C88E41 for ; Thu, 10 Sep 2026 20:20:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B03AC10E30B; Thu, 10 Sep 2026 20:20:38 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="SbaBctR3"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7EA1110E2F9 for ; Thu, 10 Sep 2026 20:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1789071270; x=1820607270; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ojoevpJKJr3y6pLUpjwY6v9d0w8L8WvSZdepgTmbPJk=; b=SbaBctR3mbP5+u1VsnHmhrpcWlIn2lM+RynF6ZU+7CeHC55CzM5oYCZ/ lJMPCNVvGOGbvy0JPPQ2iHz/1bWKozyqKLw3/zMowwu2z7eJql4cYnsxL NTA3EqvyhbcvrupJ1qMHtDKBMlT3m7ZFBPjVBThp5vbxqUynEOd6MQgTM dor3qLpmpXZGhiU0y7Js8AKL/bJL5AV/TwGMhZzsMAMgnPdbxoLHp4ZWn BvfNKS4MTUjLTUp/oRtNbyK2MiUz6LtXc3kJM/V/3XkGtlanRLoNo7Aya L+vk3KTgcXSrB7YY3emn2E+BEWbMqvpJsvkF1eUyWkxqB4YtUtJGjbXHJ Q==; X-CSE-ConnectionGUID: o6PpDlLzR/+gsggWs37zWg== X-CSE-MsgGUID: W5y0Bf/UTZue7/30Ob2ytA== X-IronPort-AV: E=McAfee;i="6800,10657,11901"; a="89657255" X-IronPort-AV: E=Sophos;i="6.27,95,1787036400"; d="scan'208";a="89657255" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2026 13:14:30 -0700 X-CSE-ConnectionGUID: lDtls6/zRueqtin3IGR8NQ== X-CSE-MsgGUID: g2hEJIEVS96LnVKeRYlbIw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,95,1787036400"; d="scan'208";a="309978184" Received: from dev-417.igk.intel.com ([10.91.214.181]) by orviesa001.jf.intel.com with ESMTP; 10 Sep 2026 13:14:28 -0700 From: =?UTF-8?q?Micha=C5=82=20Grzelak?= To: igt-dev@lists.freedesktop.org Cc: Nemesa Garg , Karthik B S , Mohammed Thasleem , =?UTF-8?q?Micha=C5=82=20Grzelak?= Subject: [PATCH i-g-t v5 03/17] tests/kms_async_flips: split outer test loop into two Date: Thu, 10 Sep 2026 22:13:59 +0200 Message-ID: <20260910201413.2730574-4-michal.grzelak@intel.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260910201413.2730574-1-michal.grzelak@intel.com> References: <20260910201413.2730574-1-michal.grzelak@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" for_each_crtc_with_valid_output() iterates over every crtc with connected output. Split it into two loops. This is needed to handle cases per output. v3->v4 - break outer loop as well (Mohammed) - add missing space (Mohammed) Signed-off-by: Michał Grzelak --- tests/kms_async_flips.c | 63 ++++++++++++++++++++++------------------- 1 file changed, 34 insertions(+), 29 deletions(-) diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c index ef4b28eb52..8884efd8ba 100644 --- a/tests/kms_async_flips.c +++ b/tests/kms_async_flips.c @@ -877,39 +877,44 @@ static void run_test(data_t *data, void (*test)(data_t *)) if (data->atomic_path) require_atomic_async_cap(data); - for_each_crtc_with_valid_output(display, crtc, data->output) { - data->crtc = crtc; - igt_display_reset(display); + for_each_connected_output(display, data->output) { + for_each_crtc(&data->display, crtc) { + if (!igt_crtc_connector_valid(crtc, data->output)) + continue; - igt_output_set_crtc(data->output, - crtc); - if (!intel_pipe_output_combo_valid(display)) - continue; + data->crtc = crtc; + igt_display_reset(display); - test_init(data); + igt_output_set_crtc(data->output, + crtc); + if (!intel_pipe_output_combo_valid(display)) + continue; - if (data->linear_modifier) - data->modifier = DRM_FORMAT_MOD_LINEAR; - else - data->modifier = default_modifier(data); - - igt_require(igt_format_mods_has_modifier(&data->plane->format_mods_async, - data->modifier)); - - igt_dynamic_f("pipe-%s-%s", igt_crtc_name(crtc), - data->output->name) { - /* - * FIXME: joiner+async flip is busted currently in KMD. - * Remove this check once the issues are fixed in KMD. - */ - igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output), - "Skipping, async flip not supported on joiner mode\n"); - test_init_fbs(data); - test(data); + test_init(data); + + if (data->linear_modifier) + data->modifier = DRM_FORMAT_MOD_LINEAR; + else + data->modifier = default_modifier(data); + + igt_require(igt_format_mods_has_modifier(&data->plane->format_mods_async, + data->modifier)); + + igt_dynamic_f("pipe-%s-%s", igt_crtc_name(crtc), + data->output->name) { + /* + * FIXME: joiner+async flip is busted currently in KMD. + * Remove this check once the issues are fixed in KMD. + */ + igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output), + "Skipping, async flip not supported on joiner mode\n"); + test_init_fbs(data); + test(data); + } + /* Restrict to single pipe in simulation */ + if (data->single_pipe) + return; } - /* Restrict to single pipe in simulation */ - if (data->single_pipe) - break; } } -- 2.45.2