Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jonathan.cavitt@intel.com, alex.zuo@intel.com
Subject: [PATCH] lib/igt_os: Fix igt_require_memory error messages
Date: Wed,  7 Oct 2026 04:44:29 +0800	[thread overview]
Message-ID: <20261006204430.100929-1-jonathan.cavitt@intel.com> (raw)

Info grabbed via igt_sysfs_get does not have a newline attached to the
end, meaning portions of the igt_warn messages produced in
igt_require_memory are printed to the same line as each other.  Clean
that up.

Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
 lib/igt_os.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/igt_os.c b/lib/igt_os.c
index 0fa10ee750..bbc432d721 100644
--- a/lib/igt_os.c
+++ b/lib/igt_os.c
@@ -434,14 +434,14 @@ void igt_require_memory(uint64_t count, uint64_t size, unsigned mode)
 
 		info = igt_sysfs_get(dir, "meminfo");
 		if (info) {
-			igt_warn("Insufficient free memory; /proc/meminfo:\n%s",
+			igt_warn("Insufficient free memory; /proc/meminfo:\n%s\n",
 				 info);
 			free(info);
 		}
 
 		info = igt_sysfs_get(dir, "slabinfo");
 		if (info) {
-			igt_warn("Insufficient free memory; /proc/slabinfo:\n%s",
+			igt_warn("Insufficient free memory; /proc/slabinfo:\n%s\n",
 				 info);
 			free(info);
 		}
-- 
2.43.0


             reply	other threads:[~2026-10-06 20:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 20:44 Jonathan Cavitt [this message]
2026-10-06 21:50 ` ✓ Xe.CI.BAT: success for lib/igt_os: Fix igt_require_memory error messages Patchwork
2026-10-06 22:00 ` ✓ i915.CI.BAT: " Patchwork
2026-10-07  0:02 ` ✗ i915.CI.Full: failure " Patchwork
2026-10-07  2:40 ` ✗ Xe.CI.FULL: " Patchwork
2026-10-07  9:38 ` [PATCH] " Dandamudi, Priyanka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261006204430.100929-1-jonathan.cavitt@intel.com \
    --to=jonathan.cavitt@intel.com \
    --cc=alex.zuo@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox