Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pranay Samala <pranay.samala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, pranay.samala@intel.com
Subject: [PATCH i-g-t] tests/intel/kms_dirtyfb: Use a smaller fb on simulation
Date: Fri, 16 Oct 2026 10:52:43 +0530	[thread overview]
Message-ID: <20261016052243.633897-1-pranay.samala@intel.com> (raw)

The test creates, fills and copies full-screen fbs with
the GPU, which is too slow on simulation, and test hits
timeout.

When running in simulation, limit the fbs to 1024x768.
The CRC still covers the whole pipe, and the reference
and test frames have the same layout.

Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
 tests/intel/kms_dirtyfb.c | 30 +++++++++++++++++++++---------
 1 file changed, 21 insertions(+), 9 deletions(-)

diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
index 48fcb6c61..4674bd2c8 100644
--- a/tests/intel/kms_dirtyfb.c
+++ b/tests/intel/kms_dirtyfb.c
@@ -50,11 +50,15 @@ IGT_TEST_DESCRIPTION("Test the DIRTYFB ioctl is working properly with "
 #define PAGE_ALIGN(x) ALIGN(x, PAGE_SIZE)
 #endif
 
+#define SIM_FB_WIDTH   1024
+#define SIM_FB_HEIGHT  768
+
 typedef struct {
 	int drm_fd, devid;
 	int debugfs_fd;
 	igt_display_t display;
 	drmModeModeInfo *mode;
+	int fb_width, fb_height;
 	uint64_t modifier;
 	igt_output_t *output;
 	igt_pipe_crc_t *pipe_crc;
@@ -106,10 +110,10 @@ static bool check_support(data_t *data)
 		}
 
 		if (!intel_fbc_plane_size_supported(&data->display,
-						    data->mode->hdisplay,
-						    data->mode->vdisplay)) {
+						    data->fb_width,
+						    data->fb_height)) {
 			igt_info("Plane size (%d, %d) not supported as per FBC size restrictions\n",
-				 data->mode->hdisplay, data->mode->vdisplay);
+				 data->fb_width, data->fb_height);
 			return false;
 		}
 		return true;
@@ -234,8 +238,8 @@ static void prepare(data_t *data)
 	data->pipe_crc = igt_crtc_crc_new(data->crtc,
 					  IGT_PIPE_CRC_SOURCE_AUTO);
 
-	igt_create_color_fb(data->drm_fd, data->mode->hdisplay,
-			    data->mode->vdisplay, DRM_FORMAT_XRGB8888,
+	igt_create_color_fb(data->drm_fd, data->fb_width,
+			    data->fb_height, DRM_FORMAT_XRGB8888,
 			    data->modifier, 0.0, 1.0, 0.0,
 			    &data->fbs[0]);
 
@@ -256,8 +260,8 @@ static void prepare(data_t *data)
 
 	igt_pipe_crc_collect_crc(data->pipe_crc, &data->ref_crc);
 
-	igt_create_color_fb(data->drm_fd,  data->mode->hdisplay,
-			    data->mode->vdisplay, DRM_FORMAT_XRGB8888,
+	igt_create_color_fb(data->drm_fd, data->fb_width,
+			    data->fb_height, DRM_FORMAT_XRGB8888,
 			    data->modifier, 0.0, 1.0, 0.0,
 			    &data->fbs[1]);
 	igt_draw_rect_fb(data->drm_fd, data->bops, 0, &data->fbs[1],
@@ -265,8 +269,8 @@ static void prepare(data_t *data)
 			 0, 0, data->fbs[1].width,
 			 data->fbs[1].height, 0xFF);
 
-	igt_create_color_fb(data->drm_fd, data->mode->hdisplay,
-			    data->mode->vdisplay, DRM_FORMAT_XRGB8888,
+	igt_create_color_fb(data->drm_fd, data->fb_width,
+			    data->fb_height, DRM_FORMAT_XRGB8888,
 			    data->modifier, 0.0, 1.0, 0.0,
 			    &data->fbs[2]);
 
@@ -382,6 +386,14 @@ int igt_main()
 							      crtc,
 							      data.output) {
 					data.mode = igt_output_get_mode(data.output);
+					data.fb_width = data.mode->hdisplay;
+					data.fb_height = data.mode->vdisplay;
+					if (igt_run_in_simulation()) {
+						data.fb_width = min_t(int, data.fb_width,
+								      SIM_FB_WIDTH);
+						data.fb_height = min_t(int, data.fb_height,
+								       SIM_FB_HEIGHT);
+					}
 
 					igt_skip_on_f((IS_BATTLEMAGE(data.devid) && data.feature == FEATURE_FBC),
 						       "FBC isn't supported on BMG\n");
-- 
2.53.0


             reply	other threads:[~2026-10-16  5:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16  5:22 Pranay Samala [this message]
2026-10-16  6:05 ` ✗ Xe.CI.BAT: failure for tests/intel/kms_dirtyfb: Use a smaller fb on simulation Patchwork
2026-10-16  6:18 ` ✓ i915.CI.BAT: success " Patchwork
2026-10-16  8:21 ` ✗ i915.CI.Full: failure " Patchwork
2026-10-16 13:59 ` ✓ Xe.CI.FULL: success " Patchwork
2026-10-22  5:08 ` [PATCH i-g-t] " S, Sowmiya
2026-10-22 15:01 ` ✓ Xe.CI.BAT: success for tests/intel/kms_dirtyfb: Use a smaller fb on simulation (rev2) Patchwork
2026-10-22 15:09 ` ✓ i915.CI.BAT: " Patchwork
2026-10-22 16:10 ` [PATCH i-g-t] tests/intel/kms_dirtyfb: Use a smaller fb on simulation Naladala, Ramanaidu
2026-10-23  3:51   ` Samala, Pranay
2026-10-23  0:07 ` ✓ Xe.CI.FULL: success for tests/intel/kms_dirtyfb: Use a smaller fb on simulation (rev2) Patchwork
2026-10-23  3:48 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261016052243.633897-1-pranay.samala@intel.com \
    --to=pranay.samala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.b.s@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox