Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: pranay.samala@intel.com, Jeevan B <jeevan.b@intel.com>
Subject: [PATCH 3/3] tests/kms_rotation_crc: reduce multiplane CI debug output
Date: Mon, 26 Oct 2026 22:48:36 +0530	[thread overview]
Message-ID: <20261026171836.1434992-4-jeevan.b@intel.com> (raw)
In-Reply-To: <20261026171836.1434992-1-jeevan.b@intel.com>

Use DRM_UT_CORE in CI for multiplane-rotation and both cropping variants
to suppress KMS debug logs while retaining CORE diagnostics. Restore the
original mask after the group and on exit; other subtests are unchanged.

Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/work_items/16184
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
 tests/kms_rotation_crc.c | 96 ++++++++++++++++++++++------------------
 1 file changed, 53 insertions(+), 43 deletions(-)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index a01aac78f..c3481880b 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -31,6 +31,7 @@
  */
 
 #include "igt.h"
+#include "igt_sysfs.h"
 #include "igt_vec.h"
 #include <math.h>
 
@@ -1437,6 +1438,7 @@ int igt_main_args("", long_opts, help_str, opt_handler, &data)
 
 		igt_display_require(&data.display, data.gfx_fd);
 		igt_require(data.display.is_atomic);
+		igt_install_exit_handler(igt_drm_debug_mask_reset_exit_handler);
 	}
 
 	igt_describe("Rotation test with 90/270 degree for primary and sprite planes of gen9+");
@@ -1502,51 +1504,59 @@ int igt_main_args("", long_opts, help_str, opt_handler, &data)
 		}
 	}
 
-	igt_describe("Rotation test on both planes by making them fully visible");
-	igt_subtest_f("multiplane-rotation") {
-		igt_crtc_t *crtc = igt_first_crtc(&data.display);
-
-		igt_require(gen >= 9);
-		cleanup_crtc(&data);
-		data.planepos[0].origo = p_top | p_left;
-		data.planepos[0].x = .2f;
-		data.planepos[0].y = .1f;
-		data.planepos[1].origo = p_top | p_right;
-		data.planepos[1].x = -.4f;
-		data.planepos[1].y = .1f;
-		test_multi_plane_rotation(&data, crtc);
-	}
+	igt_subtest_group() {
+		igt_fixture()
+			update_debug_mask_if_ci(DRM_UT_CORE);
 
-	igt_describe("Rotation test on both planes by cropping left/top corner of primary plane and"
-			"right/top corner of sprite plane");
-	igt_subtest_f("multiplane-rotation-cropping-top") {
-		igt_crtc_t *crtc = igt_first_crtc(&data.display);
-
-		igt_require(gen >= 9);
-		cleanup_crtc(&data);
-		data.planepos[0].origo = p_top | p_left;
-		data.planepos[0].x = -.05f;
-		data.planepos[0].y = -.15f;
-		data.planepos[1].origo = p_top | p_right;
-		data.planepos[1].x = -.15f;
-		data.planepos[1].y = -.15f;
-		test_multi_plane_rotation(&data, crtc);
-	}
+		igt_describe("Rotation test on both planes by making them fully visible");
+		igt_subtest_f("multiplane-rotation") {
+			igt_crtc_t *crtc = igt_first_crtc(&data.display);
+
+			igt_require(gen >= 9);
+			cleanup_crtc(&data);
+			data.planepos[0].origo = p_top | p_left;
+			data.planepos[0].x = .2f;
+			data.planepos[0].y = .1f;
+			data.planepos[1].origo = p_top | p_right;
+			data.planepos[1].x = -.4f;
+			data.planepos[1].y = .1f;
+			test_multi_plane_rotation(&data, crtc);
+		}
 
-	igt_describe("Rotation test on both planes by cropping left/bottom corner of primary plane"
-			"and right/bottom corner of sprite plane");
-	igt_subtest_f("multiplane-rotation-cropping-bottom") {
-		igt_crtc_t *crtc = igt_first_crtc(&data.display);
-
-		igt_require(gen >= 9);
-		cleanup_crtc(&data);
-		data.planepos[0].origo = p_bottom | p_left;
-		data.planepos[0].x = -.05f;
-		data.planepos[0].y = -.20f;
-		data.planepos[1].origo = p_bottom | p_right;
-		data.planepos[1].x = -.15f;
-		data.planepos[1].y = -.20f;
-		test_multi_plane_rotation(&data, crtc);
+		igt_describe("Rotation test on both planes by cropping left/top corner of primary "
+			     "plane and right/top corner of sprite plane");
+		igt_subtest_f("multiplane-rotation-cropping-top") {
+			igt_crtc_t *crtc = igt_first_crtc(&data.display);
+
+			igt_require(gen >= 9);
+			cleanup_crtc(&data);
+			data.planepos[0].origo = p_top | p_left;
+			data.planepos[0].x = -.05f;
+			data.planepos[0].y = -.15f;
+			data.planepos[1].origo = p_top | p_right;
+			data.planepos[1].x = -.15f;
+			data.planepos[1].y = -.15f;
+			test_multi_plane_rotation(&data, crtc);
+		}
+
+		igt_describe("Rotation test on both planes by cropping left/bottom corner of "
+			     "primary plane and right/bottom corner of sprite plane");
+		igt_subtest_f("multiplane-rotation-cropping-bottom") {
+			igt_crtc_t *crtc = igt_first_crtc(&data.display);
+
+			igt_require(gen >= 9);
+			cleanup_crtc(&data);
+			data.planepos[0].origo = p_bottom | p_left;
+			data.planepos[0].x = -.05f;
+			data.planepos[0].y = -.20f;
+			data.planepos[1].origo = p_bottom | p_right;
+			data.planepos[1].x = -.15f;
+			data.planepos[1].y = -.20f;
+			test_multi_plane_rotation(&data, crtc);
+		}
+
+		igt_fixture()
+			igt_drm_debug_mask_reset();
 	}
 
 	igt_describe("Rotation test on primary plane with concurrent cursor movement");
-- 
2.43.0


  parent reply	other threads:[~2026-10-26 17:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 17:18 [PATCH 0/3] reduce CI debug output Jeevan B
2026-10-26 17:18 ` [PATCH 1/3] tests/kms_cursor_legacy: " Jeevan B
2026-10-26 17:18 ` [PATCH 2/3] tests/kms_plane_cursor: " Jeevan B
2026-10-26 17:18 ` Jeevan B [this message]
2026-10-26 20:19 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-10-26 20:45 ` ✓ i915.CI.BAT: " Patchwork
2026-10-27  3:13 ` ✗ i915.CI.Full: failure " Patchwork
2026-10-27  3:25 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261026171836.1434992-4-jeevan.b@intel.com \
    --to=jeevan.b@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=pranay.samala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox