Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <andrzej.hajda@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
	"Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	"Dominik Karol Piatkowski" <dominik.karol.piatkowski@intel.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>
Subject: [PATCH v2 0/2] xe/shaders: remove explicit regioning and channel offsets
Date: Wed, 28 Oct 2026 15:44:27 +0100	[thread overview]
Message-ID: <20261028-remove_gpu_asm_annotations-v2-0-270a5878b2fc@intel.com> (raw)

There is no need to specify regioning and channel offset in
most cases. Default genisa values are:
- <0;1,0> for source region,
- <1> for destination region,
- M0 for channel offset.
The patch also enforces common formating for all asms:
- preprocessor instructions and predicates start from beginning of the line,
- instruction mnemonic starts from 1st tab,
- exec size follows mnemonic after one space,
- flag modifiers, if any, are placed after exec size,
- arguments starts from 3rd tab,
- no tabs/multi-spaces between/after arguments

The changes do not affect produced binary code.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
Changes in v2:
- split patch to lib and test parts, remove script change (Kamil)
- Link to v1: https://patch.msgid.link/20261027-remove_gpu_asm_annotations-v1-1-55a0fb61b96d@intel.com

---
Andrzej Hajda (2):
      lib/shaders: remove explicit regioning and channel offsets
      tests/intel/xe_prefetch_fault: remove explicit regioning and channel offsets

 lib/gpgpu_fill.c                                  | 104 +++++++++---------
 lib/gpgpu_fill.c.gen.iga64_codes.c                |   2 +-
 lib/gpgpu_shader.c                                | 126 +++++++++++-----------
 lib/gpgpu_shader.c.gen.iga64_codes.c              |   2 +-
 lib/iga64_macros.h                                |  70 ++++++------
 tests/intel/xe_prefetch_fault.c                   |  16 +--
 tests/intel/xe_prefetch_fault.c.gen.iga64_codes.c |   2 +-
 7 files changed, 160 insertions(+), 162 deletions(-)
---
base-commit: fc75d6d7ffcb79e8a3316e80c7085460568a7670
change-id: 20261027-remove_gpu_asm_annotations-94b7b32841dd

Best regards,
--  
Andrzej Hajda <andrzej.hajda@intel.com>


             reply	other threads:[~2026-10-28 14:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 14:44 Andrzej Hajda [this message]
2026-10-28 14:44 ` [PATCH v2 1/2] lib/shaders: remove explicit regioning and channel offsets Andrzej Hajda
2026-10-28 14:44 ` [PATCH v2 2/2] tests/intel/xe_prefetch_fault: " Andrzej Hajda
2026-10-28 20:21 ` ✓ Xe.CI.BAT: success for xe/shaders: remove explicit regioning and channel offsets (rev2) Patchwork
2026-10-28 20:59 ` ✓ i915.CI.BAT: " Patchwork
2026-10-29  3:45 ` ✗ i915.CI.Full: failure " Patchwork
2026-10-29  8:14 ` ✗ Xe.CI.FULL: " Patchwork
2026-10-29 15:02   ` Hajda, Andrzej

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261028-remove_gpu_asm_annotations-v2-0-270a5878b2fc@intel.com \
    --to=andrzej.hajda@intel.com \
    --cc=dominik.karol.piatkowski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox