From: Andrzej Hajda <andrzej.hajda@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
"Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
"Dominik Karol Piatkowski" <dominik.karol.piatkowski@intel.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>
Subject: [PATCH v3 0/2] xe/shaders: remove explicit regioning and channel offsets
Date: Fri, 06 Nov 2026 15:07:53 +0100 [thread overview]
Message-ID: <20261106-remove_gpu_asm_annotations-v3-0-f3c1e3cb71d7@intel.com> (raw)
There is no need to specify regioning and channel offset in
most cases. Default genisa values are:
- <0;1,0> for source region,
- <1> for destination region,
- M0 for channel offset.
The patch also enforces common formating for all asms:
- preprocessor instructions and predicates start from beginning of the line,
- instruction mnemonic starts from 1st tab,
- exec size follows mnemonic after one space,
- flag modifiers, if any, are placed after exec size,
- arguments starts from 3rd tab,
- args are tab aligned per shader - argN should be place at the same column
The changes do not affect produced binary code.
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
Changes in v3:
- changed formating of args from single-space separated to tab aligned (Zbigniew)
- Link to v2: https://patch.msgid.link/20261028-remove_gpu_asm_annotations-v2-0-270a5878b2fc@intel.com
Changes in v2:
- split patch to lib and test parts, remove script change (Kamil)
- Link to v1: https://patch.msgid.link/20261027-remove_gpu_asm_annotations-v1-1-55a0fb61b96d@intel.com
---
Andrzej Hajda (2):
lib/shaders: remove explicit regioning and channel offsets
tests/intel/xe_prefetch_fault: remove explicit regioning and channel offsets
lib/gpgpu_fill.c | 100 ++++++++--------
lib/gpgpu_fill.c.gen.iga64_codes.c | 2 +-
lib/gpgpu_shader.c | 132 +++++++++++-----------
lib/gpgpu_shader.c.gen.iga64_codes.c | 2 +-
lib/iga64_macros.h | 58 +++++-----
tests/intel/xe_prefetch_fault.c | 16 +--
tests/intel/xe_prefetch_fault.c.gen.iga64_codes.c | 2 +-
7 files changed, 156 insertions(+), 156 deletions(-)
---
base-commit: 45b7aef25da3a40ae4cc75442d7b8e6f9af1fb98
change-id: 20261027-remove_gpu_asm_annotations-94b7b32841dd
Best regards,
--
Andrzej Hajda <andrzej.hajda@intel.com>
next reply other threads:[~2026-11-06 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 14:07 Andrzej Hajda [this message]
2026-11-06 14:07 ` [PATCH v3 1/2] lib/shaders: remove explicit regioning and channel offsets Andrzej Hajda
2026-11-09 15:38 ` Zbigniew Kempczyński
2026-11-06 14:07 ` [PATCH v3 2/2] tests/intel/xe_prefetch_fault: " Andrzej Hajda
2026-11-09 15:39 ` Zbigniew Kempczyński
2026-11-06 18:49 ` ✓ Xe.CI.BAT: success for xe/shaders: remove explicit regioning and channel offsets (rev3) Patchwork
2026-11-06 19:27 ` ✓ i915.CI.BAT: " Patchwork
2026-11-07 4:14 ` ✗ i915.CI.Full: failure " Patchwork
2026-11-07 21:33 ` ✗ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261106-remove_gpu_asm_annotations-v3-0-f3c1e3cb71d7@intel.com \
--to=andrzej.hajda@intel.com \
--cc=dominik.karol.piatkowski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox