Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ray Wu <ray.wu@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: <jani.nikula@linux.intel.com>, <kamil.konieczny@linux.intel.com>,
	<alex.hung@amd.com>, <sunpeng.li@amd.com>,
	<chiahsuan.chung@amd.com>, Ray Wu <ray.wu@amd.com>
Subject: [PATCH i-g-t v2 2/6] tests/amdgpu/amd_replay: Fix test_mode checks
Date: Mon, 16 Nov 2026 10:24:43 +0800	[thread overview]
Message-ID: <20261116022447.3981877-3-ray.wu@amd.com> (raw)
In-Reply-To: <20261116022447.3981877-1-ray.wu@amd.com>

Both test_mode checks are missing "test_mode ==" on the second operand,
so constant live never checks the state during flips and the static
screen check always runs.

Signed-off-by: Ray Wu <ray.wu@amd.com>
---
 tests/amdgpu/amd_replay.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/amdgpu/amd_replay.c b/tests/amdgpu/amd_replay.c
index 4640eb804..f4dcf0d21 100644
--- a/tests/amdgpu/amd_replay.c
+++ b/tests/amdgpu/amd_replay.c
@@ -221,7 +221,7 @@ static void page_flip_test(struct test_data *data, igt_output_t *output,
 		igt_require(ret == 0);
 		kmstest_wait_for_pageflip(data->fd);
 
-		if (test_mode == (TEST_MODE_CONSTANT_LIVE || TEST_MODE_INTERMITTENT_LIVE)
+		if ((test_mode == TEST_MODE_CONSTANT_LIVE || test_mode == TEST_MODE_INTERMITTENT_LIVE)
 				&& frame_count > 5) {
 			/* Panel Replay state needs few frame to enter the live mode */
 			replay_state = igt_amd_read_replay_state(data->fd, output->name);
@@ -287,7 +287,7 @@ static void run_check_replay(struct test_data *data, enum test_mode test_mode)
 		page_flip_test(data, output, test_mode, 20);
 
 		/* Check Panel Replay state in static screen */
-		if (test_mode == TEST_MODE_STATIC_SCREEN || TEST_MODE_INTERMITTENT_LIVE) {
+		if (test_mode == TEST_MODE_STATIC_SCREEN || test_mode == TEST_MODE_INTERMITTENT_LIVE) {
 			/* Panel Replay state takes some time to settle its value on static screen */
 			sleep(1);
 
-- 
2.43.0


  parent reply	other threads:[~2026-11-16  2:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  2:24 [PATCH i-g-t v2 0/6] tests/amdgpu/amd_replay: Fix state and sink status checks Ray Wu
2026-11-16  2:24 ` [PATCH i-g-t v2 1/6] tests/amdgpu/amd_replay: Read DPCD at the target offset Ray Wu
2026-11-16  2:24 ` Ray Wu [this message]
2026-11-16  2:24 ` [PATCH i-g-t v2 3/6] tests/amdgpu/amd_replay: Fix inverted Replay state range checks Ray Wu
2026-11-16  2:24 ` [PATCH i-g-t v2 4/6] tests/amdgpu/amd_replay: Require REPLAY_STATE_3 after settle Ray Wu
2026-11-16  2:24 ` [PATCH i-g-t v2 5/6] tests/amdgpu/amd_replay: Fail on page flip errors Ray Wu
2026-11-16  2:24 ` [PATCH i-g-t v2 6/6] tests/amdgpu/amd_replay: Check sink Replay error status Ray Wu
2026-11-16  3:25 ` ✓ Xe.CI.BAT: success for tests/amdgpu/amd_replay: Fix state and sink status checks (rev2) Patchwork
2026-11-16  3:45 ` ✗ i915.CI.BAT: failure " Patchwork
2026-11-16  5:28 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116022447.3981877-3-ray.wu@amd.com \
    --to=ray.wu@amd.com \
    --cc=alex.hung@amd.com \
    --cc=chiahsuan.chung@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox