From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20190322092155.1656-1-chris@chris-wilson.co.uk> <20190322092155.1656-2-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Message-ID: <204a2a2c-4372-0284-d715-9cf474de6dac@linux.intel.com> Date: Tue, 26 Mar 2019 08:36:18 +0000 MIME-Version: 1.0 In-Reply-To: <20190322092155.1656-2-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t 02/24] lib: Add GPU power measurement List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-ID: Ck9uIDIyLzAzLzIwMTkgMDk6MjEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBSZWFkIHRoZSBSQVBM IHBvd2VyIG1ldHJpY3MgY291cnRlc3kgb2YgcGVyZi4gT3IgeW91ciBsb2NhbCBIVwo+IGVxdWl2 YWxlbnQ/Cj4gCj4gdjI6IHVzZWxvY2FsZSgpCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2ls c29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gICBsaWIvTWFrZWZpbGUuYW0g ICAgICB8ICAgMSArCj4gICBsaWIvTWFrZWZpbGUuc291cmNlcyB8ICAgMiArCj4gICBsaWIvaWd0 X2dwdV9wb3dlci5jICB8IDExNCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrCj4gICBsaWIvaWd0X2dwdV9wb3dlci5oICB8ICA1OSArKysrKysrKysrKysrKysrKysr KysrCj4gICBsaWIvbWVzb24uYnVpbGQgICAgICB8ICAgMiArCj4gICA1IGZpbGVzIGNoYW5nZWQs IDE3OCBpbnNlcnRpb25zKCspCj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgbGliL2lndF9ncHVfcG93 ZXIuYwo+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGxpYi9pZ3RfZ3B1X3Bvd2VyLmgKPiAKPiBkaWZm IC0tZ2l0IGEvbGliL01ha2VmaWxlLmFtIGIvbGliL01ha2VmaWxlLmFtCj4gaW5kZXggM2U2YTdm ZGJhLi42MmU4YmRhNzMgMTAwNjQ0Cj4gLS0tIGEvbGliL01ha2VmaWxlLmFtCj4gKysrIGIvbGli L01ha2VmaWxlLmFtCj4gQEAgLTg0LDQgKzg0LDUgQEAgbGliaW50ZWxfdG9vbHNfbGFfTElCQURE ID0gXAo+ICAgCSQoTElCVURFVl9MSUJTKSBcCj4gICAJJChQSVhNQU5fTElCUykgXAo+ICAgCSQo R0xJQl9MSUJTKSBcCj4gKwlsaWJpZ3RfcGVyZi5sYSBcCj4gICAJLWxtCj4gZGlmZiAtLWdpdCBh L2xpYi9NYWtlZmlsZS5zb3VyY2VzIGIvbGliL01ha2VmaWxlLnNvdXJjZXMKPiBpbmRleCBjZjI3 MjA5ODEuLmUwMDM0N2Y5NCAxMDA2NDQKPiAtLS0gYS9saWIvTWFrZWZpbGUuc291cmNlcwo+ICsr KyBiL2xpYi9NYWtlZmlsZS5zb3VyY2VzCj4gQEAgLTI2LDYgKzI2LDggQEAgbGliX3NvdXJjZV9s aXN0ID0JIAlcCj4gICAJaWd0X2NvbG9yX2VuY29kaW5nLmMJXAo+ICAgCWlndF9jb2xvcl9lbmNv ZGluZy5oCVwKPiAgIAlpZ3RfZWRpZF90ZW1wbGF0ZS5oCVwKPiArCWlndF9ncHVfcG93ZXIuYwkJ XAo+ICsJaWd0X2dwdV9wb3dlci5oCQlcCj4gICAJaWd0X2d0LmMJCVwKPiAgIAlpZ3RfZ3QuaAkJ XAo+ICAgCWlndF9ndnQuYwkJXAo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2dwdV9wb3dlci5jIGIv bGliL2lndF9ncHVfcG93ZXIuYwo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAw MDAwLi5hNGUzYzE0MjAKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvbGliL2lndF9ncHVfcG93ZXIu Ywo+IEBAIC0wLDAgKzEsMTE0IEBACj4gKyNpbmNsdWRlIDxjdHlwZS5oPgo+ICsjaW5jbHVkZSA8 ZXJybm8uaD4KPiArI2luY2x1ZGUgPGZjbnRsLmg+Cj4gKyNpbmNsdWRlIDxsb2NhbGUuaD4KPiAr I2luY2x1ZGUgPG1hdGguaD4KPiArI2luY2x1ZGUgPHVuaXN0ZC5oPgo+ICsKPiArI2luY2x1ZGUg ImlndF9ncHVfcG93ZXIuaCIKPiArI2luY2x1ZGUgImlndF9wZXJmLmgiCj4gKwo+ICtzdGF0aWMg aW50IGZpbGVuYW1lX3RvX2J1Zihjb25zdCBjaGFyICpmaWxlbmFtZSwgY2hhciAqYnVmLCB1bnNp Z25lZCBpbnQgc3opCj4gK3sKPiArCWludCBmZDsKPiArCXNzaXplX3QgcmV0Owo+ICsKPiArCWZk ID0gb3BlbihmaWxlbmFtZSwgT19SRE9OTFkpOwo+ICsJaWYgKGZkIDwgMCkKPiArCQlyZXR1cm4g LTE7Cj4gKwo+ICsJcmV0ID0gcmVhZChmZCwgYnVmLCBzeiAtIDEpOwo+ICsJY2xvc2UoZmQpOwo+ ICsJaWYgKHJldCA8IDEpCj4gKwkJcmV0dXJuIC0xOwo+ICsKPiArCWJ1ZltyZXRdID0gJ1wwJzsK PiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIHVpbnQ2NF90IGZpbGVuYW1lX3Rv X3U2NChjb25zdCBjaGFyICpmaWxlbmFtZSwgaW50IGJhc2UpCj4gK3sKPiArCWNoYXIgYnVmWzY0 XSwgKmI7Cj4gKwo+ICsJaWYgKGZpbGVuYW1lX3RvX2J1ZihmaWxlbmFtZSwgYnVmLCBzaXplb2Yo YnVmKSkpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJLyoKPiArCSAqIEhhbmRsZSBib3RoIHNpbmds ZSBpbnRlZ2VyIGFuZCBrZXk9dmFsdWUgZm9ybWF0cyBieSBza2lwcGluZwo+ICsJICogbGVhZGlu ZyBub24tZGlnaXRzLgo+ICsJICovCj4gKwliID0gYnVmOwo+ICsJd2hpbGUgKCpiICYmICFpc2Rp Z2l0KCpiKSkKPiArCQliKys7Cj4gKwo+ICsJcmV0dXJuIHN0cnRvdWxsKGIsIE5VTEwsIGJhc2Up Owo+ICt9Cj4gKwo+ICtzdGF0aWMgZG91YmxlIGZpbGVuYW1lX3RvX2RvdWJsZShjb25zdCBjaGFy ICpmaWxlbmFtZSkKPiArewo+ICsJbG9jYWxlX3QgbG9jYWxlLCBvbGRsb2NhbGU7Cj4gKwljaGFy IGJ1Zls4MF07Cj4gKwlkb3VibGUgdjsKPiArCj4gKwlpZiAoZmlsZW5hbWVfdG9fYnVmKGZpbGVu YW1lLCBidWYsIHNpemVvZihidWYpKSkKPiArCQlyZXR1cm4gMDsKPiArCj4gKwkvKiBSZXBsYWNl IHVzZXIgZW52aXJvbm1lbnQgd2l0aCBwbGFpbiBDIHRvIG1hdGNoIGtlcm5lbCBmb3JtYXQgKi8K PiArCWxvY2FsZSA9IG5ld2xvY2FsZShMQ19BTEwsICJDIiwgMCk7Cj4gKwlvbGRsb2NhbGUgPSB1 c2Vsb2NhbGUobG9jYWxlKTsKPiArCj4gKwl2ID0gc3RydG9kKGJ1ZiwgTlVMTCk7Cj4gKwo+ICsJ dXNlbG9jYWxlKG9sZGxvY2FsZSk7Cj4gKwlmcmVlbG9jYWxlKGxvY2FsZSk7Cj4gKwo+ICsJcmV0 dXJuIHY7Cj4gK30KCkhleSB5b3Uga25vdyB3aGF0IG91ciBndWlkZWxpbmVzIGZvciBpbnRyb2R1 Y2luZyBhIDNyZCBjb3B5IG9mIHNvbWV0aGluZyAKYXJlLiA7KQoKTWF5YmUgaXQgd291bGQgYmUg ZmFpciBnYW1lIHRvIHN0dWZmIHRoZXNlIGhlbHBlcnMgdG8gaWd0X3BlcmYubGEgLSAKc2luY2Ug Ym90aCBvdmVybGF5IGFuZCBpbnRlbF9ncHVfZ3B1IGxpbmsgd2l0aCBpdCBhbHJlYWR5IGFuZCBp dCBpcyAKYWJvdXQgaW50ZXJmYWNpbmcgd2l0aCBwZXJmIGFmdGVyIGFsbC4KClRoZXJlIGFyZSBz b21lIHNtYWxsIGRpZmZlcmVuY2VzIGJldHdlZW4gdGhlIGZ1bmN0aW9ucyBoZXJlIGFuZCBpbiAK aW50ZWxfZ3B1X3RvcCwgc29tZW9uZSBpcyByaWdodCBvciB3cm9uZywgb3IgYXQgbGVhc3QgbW9y ZSByaWdodD8KCj4gKwo+ICtzdGF0aWMgdWludDY0X3QgcmFwbF90eXBlX2lkKHZvaWQpCj4gK3sK PiArCXJldHVybiBmaWxlbmFtZV90b191NjQoIi9zeXMvZGV2aWNlcy9wb3dlci90eXBlIiwgMTAp Owo+ICt9Cj4gKwo+ICtzdGF0aWMgdWludDY0X3QgcmFwbF9ncHVfcG93ZXIodm9pZCkKPiArewo+ ICsJcmV0dXJuIGZpbGVuYW1lX3RvX3U2NCgiL3N5cy9kZXZpY2VzL3Bvd2VyL2V2ZW50cy9lbmVy Z3ktZ3B1IiwgMCk7Cj4gK30KPiArCj4gK3N0YXRpYyBkb3VibGUgcmFwbF9ncHVfcG93ZXJfc2Nh bGUodm9pZCkKPiArewo+ICsJcmV0dXJuIGZpbGVuYW1lX3RvX2RvdWJsZSgiL3N5cy9kZXZpY2Vz L3Bvd2VyL2V2ZW50cy9lbmVyZ3ktZ3B1LnNjYWxlIik7Cj4gK30KPiArCj4gK2ludCBncHVfcG93 ZXJfb3BlbihzdHJ1Y3QgZ3B1X3Bvd2VyICpwb3dlcikKPiArewo+ICsJcG93ZXItPmZkID0gaWd0 X3BlcmZfb3BlbihyYXBsX3R5cGVfaWQoKSwgcmFwbF9ncHVfcG93ZXIoKSk7Cj4gKwlpZiAocG93 ZXItPmZkIDwgMCkgewo+ICsJCXBvd2VyLT5mZCA9IC1lcnJubzsKPiArCQlnb3RvIGVycjsKPiAr CX0KPiArCj4gKwlwb3dlci0+c2NhbGUgPSByYXBsX2dwdV9wb3dlcl9zY2FsZSgpOwo+ICsJaWYg KGlzbmFuKHBvd2VyLT5zY2FsZSkgfHwgIXBvd2VyLT5zY2FsZSkgewo+ICsJCWNsb3NlKHBvd2Vy LT5mZCk7Cj4gKwkJZ290byBlcnI7Cj4gKwl9Cj4gKwlwb3dlci0+c2NhbGUgKj0gMWU5OwoKU2Nh bGUgaGFzIG5vIHVuaXQgc28gSSB0aGluayB0aGlzIHdvdWxkIGdvIGJldHRlciBpbnRvIGdwdV9w b3dlcl9XLiAKV291bGQgYXZvaWQgKiAxZTkgKiAxZS05IGluIGdwdV9wb3dlcl9KIGFzIHdlbGwu Cgo+ICsKPiArCXJldHVybiAwOwo+ICsKPiArZXJyOgo+ICsJZXJybm8gPSAwOwo+ICsJcmV0dXJu IHBvd2VyLT5mZDsKPiArfQo+ICsKPiArYm9vbCBncHVfcG93ZXJfcmVhZChzdHJ1Y3QgZ3B1X3Bv d2VyICpwb3dlciwgc3RydWN0IGdwdV9wb3dlcl9zYW1wbGUgKnMpCj4gK3sKPiArCXJldHVybiBy ZWFkKHBvd2VyLT5mZCwgcywgc2l6ZW9mKCpzKSkgPT0gc2l6ZW9mKCpzKTsKPiArfQo+ICsKPiAr dm9pZCBncHVfcG93ZXJfY2xvc2Uoc3RydWN0IGdwdV9wb3dlciAqcG93ZXIpCj4gK3sKPiArCWNs b3NlKHBvd2VyLT5mZCk7Cj4gK30KPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9ncHVfcG93ZXIuaCBi L2xpYi9pZ3RfZ3B1X3Bvd2VyLmgKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAw MDAwMC4uNGUxYjc0N2MwCj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL2xpYi9pZ3RfZ3B1X3Bvd2Vy LmgKPiBAQCAtMCwwICsxLDU5IEBACj4gKy8qCj4gKyAqIENvcHlyaWdodCDCqSAyMDE5IEludGVs IENvcnBvcmF0aW9uCj4gKyAqCj4gKyAqIFBlcm1pc3Npb24gaXMgaGVyZWJ5IGdyYW50ZWQsIGZy ZWUgb2YgY2hhcmdlLCB0byBhbnkgcGVyc29uIG9idGFpbmluZyBhCj4gKyAqIGNvcHkgb2YgdGhp cyBzb2Z0d2FyZSBhbmQgYXNzb2NpYXRlZCBkb2N1bWVudGF0aW9uIGZpbGVzICh0aGUgIlNvZnR3 YXJlIiksCj4gKyAqIHRvIGRlYWwgaW4gdGhlIFNvZnR3YXJlIHdpdGhvdXQgcmVzdHJpY3Rpb24s IGluY2x1ZGluZyB3aXRob3V0IGxpbWl0YXRpb24KPiArICogdGhlIHJpZ2h0cyB0byB1c2UsIGNv cHksIG1vZGlmeSwgbWVyZ2UsIHB1Ymxpc2gsIGRpc3RyaWJ1dGUsIHN1YmxpY2Vuc2UsCj4gKyAq IGFuZC9vciBzZWxsIGNvcGllcyBvZiB0aGUgU29mdHdhcmUsIGFuZCB0byBwZXJtaXQgcGVyc29u cyB0byB3aG9tIHRoZQo+ICsgKiBTb2Z0d2FyZSBpcyBmdXJuaXNoZWQgdG8gZG8gc28sIHN1Ympl Y3QgdG8gdGhlIGZvbGxvd2luZyBjb25kaXRpb25zOgo+ICsgKgo+ICsgKiBUaGUgYWJvdmUgY29w eXJpZ2h0IG5vdGljZSBhbmQgdGhpcyBwZXJtaXNzaW9uIG5vdGljZSAoaW5jbHVkaW5nIHRoZSBu ZXh0Cj4gKyAqIHBhcmFncmFwaCkgc2hhbGwgYmUgaW5jbHVkZWQgaW4gYWxsIGNvcGllcyBvciBz dWJzdGFudGlhbCBwb3J0aW9ucyBvZiB0aGUKPiArICogU29mdHdhcmUuCj4gKyAqCj4gKyAqIFRI RSBTT0ZUV0FSRSBJUyBQUk9WSURFRCAiQVMgSVMiLCBXSVRIT1VUIFdBUlJBTlRZIE9GIEFOWSBL SU5ELCBFWFBSRVNTIE9SCj4gKyAqIElNUExJRUQsIElOQ0xVRElORyBCVVQgTk9UIExJTUlURUQg VE8gVEhFIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZLAo+ICsgKiBGSVRORVNTIEZPUiBB IFBBUlRJQ1VMQVIgUFVSUE9TRSBBTkQgTk9OSU5GUklOR0VNRU5ULiAgSU4gTk8gRVZFTlQgU0hB TEwKPiArICogVEhFIEFVVEhPUlMgT1IgQ09QWVJJR0hUIEhPTERFUlMgQkUgTElBQkxFIEZPUiBB TlkgQ0xBSU0sIERBTUFHRVMgT1IgT1RIRVIKPiArICogTElBQklMSVRZLCBXSEVUSEVSIElOIEFO IEFDVElPTiBPRiBDT05UUkFDVCwgVE9SVCBPUiBPVEhFUldJU0UsIEFSSVNJTkcKPiArICogRlJP TSwgT1VUIE9GIE9SIElOIENPTk5FQ1RJT04gV0lUSCBUSEUgU09GVFdBUkUgT1IgVEhFIFVTRSBP UiBPVEhFUiBERUFMSU5HUwo+ICsgKiBJTiBUSEUgU09GVFdBUkUuCj4gKyAqCj4gKyAqLwo+ICsK PiArI2lmbmRlZiBJR1RfR1BVX1BPV0VSX0gKPiArI2RlZmluZSBJR1RfR1BVX1BPV0VSX0gKPiAr Cj4gKyNpbmNsdWRlIDxzdGRib29sLmg+Cj4gKyNpbmNsdWRlIDxzdGRpbnQuaD4KPiArCj4gK3N0 cnVjdCBncHVfcG93ZXIgewo+ICsJaW50IGZkOwo+ICsJZG91YmxlIHNjYWxlOwo+ICt9Owo+ICsK PiArc3RydWN0IGdwdV9wb3dlcl9zYW1wbGUgewo+ICsJdWludDY0X3QgZW5lcmd5Owo+ICsJdWlu dDY0X3QgdGltZTsKPiArfTsKPiArCj4gK2ludCBncHVfcG93ZXJfb3BlbihzdHJ1Y3QgZ3B1X3Bv d2VyICpwb3dlcik7Cj4gK2Jvb2wgZ3B1X3Bvd2VyX3JlYWQoc3RydWN0IGdwdV9wb3dlciAqcG93 ZXIsIHN0cnVjdCBncHVfcG93ZXJfc2FtcGxlICpzKTsKPiArdm9pZCBncHVfcG93ZXJfY2xvc2Uo c3RydWN0IGdwdV9wb3dlciAqcG93ZXIpOwo+ICsKPiArc3RhdGljIGlubGluZSBkb3VibGUgZ3B1 X3Bvd2VyX0ooY29uc3Qgc3RydWN0IGdwdV9wb3dlciAqcCwKPiArCQkJCSBjb25zdCBzdHJ1Y3Qg Z3B1X3Bvd2VyX3NhbXBsZSAqdDAsCj4gKwkJCQkgY29uc3Qgc3RydWN0IGdwdV9wb3dlcl9zYW1w bGUgKnQxKQo+ICt7Cj4gKwlyZXR1cm4gKHQxLT5lbmVyZ3kgLSB0MC0+ZW5lcmd5KSAqIHAtPnNj YWxlICogMWUtOTsKPiArfQo+ICsKPiArc3RhdGljIGlubGluZSBkb3VibGUgZ3B1X3Bvd2VyX1co Y29uc3Qgc3RydWN0IGdwdV9wb3dlciAqcCwKPiArCQkJCSBjb25zdCBzdHJ1Y3QgZ3B1X3Bvd2Vy X3NhbXBsZSAqdDAsCj4gKwkJCQkgY29uc3Qgc3RydWN0IGdwdV9wb3dlcl9zYW1wbGUgKnQxKQo+ ICt7Cj4gKwlyZXR1cm4gKHQxLT5lbmVyZ3kgLSB0MC0+ZW5lcmd5KSAqIHAtPnNjYWxlIC8gKHQx LT50aW1lIC0gdDAtPnRpbWUpOwo+ICt9Cj4gKwo+ICsjZW5kaWYgLyogSUdUX0dQVV9QT1dFUl9I ICovCj4gZGlmZiAtLWdpdCBhL2xpYi9tZXNvbi5idWlsZCBiL2xpYi9tZXNvbi5idWlsZAo+IGlu ZGV4IDBlYjU1ODVkNy4uODlkZTA2ZTY5IDEwMDY0NAo+IC0tLSBhL2xpYi9tZXNvbi5idWlsZAo+ ICsrKyBiL2xpYi9tZXNvbi5idWlsZAo+IEBAIC05LDkgKzksMTEgQEAgbGliX3NvdXJjZXMgPSBb Cj4gICAJJ2lndF9kZWJ1Z2ZzLmMnLAo+ICAgCSdpZ3RfZGV2aWNlLmMnLAo+ICAgCSdpZ3RfYXV4 LmMnLAo+ICsJJ2lndF9ncHVfcG93ZXIuYycsCj4gICAJJ2lndF9ndC5jJywKPiAgIAknaWd0X2d2 dC5jJywKPiAgIAknaWd0X21hdHJpeC5jJywKPiArCSdpZ3RfcGVyZi5jJywKPiAgIAknaWd0X3By aW1lcy5jJywKPiAgIAknaWd0X3JhbmQuYycsCj4gICAJJ2lndF9zdGF0cy5jJywKPiAKClJlZ2Fy ZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2