Re: [PATCH i-g-t 2/5] lib/rand: move static inlines to proper functions

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Jani

On 18-06-2026 07:39 pm, Jani Nikula wrote:
> Hide the implementation details. Gut feeling says this also allows the
> compiler to do better optimizations within the compilation unit.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Patch LGTM

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

> ---
>   lib/igt_rand.c | 13 +++++++++++++
>   lib/igt_rand.h | 13 ++-----------
>   2 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/lib/igt_rand.c b/lib/igt_rand.c
> index 16a6ba9b0c65..b2856d000450 100644
> --- a/lib/igt_rand.c
> +++ b/lib/igt_rand.c
> @@ -35,3 +35,16 @@ uint32_t hars_petruska_f54_1_random_unsafe(void)
>   {
>   	return hars_petruska_f54_1_random(&global);
>   }
> +
> +void hars_petruska_f54_1_random_perturb(uint32_t xor)
> +{
> +	uint32_t seed = hars_petruska_f54_1_random_seed(0) ^ xor;
> +	hars_petruska_f54_1_random_seed(seed);
> +	hars_petruska_f54_1_random_seed(hars_petruska_f54_1_random_unsafe());
> +}
> +
> +/* Returns: pseudo-random number in interval [0, ep_ro) */
> +uint32_t hars_petruska_f54_1_random_unsafe_max(uint32_t ep_ro)
> +{
> +	return ((uint64_t)hars_petruska_f54_1_random_unsafe() * ep_ro) >> 32;
> +}
> diff --git a/lib/igt_rand.h b/lib/igt_rand.h
> index 0015680461c1..d89803bb020b 100644
> --- a/lib/igt_rand.h
> +++ b/lib/igt_rand.h
> @@ -32,17 +32,8 @@ uint64_t hars_petruska_f54_1_random64(uint32_t *s);
>   uint32_t hars_petruska_f54_1_random_seed(uint32_t seed);
>   uint32_t hars_petruska_f54_1_random_unsafe(void);
>   
> -static inline void hars_petruska_f54_1_random_perturb(uint32_t xor)
> -{
> -	uint32_t seed = hars_petruska_f54_1_random_seed(0) ^ xor;
> -	hars_petruska_f54_1_random_seed(seed);
> -	hars_petruska_f54_1_random_seed(hars_petruska_f54_1_random_unsafe());
> -}
> +void hars_petruska_f54_1_random_perturb(uint32_t xor);
>   
> -/* Returns: pseudo-random number in interval [0, ep_ro) */
> -static inline uint32_t hars_petruska_f54_1_random_unsafe_max(uint32_t ep_ro)
> -{
> -	return ((uint64_t)hars_petruska_f54_1_random_unsafe() * ep_ro) >> 32;
> -}
> +uint32_t hars_petruska_f54_1_random_unsafe_max(uint32_t ep_ro);
>   
>   #endif /* IGT_RAND_H */