From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8088089686 for ; Thu, 7 May 2020 05:56:38 +0000 (UTC) References: <20200505132032.827-1-anshuman.gupta@intel.com> <20200505132032.827-2-anshuman.gupta@intel.com> From: "Manna, Animesh" Message-ID: <2118909e-914e-d15a-5384-233c87cdf4e1@intel.com> Date: Thu, 7 May 2020 11:26:32 +0530 MIME-Version: 1.0 In-Reply-To: <20200505132032.827-2-anshuman.gupta@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t v6 1/6] tests/i915_pm_lpsp: Nuke the panel-fitter test List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0023257025==" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Anshuman Gupta , igt-dev@lists.freedesktop.org Cc: jani.nikula@intel.com List-ID: This is a multi-part message in MIME format. --===============0023257025== Content-Type: multipart/alternative; boundary="------------49AF6A6769FAAE5389E901A4" Content-Language: en-US This is a multi-part message in MIME format. --------------49AF6A6769FAAE5389E901A4 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 05-05-2020 18:50, Anshuman Gupta wrote: > panel-fitter subtest is only applicable to HASWELL/BROADWELL. > It just tests non-lpsp(lpsp disabled) when panel fitter is > enforced by std 1024x768 mode. > There is no ROI to test non-lpsp kind of thing, > If HSW_GLOBAL power well is not enabled we would see > other display issues in other display tests. > > Gen9+ platform has display scaling feature in built per > pipe, as lpsp is all about low power single pipe (PIPE A) > usage, gen9+ platforms also don't require panel-fitter subtest. > This should save some CI cycles. > > Signed-off-by: Anshuman Gupta Changes looks good to me. Reviewed-by: Animesh Manna > --- > tests/i915/i915_pm_lpsp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c > index 42938e10..08f82e7c 100644 > --- a/tests/i915/i915_pm_lpsp.c > +++ b/tests/i915/i915_pm_lpsp.c > @@ -219,8 +219,6 @@ igt_main > screens_disabled_subtest(drm_fd, drm_res); > igt_subtest("edp-native") > edp_subtest(drm_fd, drm_res, drm_connectors, devid, false); > - igt_subtest("edp-panel-fitter") > - edp_subtest(drm_fd, drm_res, drm_connectors, devid, true); > igt_subtest("non-edp") > non_edp_subtest(drm_fd, drm_res, drm_connectors); > --------------49AF6A6769FAAE5389E901A4 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit


On 05-05-2020 18:50, Anshuman Gupta wrote:
panel-fitter subtest is only applicable to HASWELL/BROADWELL.
It just tests non-lpsp(lpsp disabled) when panel fitter is
enforced by std 1024x768 mode.
There is no ROI to test non-lpsp kind of thing,
If HSW_GLOBAL power well is not enabled we would see
other display issues in other display tests.

Gen9+ platform has display scaling feature in built per
pipe, as lpsp is all about low power single pipe (PIPE A)
usage, gen9+ platforms also don't require panel-fitter subtest.
This should save some CI cycles.

Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
Changes looks good to me.
Reviewed-by: Animesh Manna <animesh.manna@intel.com>

---
 tests/i915/i915_pm_lpsp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
index 42938e10..08f82e7c 100644
--- a/tests/i915/i915_pm_lpsp.c
+++ b/tests/i915/i915_pm_lpsp.c
@@ -219,8 +219,6 @@ igt_main
 		screens_disabled_subtest(drm_fd, drm_res);
 	igt_subtest("edp-native")
 		edp_subtest(drm_fd, drm_res, drm_connectors, devid, false);
-	igt_subtest("edp-panel-fitter")
-		edp_subtest(drm_fd, drm_res, drm_connectors, devid, true);
 	igt_subtest("non-edp")
 		non_edp_subtest(drm_fd, drm_res, drm_connectors);
--------------49AF6A6769FAAE5389E901A4-- --===============0023257025== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev --===============0023257025==--