From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id C1EA66E3B9 for ; Wed, 31 Oct 2018 21:35:16 +0000 (UTC) From: Dhinakaran Pandiyan Date: Wed, 31 Oct 2018 14:35:12 -0700 Message-ID: <2196993.byX2TTvEGL@dk-thinkpad-x260> In-Reply-To: <20181030162038.27373-4-ville.syrjala@linux.intel.com> References: <20181030162038.27373-1-ville.syrjala@linux.intel.com> <20181030162038.27373-4-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 4/5] tests/kms_plane: Test all modifiers as well List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: igt-dev@lists.freedesktop.org List-ID: T24gVHVlc2RheSwgT2N0b2JlciAzMCwgMjAxOCA5OjIwOjM3IEFNIFBEVCBWaWxsZSBTeXJqYWxh IHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cj4gCj4gSW5zdGVhZCBvZiBqdXN0IHRlc3RpbmcgZWFjaCBwaXhlbCBmb3JtYXQgbGV0 J3MgdGVzdCBldmVyeQo+IGZvcm1hdCttb2RpZmllciBjb21iby4KPiAKPiBPYnZpb3VzbHkgdGVz dGluZyB3aXRoIHNvbGlkIGZpbGxlZCBmYnMgaXNuJ3QgdGhlIG1vc3QgZWZmZWN0aXZlCj4gd2F5 IHRvIGRldGVjdCB0aWxpbmcgcHJvYmxlbXMsIGJ1dCB3ZSBjYW4ndCByZWFsbHkgZG8gbXVjaCBt b3JlIGlmCj4gd2Ugd2FudCB0byBrZWVwIGNvbXBhcmluZyBZVVYgdnMuIFJHQiByZXN1bHRzICh1 bmxlc3Mgd2Ugc3RhcnQgdG8KPiByZW5kZXIgdGhlIFJHQiBjb250ZW50IGluIGEgd2F5IHRoYXQg bWF0Y2hlcyB0aGUgWVVWIHN1YnNhbXBsaW5nCj4gYmVoYXZpb3VyIG9mIHRoZSBoYXJkd2FyZSku Cj4gCj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiAtLS0KPiAgdGVzdHMva21zX3BsYW5lLmMgfCAzMCArKysrKysrKysrKysr KysrKysrLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDEx IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS90ZXN0cy9rbXNfcGxhbmUuYyBiL3Rlc3Rz L2ttc19wbGFuZS5jCj4gaW5kZXggNDVlMGEzMDRlOGNlLi41ZTQ5OGQxNDg1NmYgMTAwNjQ0Cj4g LS0tIGEvdGVzdHMva21zX3BsYW5lLmMKPiArKysgYi90ZXN0cy9rbXNfcGxhbmUuYwo+IEBAIC00 MDYsMTQgKzQwNiwxNSBAQCBzdGF0aWMgdm9pZCBzZXRfbGVnYWN5X2x1dChkYXRhX3QgKmRhdGEs IGVudW0gcGlwZSBwaXBlLAo+ICAKPiAgc3RhdGljIHZvaWQgdGVzdF9mb3JtYXRfcGxhbmVfY29s b3IoZGF0YV90ICpkYXRhLCBlbnVtIHBpcGUgcGlwZSwKPiAgCQkJCSAgICBpZ3RfcGxhbmVfdCAq cGxhbmUsCj4gLQkJCQkgICAgdWludDMyX3QgZm9ybWF0LCBpbnQgd2lkdGgsIGludCBoZWlnaHQs Cj4gKwkJCQkgICAgdWludDMyX3QgZm9ybWF0LCB1aW50NjRfdCBtb2RpZmllciwKPiArCQkJCSAg ICBpbnQgd2lkdGgsIGludCBoZWlnaHQsCj4gIAkJCQkgICAgaW50IGNvbG9yLCBpZ3RfY3JjX3Qg KmNyYywgc3RydWN0IGlndF9mYiAqZmIpCj4gIHsKPiAgCWNvbnN0IGNvbG9yX3QgKmMgPSAmY29s b3JzW2NvbG9yXTsKPiAgCXN0cnVjdCBpZ3RfZmIgb2xkX2ZiID0gKmZiOwo+ICAKPiAgCWlndF9j cmVhdGVfY29sb3JfZmIoZGF0YS0+ZHJtX2ZkLCB3aWR0aCwgaGVpZ2h0LAo+IC0JCQkgICAgZm9y bWF0LCBMT0NBTF9EUk1fRk9STUFUX01PRF9OT05FLAo+ICsJCQkgICAgZm9ybWF0LCBtb2RpZmll ciwKPiAgCQkJICAgIGMtPnJlZCwgYy0+Z3JlZW4sIGMtPmJsdWUsIGZiKTsKPiAgCj4gIAlpZ3Rf cGxhbmVfc2V0X2ZiKHBsYW5lLCBmYik7Cj4gQEAgLTQzMiw2ICs0MzMsNyBAQCBzdGF0aWMgdm9p ZCB0ZXN0X2Zvcm1hdF9wbGFuZShkYXRhX3QgKmRhdGEsIGVudW0gcGlwZSBwaXBlLAo+ICAJc3Ry dWN0IGlndF9mYiBmYiA9IHt9Owo+ICAJZHJtTW9kZU1vZGVJbmZvICptb2RlOwo+ICAJdWludDMy X3QgZm9ybWF0LCByZWZfZm9ybWF0Owo+ICsJdWludDY0X3QgbW9kaWZpZXIsIHJlZl9tb2RpZmll cjsKPiAgCXVpbnQ2NF90IHdpZHRoLCBoZWlnaHQ7Cj4gIAlpZ3RfY3JjX3QgcmVmX2NyY1tBUlJB WV9TSVpFKGNvbG9ycyldOwo+ICAKPiBAQCAtNDQwLDYgKzQ0Miw3IEBAIHN0YXRpYyB2b2lkIHRl c3RfZm9ybWF0X3BsYW5lKGRhdGFfdCAqZGF0YSwgZW51bSBwaXBlIHBpcGUsCj4gIAkJd2lkdGgg PSBtb2RlLT5oZGlzcGxheTsKPiAgCQloZWlnaHQgPSBtb2RlLT52ZGlzcGxheTsKPiAgCQlyZWZf Zm9ybWF0ID0gZm9ybWF0ID0gRFJNX0ZPUk1BVF9YUkdCODg4ODsKPiArCQlyZWZfbW9kaWZpZXIg PSBtb2RpZmllciA9IERSTV9GT1JNQVRfTU9EX05PTkU7Cj4gIAl9IGVsc2Ugewo+ICAJCWlmICgh cGxhbmUtPmRybV9wbGFuZSkgewo+ICAJCQlpZ3RfZGVidWcoIk9ubHkgbGVnYWN5IGN1cnNvciBp b2N0bCBzdXBwb3J0ZWQsIHNraXBwaW5nIGN1cnNvciBwbGFuZVxuIik7Cj4gQEAgLTQ0OCw2ICs0 NTEsNyBAQCBzdGF0aWMgdm9pZCB0ZXN0X2Zvcm1hdF9wbGFuZShkYXRhX3QgKmRhdGEsIGVudW0g cGlwZSBwaXBlLAo+ICAJCWRvX29yX2RpZShkcm1HZXRDYXAoZGF0YS0+ZHJtX2ZkLCBEUk1fQ0FQ X0NVUlNPUl9XSURUSCwgJndpZHRoKSk7Cj4gIAkJZG9fb3JfZGllKGRybUdldENhcChkYXRhLT5k cm1fZmQsIERSTV9DQVBfQ1VSU09SX0hFSUdIVCwgJmhlaWdodCkpOwo+ICAJCXJlZl9mb3JtYXQg PSBmb3JtYXQgPSBEUk1fRk9STUFUX0FSR0I4ODg4Owo+ICsJCXJlZl9tb2RpZmllciA9IG1vZGlm aWVyID0gRFJNX0ZPUk1BVF9NT0RfTk9ORTsKPiAgCX0KPiAgCj4gIAlpZ3RfZGVidWcoIlRlc3Rp bmcgY29ubmVjdG9yICVzIG9uICVzIHBsYW5lICVzLiV1XG4iLAo+IEBAIC00NjgsMjIgKzQ3Miwy NSBAQCBzdGF0aWMgdm9pZCB0ZXN0X2Zvcm1hdF9wbGFuZShkYXRhX3QgKmRhdGEsIGVudW0gcGlw ZSBwaXBlLAo+ICAJdGVzdF9pbml0KGRhdGEsIHBpcGUpOwo+ICAJaWd0X3BpcGVfY3JjX3N0YXJ0 KGRhdGEtPnBpcGVfY3JjKTsKPiAgCj4gLQlpZ3RfaW5mbygiVGVzdGluZyBmb3JtYXQgIiBJR1Rf Rk9STUFUX0ZNVCAiIG9uICVzLiV1XG4iLAo+IC0JCSBJR1RfRk9STUFUX0FSR1MoZm9ybWF0KSwK PiArCWlndF9pbmZvKCJUZXN0aW5nIGZvcm1hdCAiIElHVF9GT1JNQVRfRk1UICIgLyBtb2RpZmll ciAweCUiIFBSSXg2NCAiIG9uICVzLiV1XG4iLAo+ICsJCSBJR1RfRk9STUFUX0FSR1MoZm9ybWF0 KSwgbW9kaWZpZXIsCj4gIAkJIGttc3Rlc3RfcGlwZV9uYW1lKHBpcGUpLCBwbGFuZS0+aW5kZXgp Owo+ICAKPiAgCWZvciAoaW50IGkgPSAwOyBpIDwgQVJSQVlfU0laRShjb2xvcnMpOyBpKyspIHsK PiAgCQl0ZXN0X2Zvcm1hdF9wbGFuZV9jb2xvcihkYXRhLCBwaXBlLCBwbGFuZSwKPiAtCQkJCQlm b3JtYXQsIHdpZHRoLCBoZWlnaHQsCj4gKwkJCQkJZm9ybWF0LCBtb2RpZmllciwKVXNlIHJlZl9m b3JtYXQgYW5kIHJlZl9tb2RpZmllciBoZXJlPyAKCkknbGwgbGVhdmUgaXQgdG8geW91IGlmIHlv dSB3YW50IHRvIGFkZHJlc3MgdGhhdCBuaXQuClJldmlld2VkLWJ5OiBEaGluYWthcmFuIFBhbmRp eWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KCj4gKwkJCQkJd2lkdGgsIGhlaWdo dCwKPiAgCQkJCQlpLCAmcmVmX2NyY1tpXSwgJmZiKTsKPiAgCX0KPiAgCj4gLQlmb3IgKGludCBp ID0gMDsgaSA8IHBsYW5lLT5kcm1fcGxhbmUtPmNvdW50X2Zvcm1hdHM7IGkrKykgewo+ICsJZm9y IChpbnQgaSA9IDA7IGkgPCBwbGFuZS0+Zm9ybWF0X21vZF9jb3VudDsgaSsrKSB7Cj4gIAkJaWd0 X2NyY190IGNyYzsKPiAgCj4gLQkJZm9ybWF0ID0gcGxhbmUtPmRybV9wbGFuZS0+Zm9ybWF0c1tp XTsKPiArCQlmb3JtYXQgPSBwbGFuZS0+Zm9ybWF0c1tpXTsKPiArCQltb2RpZmllciA9IHBsYW5l LT5tb2RpZmllcnNbaV07Cj4gIAo+IC0JCWlmIChmb3JtYXQgPT0gcmVmX2Zvcm1hdCkKPiArCQlp ZiAoZm9ybWF0ID09IHJlZl9mb3JtYXQgJiYKPiArCQkgICAgbW9kaWZpZXIgPT0gcmVmX21vZGlm aWVyKQo+ICAJCQljb250aW51ZTsKPiAgCj4gIAkJaWYgKCFpZ3RfZmJfc3VwcG9ydGVkX2Zvcm1h dChmb3JtYXQpKQo+IEBAIC00OTksMTMgKzUwNiwxNCBAQCBzdGF0aWMgdm9pZCB0ZXN0X2Zvcm1h dF9wbGFuZShkYXRhX3QgKmRhdGEsIGVudW0gcGlwZSBwaXBlLAo+ICAJCWlmIChmb3JtYXQgPT0g RFJNX0ZPUk1BVF9YQkdSODg4OCkKPiAgCQkJY29udGludWU7Cj4gIAo+IC0JCWlndF9pbmZvKCJU ZXN0aW5nIGZvcm1hdCAiIElHVF9GT1JNQVRfRk1UICIgb24gJXMuJXVcbiIsCj4gLQkJCSBJR1Rf Rk9STUFUX0FSR1MoZm9ybWF0KSwKPiArCQlpZ3RfaW5mbygiVGVzdGluZyBmb3JtYXQgIiBJR1Rf Rk9STUFUX0ZNVCAiIC8gbW9kaWZpZXIgMHglIiBQUkl4NjQgIiBvbiAlcy4ldVxuIiwKPiArCQkJ IElHVF9GT1JNQVRfQVJHUyhmb3JtYXQpLCBtb2RpZmllciwKPiAgCQkJIGttc3Rlc3RfcGlwZV9u YW1lKHBpcGUpLCBwbGFuZS0+aW5kZXgpOwo+ICAKPiAgCQlmb3IgKGludCBqID0gMDsgaiA8IEFS UkFZX1NJWkUoY29sb3JzKTsgaisrKSB7Cj4gIAkJCXRlc3RfZm9ybWF0X3BsYW5lX2NvbG9yKGRh dGEsIHBpcGUsIHBsYW5lLAo+IC0JCQkJCQlmb3JtYXQsIHdpZHRoLCBoZWlnaHQsCj4gKwkJCQkJ CWZvcm1hdCwgbW9kaWZpZXIsCj4gKwkJCQkJCXdpZHRoLCBoZWlnaHQsCj4gIAkJCQkJCWosICZj cmMsICZmYik7Cj4gIAo+ICAJCQlpZ3RfYXNzZXJ0X2NyY19lcXVhbCgmY3JjLCAmcmVmX2NyY1tq XSk7Cj4gCgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK