From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915: Improve static engine map for legacy
Date: Thu, 23 May 2019 10:27:49 +0100 [thread overview]
Message-ID: <21ecf0f1-5b77-4c5c-23df-75a36c428a2d@linux.intel.com> (raw)
In-Reply-To: <155860258858.28319.3356284881218976685@skylake-alporthouse-com>
On 23/05/2019 10:09, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-05-23 09:46:08)
>>
>> On 23/05/2019 09:06, Chris Wilson wrote:
>>> const struct intel_execution_engine2 intel_execution_engines2[] = {
>>> - { "rcs0", I915_ENGINE_CLASS_RENDER, 0 },
>>> - { "bcs0", I915_ENGINE_CLASS_COPY, 0 },
>>> - { "vcs0", I915_ENGINE_CLASS_VIDEO, 0 },
>>> - { "vcs1", I915_ENGINE_CLASS_VIDEO, 1 },
>>> - { "vcs2", I915_ENGINE_CLASS_VIDEO, 2 },
>>> - { "vecs0", I915_ENGINE_CLASS_VIDEO_ENHANCE, 0 },
>>> + { "rcs0", I915_ENGINE_CLASS_RENDER, 0, I915_EXEC_RENDER },
>>> + { "bcs0", I915_ENGINE_CLASS_COPY, 0, I915_EXEC_BLT },
>>> + { "vcs0", I915_ENGINE_CLASS_VIDEO, 0, I915_EXEC_BSD | I915_EXEC_BSD_RING1 },
>>
>> execbuf will reject this on single vcs parts. :( Am I not seeing some
>> place where you fudge it into compliance?
>
>
> if (user_ring_id == I915_EXEC_BSD && HAS_ENGINE(dev_priv, VCS1)) {
> unsigned int bsd_idx = args->flags & I915_EXEC_BSD_MASK;
>
> if (bsd_idx == I915_EXEC_BSD_DEFAULT) {
> bsd_idx = gen8_dispatch_bsd_engine(dev_priv, file);
> } else if (bsd_idx >= I915_EXEC_BSD_RING1 &&
> bsd_idx <= I915_EXEC_BSD_RING2) {
> bsd_idx >>= I915_EXEC_BSD_SHIFT;
> bsd_idx--;
> } else {
> DRM_DEBUG("execbuf with unknown bsd ring: %u\n",
> bsd_idx);
> return NULL;
> }
>
> engine = dev_priv->engine[_VCS(bsd_idx)];
> } else {
> engine = dev_priv->engine[user_ring_map[user_ring_id]];
> }
>
> Looks ok to me... I was trying to double check but dif didn't boot on
> bsw. Sigh.
Hmm I would have sworn we used to do that.. strange. Okay, I'll re-read
your patch. Notice that I did not know you are working on it so have
sent my own fix at similar time.
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-05-23 9:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 8:06 [igt-dev] [PATCH i-g-t] i915: Improve static engine map for legacy Chris Wilson
2019-05-23 8:33 ` Andi Shyti
2019-05-23 8:46 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin
2019-05-23 9:09 ` Chris Wilson
2019-05-23 9:14 ` Chris Wilson
2019-05-23 9:35 ` Tvrtko Ursulin
2019-05-23 9:46 ` Chris Wilson
2019-05-23 9:27 ` Tvrtko Ursulin [this message]
2019-05-23 9:27 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-05-23 9:48 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Tvrtko Ursulin
2019-05-23 11:23 ` Chris Wilson
2019-05-24 3:42 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21ecf0f1-5b77-4c5c-23df-75a36c428a2d@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox