Re: [PATCH i-g-t v1 1/4] tests/prime_udl: Fix opening

[Karthik B S <karthik.b.s@intel.com>]

Hi Kamil,

On 12/16/2025 4:06 AM, Kamil Konieczny wrote:
> Cards numbering can be non-squential so create a way to open them
> in such case.

Typo: non-sequential.

>
> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/prime_udl.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/prime_udl.c b/tests/prime_udl.c
> index 25950a09d..c3e92be1e 100644
> --- a/tests/prime_udl.c
> +++ b/tests/prime_udl.c
> @@ -27,13 +27,13 @@ static int find_and_open_devices(void)
>   	FILE *fl;
>   	char vendor_id[8];
>   	int venid;
> -	for (i = 0; i < 9; i++) {
> +	for (i = 0; i < 9 && intel_fd == -1 && udl_fd == -1; i++) {
>   		sprintf(path, "/sys/class/drm/card%d/device/vendor", i);
>   		if (stat(path, &buf)) {
>   			/* look for usb dev */
>   			sprintf(path, "/sys/class/drm/card%d/device/idVendor", i);
>   			if (stat(path, &buf))
> -				break;
> +				continue;
>   		}
>   
>   		fl = fopen(path, "r");
> @@ -45,11 +45,11 @@ static int find_and_open_devices(void)
>   
>   		venid = strtoul(vendor_id, NULL, 16);
>   		sprintf(path, "/dev/dri/card%d", i);
> -		if (venid == 0x8086) {
> +		if (venid == 0x8086 && intel_fd == -1) {
>   			intel_fd = open(path, O_RDWR);
>   			if (!intel_fd)
>   				return -1;
> -		} else if (venid == 0x17e9) {
> +		} else if (venid == 0x17e9 && udl_fd == -1) {
>   			udl_fd = open(path, O_RDWR);
>   			if (!udl_fd)
>   				return -1;