From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
igt-dev@lists.freedesktop.org, swati2.sharma@intel.com
Subject: Re: [igt-dev] [i-g-t] lib/igt_fb: Stop using rendercopy for linear buffers on XE
Date: Wed, 21 Jun 2023 14:47:00 +0300 [thread overview]
Message-ID: <22260e84-a0dd-6a5e-8e67-39034d75abfe@gmail.com> (raw)
In-Reply-To: <20230621081405.2168956-1-bhanuprakash.modem@intel.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 21.6.2023 11.14, Bhanuprakash Modem wrote:
> Stop using rendercopy for linear buffers on XE driver, instead
> use the mmap.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> lib/igt_fb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 9be312a28..402fadf41 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -2511,7 +2511,6 @@ static bool use_enginecopy(const struct igt_fb *fb)
>
> return fb->modifier == I915_FORMAT_MOD_Yf_TILED ||
> is_ccs_modifier(fb->modifier) ||
> - (is_xe_device(fb->fd) && fb->modifier == DRM_FORMAT_MOD_LINEAR) ||
> (is_i915_device(fb->fd) && !gem_has_mappable_ggtt(fb->fd));
> }
>
next prev parent reply other threads:[~2023-06-21 11:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 8:14 [igt-dev] [i-g-t] lib/igt_fb: Stop using rendercopy for linear buffers on XE Bhanuprakash Modem
2023-06-21 9:17 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-21 11:47 ` Juha-Pekka Heikkila [this message]
2023-06-21 19:17 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22260e84-a0dd-6a5e-8e67-39034d75abfe@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox