From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Chunming Zhou <david1.zhou@amd.com>
Subject: Re: [igt-dev] [PATCH i-g-t 4/5] igt: add timeline test cases
Date: Fri, 17 May 2019 17:39:03 +0100 [thread overview]
Message-ID: <226ace36-705b-0c24-ba1f-e1c3ee02be97@intel.com> (raw)
In-Reply-To: <155803703764.12244.7038339565301348228@skylake-alporthouse-com>
On 16/05/2019 21:03, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2019-05-16 15:39:49)
>> +static int
>> +__syncobj_timeline_signal(int fd, uint32_t *handles, uint64_t *points, uint32_t count)
>> +{
>> + struct drm_syncobj_timeline_array array = { 0 };
> Note you can use the gcc {} extension here.
>
>> + int err = 0;
>> +
>> + array.handles = to_user_pointer(handles);
>> + array.points = to_user_pointer(points);
>> + array.count_handles = count;
>> + if (drmIoctl(fd, DRM_IOCTL_SYNCOBJ_TIMELINE_SIGNAL, &array))
>> + err = -errno;
> Clear errno afterwards, it just gets left around and messes up assert
> strings.
>
> Use igt_assume(err) otherwise Petri will have to silence coverity later.
>
> Use igt_ioctl() instead of drmIoctl() so that we can replace the
> drmIoctl() with the fancy error/signal injection wrappers or whatever
> takes our fancy later.
> -Chris
>
Thanks,
Applied the changes locally, will resend next week just in case more
comments appear.
-Lionel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-05-17 16:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 14:39 [igt-dev] [PATCH i-g-t 0/5] tests: Add timeline syncobj tests Lionel Landwerlin
2019-05-16 14:39 ` [igt-dev] [PATCH i-g-t 1/5] lib/syncobj: fix comment typo Lionel Landwerlin
2019-05-16 14:39 ` [igt-dev] [PATCH i-g-t 2/5] include: bump drm headers Lionel Landwerlin
2019-05-16 14:39 ` [igt-dev] [PATCH i-g-t 3/5] lib/syncobj: drop local declarations Lionel Landwerlin
2019-05-16 14:39 ` [igt-dev] [PATCH i-g-t 4/5] igt: add timeline test cases Lionel Landwerlin
2019-05-16 20:03 ` Chris Wilson
2019-05-17 16:39 ` Lionel Landwerlin [this message]
2019-05-16 14:39 ` [igt-dev] [PATCH i-g-t 5/5] tests/syncobj_timeline: add more timeline tests Lionel Landwerlin
2019-05-16 15:12 ` [igt-dev] ✓ Fi.CI.BAT: success for tests: Add timeline syncobj tests Patchwork
2019-05-16 19:50 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=226ace36-705b-0c24-ba1f-e1c3ee02be97@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=david1.zhou@amd.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox