From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Check for hangs allowed
Date: Mon, 28 Jan 2019 11:00:43 +0000 [thread overview]
Message-ID: <22c79445-42e5-7a45-bbf3-0106cf38e2c5@linux.intel.com> (raw)
In-Reply-To: <20190128101849.21355-1-chris@chris-wilson.co.uk>
On 28/01/2019 10:18, Chris Wilson wrote:
> Check we can reset the GPU before running the reset test.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> Different meaning of flags, it's not the ring id!
> ---
> tests/perf_pmu.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> index 21292bf3a..c9881e59f 100644
> --- a/tests/perf_pmu.c
> +++ b/tests/perf_pmu.c
> @@ -1812,8 +1812,13 @@ igt_main
> accuracy(fd, e, pct[i], 10);
> }
>
> - igt_subtest_f("busy-hang-%s", e->name)
> + igt_subtest_f("busy-hang-%s", e->name) {
> + igt_hang_t hang = igt_allow_hang(fd, 0, 0);
> +
> single(fd, e, TEST_BUSY | FLAG_HANG);
> +
> + igt_disallow_hang(fd, hang);
> + }
> }
>
> /**
>
So all IGTs which trigger hangs/resets should call this?
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-01-28 11:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 10:14 [igt-dev] [PATCH i-g-t] i915/perf_pmu: Check for hangs allowed Chris Wilson
2019-01-28 10:18 ` Chris Wilson
2019-01-28 11:00 ` Tvrtko Ursulin [this message]
2019-01-28 11:36 ` [igt-dev] [Intel-gfx] " Chris Wilson
2019-01-28 10:54 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/perf_pmu: Check for hangs allowed (rev2) Patchwork
2019-01-28 13:04 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22c79445-42e5-7a45-bbf3-0106cf38e2c5@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox