From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 401E5C87FCB for ; Wed, 30 Jul 2025 13:41:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ECA7D10E6AB; Wed, 30 Jul 2025 13:41:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="DA5X8gBR"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 10EAA10E6AB for ; Wed, 30 Jul 2025 13:41:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753882903; x=1785418903; h=message-id:date:subject:from:to:references:in-reply-to: mime-version; bh=oZhoFwGLxLmM1okzCJGDTidFWcW59Rk6f6Y9QtYl1s4=; b=DA5X8gBRsoU+TeNBsQLVFwoHpzLNK3RYoOTonM6dEQKktAZp0Vls22Fx jAU975afO/NCHsE1H2DcJ66ae6kqGStEy36LgxAPK58SOqW2o6Im7xeci zeWuPJhAHVoR0Ruw015YlVGvGz6AGivXu2paj3c5yH+r6X3S5maGSL7DP HIicLbWz/jKVQE5Oo4a7fwzUV2XsX0ArukVKO2/EeDIIDhWvzyqAYOTpX mN4vrbCaUAAOMK54uFt06AI1GFeN9/CXhJBEtnsIg8ZY6CxNCfincUMYQ 0L6yS8ghYKa8WMq4EuoDdx3w0urN17zwuwEpxxD+lA7MJ0d5HVLSdoh1D Q==; X-CSE-ConnectionGUID: ppFmLolwSaSgvEpXzNksjg== X-CSE-MsgGUID: 3WL05ueCRdqJmQx2SaPe1g== X-IronPort-AV: E=McAfee;i="6800,10657,11507"; a="73638575" X-IronPort-AV: E=Sophos;i="6.16,350,1744095600"; d="scan'208,217";a="73638575" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2025 06:41:43 -0700 X-CSE-ConnectionGUID: JI7bTTdZRGqM3j33wV7d0Q== X-CSE-MsgGUID: T+skRB4qTFexOMdDe35u4g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,350,1744095600"; d="scan'208,217";a="168402477" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2025 06:41:40 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.26; Wed, 30 Jul 2025 06:41:39 -0700 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.26 via Frontend Transport; Wed, 30 Jul 2025 06:41:39 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (40.107.100.52) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.26; Wed, 30 Jul 2025 06:41:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ulfmj4jt7dhIEbyT5IxcGlq1RFXV5laBL9qaPVly2A/TsIdoQWCpuv/O3ceQX/JMm38CCDiAtgpbCWM8NBR1nTCVzYD0D+87O6kB5hniij0I7/cQo0N5eMPZBJBXJfa3jykJUDDb/Fttl3VzGE+eThRh89GytBAztZ0/b2fiZHtO2nh3TKbrIsGcVh1IDu5H1owxYG2NsOYix3X9q/IQoL5OQ+vAcpdwnkMIz9ItXtDiLQ+cJdkCt2jIKHppeyPTgK/Qlkn7YJasnqRb0vU7t+LmXDSKm3ir5MuwLo0wkzOwDLUoo6gCXAU/VhsfIKDzK96wJ79o/0BMfknwluEdkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ge4d+IfFnSIIc03F40tAdiBI86f3Lmy77ULM+NK9aR0=; b=GOJxKI1lObXLiW9+UpZBsCcwe5pW0pZactjAoyhreqcVZDW6GA8rVmMDK6Z4gAwdd+wDBMPmB/JIwz9wCFJ3i0KFhyRn9h0fcN/GmBHzI+ogq/IOWnqT5ONou+fmRahQJOgKWQDYNNxwNsI1FZSkB2fqHYTxRhkqX49Wt4ruT0ay79EJTTJinSZZN32V4j4IX1IwqLoC0xxj/4D7HY4yRmVGd/HEv7HG1v3EhpuIB0pLnkdKCGX20asEqoIM6FyejnoN7pqMhC8CbzNihjHNr2/5b4XGLNMoXxhcT1zW2V27RVvMf0WdqFVeZF48wHKBSUKIS9q+ubAovHzx2zjvqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB7151.namprd11.prod.outlook.com (2603:10b6:303:220::5) by PH7PR11MB6500.namprd11.prod.outlook.com (2603:10b6:510:213::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.27; Wed, 30 Jul 2025 13:41:35 +0000 Received: from MW4PR11MB7151.namprd11.prod.outlook.com ([fe80::3e94:e15c:782b:bb92]) by MW4PR11MB7151.namprd11.prod.outlook.com ([fe80::3e94:e15c:782b:bb92%6]) with mapi id 15.20.8964.024; Wed, 30 Jul 2025 13:41:34 +0000 Content-Type: multipart/alternative; boundary="------------9gjZc0E4dhvN4Wc0AA98fN3Y" Message-ID: <22db93da-ce74-408a-a2a7-abcbb135fa1b@intel.com> Date: Wed, 30 Jul 2025 19:11:29 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH i-g-t] lib/xe_gt: Assertion related to xe_gt_stats_get_count From: "Sharma, Nishit" To: , References: <20250729054703.3323716-1-priyanka.dandamudi@intel.com> <272c6c41-0ed2-4b93-9f22-ee77b6c695b8@intel.com> Content-Language: en-US In-Reply-To: <272c6c41-0ed2-4b93-9f22-ee77b6c695b8@intel.com> X-ClientProxiedBy: MA5P287CA0043.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:175::6) To MW4PR11MB7151.namprd11.prod.outlook.com (2603:10b6:303:220::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR11MB7151:EE_|PH7PR11MB6500:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e5ca422-8e08-42e4-228b-08ddcf6ecc5d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|8096899003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cWJBd0VFQ01SdlhKMUdHaEIxeHlaQUptNEF2T2JWNnVkTVR1L1RRbWFZb3lv?= =?utf-8?B?UVlsYnFxTUJnRVRJaGJWL0U1eGMrb25SVWNZNWpRMFRIbmFPZitZakhnTDdn?= =?utf-8?B?OVJ2ZTB5T3dmVEhnQStyY0FrNTVXbnMrWU1LWkc3dTYxS1Vndm0wTEl6TElG?= =?utf-8?B?RmJyUEJZUnNpK0w5RDNSU3pMemJMZmQvbWUydHdEWnVZZWxzeHlHL1M1UkVX?= =?utf-8?B?bmVZRENnK21LdTIzL3JvK05YNnFxcTArNFZnQ2NWanpseCtnRHI1ejJmWGRm?= =?utf-8?B?eGZLL3MrQmJvSU55TVhDbkYzZzZtUXg2MjZDUHRETkh3d05UMjkrU3NycW1O?= =?utf-8?B?NUhXdnhSOXFCbTdPQmk2M2pEck9kYktSeVhFZ2U2UzExZTl6M2l4K2ovQ0dC?= =?utf-8?B?TEhrZUZ2MndKZGRMUGFreVl0d0xjWGEyR1dKdkNKWG9keGRqSlBzOTA2dTls?= =?utf-8?B?R2k5S09LejZpK2lFZm1hc3VLYzhRR3hQWDl5MlI3R2t5TU5QYW5QVmo3U0FV?= =?utf-8?B?NnpmL2puamlhOUt4dDNaVkVUODdYVi9vUVFTSDdleXZXRTcvSStLdVk0ODdi?= =?utf-8?B?YnBOc0UrSnRiQ2tTQStBeW94bUZQTDE1UThoV09SbmwySjRwcUU4SzFhanZa?= =?utf-8?B?OXpVOTAzT1l1clVlRlVSUkhmNDdpeHdoanB3Sll1Z3o1Q2ZaUjZCOW5DbUtB?= =?utf-8?B?dVFDaHNFbDQ2emVGNE40YXAwQjJ4ZFUvTVZ3MXB0ZmJiMnczbFhUVmZDWUIr?= =?utf-8?B?RWdVbVpRTi9IT0NXNnFYV2JaK0tLQUllTTZ4U3ZIWHd3TlRvOEd2WVh0QjVQ?= =?utf-8?B?NTZjZm50RklMbTVDYjYraVhqVVY3MjFvd0ovYkxiR1B1eSt4dlR3aW02VFNz?= =?utf-8?B?WklRRWZoWVI4WkdvUFpQZGZiSEREQmxIYmdrZmlQYi9YODZncGZNVEpJMitF?= =?utf-8?B?akgwcXJmZUpNWlcrbWN0VGNZYUhJS2ZVMDRKTHVpQ0o5bHZmUXFWUno0VTB2?= =?utf-8?B?RnprK0NSNDZPRG9BcFp0MmFLdDdKVzJhRDZDdVQzWktmYjJjZlJVRnY2TGxE?= =?utf-8?B?UmlabDh4NjJsU3RsMDRMU3VLWGJxZG5FV1B6NHo1ZEc4Y1gxeEFvbDVTRlZo?= =?utf-8?B?Q3ZVM3d4MFVtY256NzRqc1lNb0FpcSs4QVQ4Vjk5QWtnM1dJTmdTWk1nVy9p?= =?utf-8?B?YlZrN1dUVnJJTW03NDg3MGVhZy9hSURSekwyd241VTFaajgvOFEvV3YvSTFj?= =?utf-8?B?aWlwNlNacnlPYzRhWU5XOXhjV294UWNPMmFhK3poWGZNeDR3UFBpVGpGd09m?= =?utf-8?B?Sms2ZGRHaEl4b0NTSGJvSlBxWFVmbzhhRzJ0dGVNalBZS1lRQ0sxTm5TTHZ5?= =?utf-8?B?dDN0YUpEQVUzV0lLR3d5SktaQjBTV3dRUjdBRWphMWt6RVB0NHB6UGQxSldk?= =?utf-8?B?WU1QaE53Snk0RE1Nbk1YbExFMVRubWxkUWVvVlNGQkJDeUtvUjVoZDVLcWtZ?= =?utf-8?B?NlJnQStoMTNOVnliWUd1cjdKd25ERWphd2Rvajk1dTdPSTdaUGtjK2RkTjg3?= =?utf-8?B?RGtXd2NOSWdoWS9scm5jTXBBRk9BVnRuNmVLRnFtU2FhUWJIVE4vbXcvcmJP?= =?utf-8?B?MXF0SklocDBpWXdUdW5lWG5JTEJlaHRpbER3bE5NR3NVbWlsZlhXU1U5cFhX?= =?utf-8?B?SnpxNmtWWTQrMlZ6RG5XZ2wvdm9NeStrVmErcmNET1VaVis1LzNSenNyaEVj?= =?utf-8?B?VHJ3czBtWVhGNXFBdmdGeFlsQi9XNWo0bUFkNE9ERTVuZ0FpdEhDMFkydFBq?= =?utf-8?B?S0NMeXdUWkdrdzF1bDh3VnlzSjZIekZOVjlzalQrcUpJZGNBL0xnMlFzY0sy?= =?utf-8?B?S0ZqQ0psZUxqczhoRjM5SGdTbjJaRDE0NXczU0FWSExrc2J0QWdtZHNoR0xy?= =?utf-8?Q?LiBv5+AuVVY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB7151.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(8096899003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXAvaWVxVUlWbTZLK1luelNtR0FuOFh0ZUZkdjUvS0N1d1VYbWNwOFczRHpB?= =?utf-8?B?cTY3WUxLVXpEU2pzM3RmSVZtdHk4MTB4MmxRcEZmc3k0Mnc4WEFLK2NBZlNt?= =?utf-8?B?elZBQlp4Y1A0QWViSVZFYkhwQ1hkYUZIbnByUHBiaTJJTVBaZXNBczBDbGRx?= =?utf-8?B?S0VaU0pNZG5GbDJKS0pZa0VVQ2U0MW95OVZEVTEzam1FYVV1L2hZNUJmVTQ4?= =?utf-8?B?VmVzc0pCTXg4WkZTNUVDU2NKRzF1TWxYbXBFUUlpR2VHK3ZhdWZYVmRSenlx?= =?utf-8?B?eEVnckpCelRydHUyS05ZaFgrTnhHNEw4NENkVmpxQytqWkNMOStWek1CQ251?= =?utf-8?B?bEJBTjVUS2pMT0g4am5wY01qcGZlQzA1RTZtcDYyd2ptRnY2c1lOQ09rOUZS?= =?utf-8?B?S2kwS1RXdWFkVzkvSlJBTzZSNHpWZGZlVklOTXlsQlpNZnlGWStLQ2UwQm5D?= =?utf-8?B?amJhR0dzL09ndCtHbEtFako0YkJ0bUlpVjVhaGRYcVJMbTVCclJkdElkaGxi?= =?utf-8?B?RW9ZRGtkaGhQaVBPUFRGZXZiNzBsMnFySjFQSDE3WmZ1OVdxVEtXRDFXV3RG?= =?utf-8?B?eUNpV0YwdkZpOHlTdkh3TUUvdmQ4RFQ2Z3IxZ0ZpSmxaZWVGUThXSGJxTXB0?= =?utf-8?B?dU9STk9CMjJCK3A0cmNvYUtnZ05CUEN4bTlZTkJML1FiYldOYWY1T1FBeDUw?= =?utf-8?B?ZHVNWUNXQWtnVDJIcXZaak05N0ZpNFluc0FybGNEZW1maVRZYWl6VzlBK1hY?= =?utf-8?B?bDBVRzdLWnQ1MU9HSzhkR2NjQWRLZUF6endPekdBQlp4bThrQXVDallZbC9l?= =?utf-8?B?V1hjYmwySWJOSU9kaE4zN3JLT1pnWXdjb3E1SEhOR1diQVhTK1laNDJFeUdh?= =?utf-8?B?bUxrUU5SUUt6NzVFZFRCY01aWE1FMW44bTRKL3VSdjB4aTFJUDVoQU1pc0Uy?= =?utf-8?B?Mnp3R0crakIyMlREeWhiRWhlMXVLZlJTWnZBOWRDMTRWOWdTYTZpMzRKaEJk?= =?utf-8?B?R1hmRHdvYWVwclpYWHlSSG9Fb2RNZ2VSUjk5SXdnRlhXV2s2YnNnNmlNTzJD?= =?utf-8?B?MXhMN3VxMkdiRFNFTFpLbzVrVDZJcDZyWlVFTVJ2WHlmeU9vWFdRbU9CT05Y?= =?utf-8?B?S1lxUnM2SWNPTGhxZ1NsNmorTVo3MCthVzE4MFVVNDZpK29sYnlieS9mMjJn?= =?utf-8?B?bU91S3lDTHZoTEI0OVh0RXJpMEhOZ2JjUmN0aDk5RWJuYWk0RmdFcGs2VmM3?= =?utf-8?B?SjNpVkFCSVh4YmNHcWp3WVBDMWpxN2w2eElSajBhNTBHajFlZjQyY01DZng3?= =?utf-8?B?YVRyQU5vTG1pSVMySVhCRjdNMFdpWXA1K0Q5NHpxTnhXbW1nRG1XcThQNDhr?= =?utf-8?B?OVJqL1Y3TDFKM3FlUk1uWExHd3loU0daZTJVRzF0dEhZaXRKY1N1eHhMMXMz?= =?utf-8?B?eDZnYzhiQnlEYjlSOGNLalVzdGM2c0VrREdMQkRxSHN5NE5jUGRGTXhEdU9j?= =?utf-8?B?bHkzSXlLVWwyakViQStibFJFOU9GSjBNcE43dmdNS0dNa2tmaExOM3Q1cnFu?= =?utf-8?B?MnlDQUJTRTd6MmVrbUZtREVCWG9rcDl3ZzNneVduU0pjZE5ROVY4cGdPK0Zs?= =?utf-8?B?NWl5T0MrUnJPb21UNlZDenYyL1FrL2JzZGZsZG5QcjlwSFZtOUZwU1ZrVExl?= =?utf-8?B?d0k3V3piZGNHRUVXbTVRckcyYVgzSVpRWU1WTWswNXR4LzRLSlphZHlwOUJo?= =?utf-8?B?M05aMWdJUWI5dTFFbVVWVitFTHAyQWxCY1BnQ3NFUlJmZnR4YnNJWHFrK3VD?= =?utf-8?B?WXhjTXBYT0RINlc3R2pobjQ1WjV6WVdEV1NORGdzZGcwVllydDZIUENwd3ZK?= =?utf-8?B?emRBT2xrd2VBME0veC9Uelp2YmRCbTFzdUE4V2p1STNGa1U4eThiaVpoWGxX?= =?utf-8?B?M2hiaDhiQi85YjkwbFBieWpyZzBxREZnZnlLcU96R3pGelVEb1hKNjVjRDBr?= =?utf-8?B?Rm1kT0hpUS9UckJJaXpDdlRDeitKd1d6MS9qei9aZ3dBQzFpN2lRVTZjVzdG?= =?utf-8?B?NjRZak9heXlOSnZZMWxMWUVmTzlzRzJNbmx2cWhYRVJOdEQrbE4zbzRVNmxU?= =?utf-8?B?Y09ReXFtVmswSjlOY2hJMGRMRU93WjJyd2tCaXBlSWdjOEpUdFNZOFRmbVRV?= =?utf-8?B?Znc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0e5ca422-8e08-42e4-228b-08ddcf6ecc5d X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB7151.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 13:41:34.3775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7bHtUkyucBrq0aWQSjWyIDBvli7RtmcSRnZ7ozotcqYaHU+iP/uaXfN8unoJ04JJ5RBSRyvozNetGzyT9Vc8Fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6500 X-OriginatorOrg: intel.com X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" --------------9gjZc0E4dhvN4Wc0AA98fN3Y Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 7/30/2025 12:28 PM, Sharma, Nishit wrote: > > On 7/29/2025 11:17 AM, priyanka.dandamudi@intel.com wrote: >> From: Priyanka Dandamudi >> >> Currently, when the specific gt stats file is not found, it fails with >> an assertion. Due to this the test using this function also fails. >> In general, this lib function is just to count the stats count, test >> using this need not fail.So, now the function will warn the failure >> when file not found and return -1 as count. >> >> Signed-off-by: Priyanka Dandamudi >> --- >>   lib/xe/xe_gt.c | 7 +++++-- >>   1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/lib/xe/xe_gt.c b/lib/xe/xe_gt.c >> index afb757bfa..ed19bec74 100644 >> --- a/lib/xe/xe_gt.c >> +++ b/lib/xe/xe_gt.c >> @@ -185,8 +185,11 @@ int xe_gt_stats_get_count(int fd, int gt, const >> char *stat) >>           minor(st.st_rdev), gt); >>       f = fopen(path, "r"); >>   -    igt_assert_f(f, "Failed to open >> /sys/kernel/debug/dri/%d/gt%d/stats", >> -             minor(st.st_rdev), gt); >> +    if (!f) { >> +        igt_warn("Failed to open /sys/kernel/debug/dri/%d/gt%d/stats", >> +             minor(st.st_rdev), gt); >> +        return -1; >> +    } > Looks fine! Reviewed-by: Nishit Sharma >>         while (fgets(tlb_path, sizeof(tlb_path), f)) { >>           if (strstr(tlb_path, stat) != NULL) { --------------9gjZc0E4dhvN4Wc0AA98fN3Y Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit


On 7/30/2025 12:28 PM, Sharma, Nishit wrote:

On 7/29/2025 11:17 AM, priyanka.dandamudi@intel.com wrote:
From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Currently, when the specific gt stats file is not found, it fails with
an assertion. Due to this the test using this function also fails.
In general, this lib function is just to count the stats count, test
using this need not fail.So, now the function will warn the failure
when file not found and return -1 as count.

Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
  lib/xe/xe_gt.c | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/xe/xe_gt.c b/lib/xe/xe_gt.c
index afb757bfa..ed19bec74 100644
--- a/lib/xe/xe_gt.c
+++ b/lib/xe/xe_gt.c
@@ -185,8 +185,11 @@ int xe_gt_stats_get_count(int fd, int gt, const char *stat)
          minor(st.st_rdev), gt);
      f = fopen(path, "r");
  -    igt_assert_f(f, "Failed to open /sys/kernel/debug/dri/%d/gt%d/stats",
-             minor(st.st_rdev), gt);
+    if (!f) {
+        igt_warn("Failed to open /sys/kernel/debug/dri/%d/gt%d/stats",
+             minor(st.st_rdev), gt);
+        return -1;
+    }
Looks fine! 

Reviewed-by: Nishit Sharma <nishit.sharma@intel.com>


        while (fgets(tlb_path, sizeof(tlb_path), f)) {
          if (strstr(tlb_path, stat) != NULL) {
--------------9gjZc0E4dhvN4Wc0AA98fN3Y--