From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_eio: Check for allow-hang prior to issuing a reset
Date: Tue, 29 Jan 2019 15:36:38 -0800 [thread overview]
Message-ID: <2359fa40-e835-44af-8205-bb7c5cd1f6fa@intel.com> (raw)
In-Reply-To: <20190127124902.10139-1-chris@chris-wilson.co.uk>
On 27/01/19 04:49, Chris Wilson wrote:
> Check that we are allowed to hang/reset the GPU before we actually do so
> for the first time.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_eio.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c
> index 5250a414c..09059c311 100644
> --- a/tests/i915/gem_eio.c
> +++ b/tests/i915/gem_eio.c
> @@ -745,14 +745,14 @@ igt_main
> fd = drm_open_driver(DRIVER_INTEL);
> igt_device_drop_master(fd);
>
> - igt_require(i915_reset_control(true));
> - igt_force_gpu_reset(fd);
> - igt_install_exit_handler(exit_handler);
> -
> gem_submission_print_method(fd);
> igt_require_gem(fd);
>
> igt_allow_hang(fd, 0, 0);
> +
> + igt_require(i915_reset_control(true));
Don't we do this already in allow_hang?
Antnoio
> + igt_force_gpu_reset(fd);
> + igt_install_exit_handler(exit_handler);
> }
>
> igt_subtest("throttle")
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-01-29 23:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 12:49 [igt-dev] [PATCH i-g-t] i915/gem_eio: Check for allow-hang prior to issuing a reset Chris Wilson
2019-01-27 13:20 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-27 14:15 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-01-29 23:36 ` Antonio Argenziano [this message]
2019-01-29 23:41 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2359fa40-e835-44af-8205-bb7c5cd1f6fa@intel.com \
--to=antonio.argenziano@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox