public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Rudnicki, Piotr" <piotr.rudnicki@intel.com>
To: "Dominik Karol Piątkowski" <dominik.karol.piatkowski@intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/1] tests/xe_eudebug_online: Skip canary check in set-breakpoint-sigint-debugger
Date: Wed, 11 Feb 2026 15:06:57 +0100	[thread overview]
Message-ID: <243504b7-abf5-4ee5-9fb6-b2effa3e36d5@intel.com> (raw)
In-Reply-To: <20260211135549.14135-2-dominik.karol.piatkowski@intel.com>

Hi Dominik,

> Unfortunate signal timing can result in tripping over count_canaries_eq
> assert in run_online_client in set-breakpoint-sigint-debugger test. Skip
> canary check in this case, as it is not important for this testcase.
> 
> Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@intel.com>
LGTM,
Reviewed-by: Piotr Rudnicki <piotr.rudnicki@intel.com>
> ---
>   tests/intel/xe_eudebug_online.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c
> index 39ecca479..059f918a6 100644
> --- a/tests/intel/xe_eudebug_online.c
> +++ b/tests/intel/xe_eudebug_online.c
> @@ -1667,6 +1667,9 @@ static void test_set_breakpoint_online_sigint_debugger(int fd,
>   	max_sleep_time = set_breakpoint_time * 11 / 10;
>   	igt_info("Maximum sleep_time: %" PRIu64 " us\n", max_sleep_time);
>   
> +	/* Skip checking canaries as they can be invalid due to signal timing */
> +	flags |= DO_NOT_EXPECT_CANARIES;
> +
>   	ts = (struct timespec) { };
>   	igt_nsec_elapsed(&ts);
>   


  reply	other threads:[~2026-02-11 14:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 13:55 [PATCH i-g-t 0/1] tests/xe_eudebug_online: Skip canary check in set-breakpoint-sigint-debugger Dominik Karol Piątkowski
2026-02-11 13:55 ` [PATCH i-g-t 1/1] " Dominik Karol Piątkowski
2026-02-11 14:06   ` Rudnicki, Piotr [this message]
2026-02-11 16:56 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-02-11 17:12 ` ✓ i915.CI.BAT: " Patchwork
2026-02-12  5:17 ` ✗ i915.CI.Full: failure " Patchwork
2026-02-13  0:35 ` ✗ Xe.CI.FULL: " Patchwork
2026-02-13  9:04   ` Piatkowski, Dominik Karol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=243504b7-abf5-4ee5-9fb6-b2effa3e36d5@intel.com \
    --to=piotr.rudnicki@intel.com \
    --cc=dominik.karol.piatkowski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox